From f7064fc4fa3a333dc5793044050b1b7e0c654d55 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=96mer=20Sinan=20A=C4=9Facan?= Date: Fri, 29 Sep 2023 12:54:12 +0000 Subject: [PATCH] [infra,dart2wasm] Add dart2wasm Firefox test configurations MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I567732843bc305c4a42f10027cf0e9c705874713 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/328822 Commit-Queue: Ömer Ağacan Reviewed-by: Alexander Thomas --- pkg/smith/lib/configuration.dart | 1 + tools/bots/test_matrix.json | 9 +++++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/pkg/smith/lib/configuration.dart b/pkg/smith/lib/configuration.dart index 2f0f54a41ac..13c1ef792b7 100644 --- a/pkg/smith/lib/configuration.dart +++ b/pkg/smith/lib/configuration.dart @@ -858,6 +858,7 @@ class Compiler extends NamedEnum { Runtime.none, Runtime.d8, Runtime.chrome, + Runtime.firefox, ]; case Compiler.dart2analyzer: return const [Runtime.none]; diff --git a/tools/bots/test_matrix.json b/tools/bots/test_matrix.json index 317cb0523d8..9a1597b19e4 100644 --- a/tools/bots/test_matrix.json +++ b/tools/bots/test_matrix.json @@ -548,13 +548,13 @@ "timeout": 240 } }, - "dart2wasm-(linux|mac|win)-(d8|chrome)": { + "dart2wasm-(linux|mac|win)-(d8|chrome|firefox)": { "options": { "host-checked": true, "timeout": 240 } }, - "dart2wasm-(linux|mac|win)-optimized-(d8|chrome)": { + "dart2wasm-(linux|mac|win)-optimized-(d8|chrome|firefox)": { "options": { "dart2wasm-options": [ "-O" @@ -563,7 +563,7 @@ "timeout": 240 } }, - "dart2wasm-(linux|mac|win)-jscm-(d8|chrome)": { + "dart2wasm-(linux|mac|win)-jscm-(d8|chrome|firefox)": { "options": { "dart2wasm-options": [ "--js-compatibility" @@ -2732,7 +2732,8 @@ { "builders": [ "dart2wasm-linux-chrome", - "dart2wasm-linux-d8" + "dart2wasm-linux-d8", + "dart2wasm-linux-firefox" ], "meta": { "description": "dart2wasm tests"