languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-06 00:59:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ddc] Avoid calling addTypeCaches with new types

Browse source 
Some preparation for deleting all the old type system code.

Change-Id: I9319064100ce19a4122612c36781c7e4a71094aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352724
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
This commit is contained in:
Nicholas Shahan 2024-02-15 18:28:49 +00:00 committed by Commit Queue
parent 0cb3fcca48
commit f6ffe00f28
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkg/dev_compiler/lib/src/kernel/compiler.dart
View file

@ -985,8 +985,9 @@ class ProgramCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
];
body.add(runtimeStatement('addRtiResources(#, #)',
[className, js_ast.stringArray(implementedRecipes)]));
} else {
body.add(runtimeStatement('addTypeCaches(#)', [className]));
}
body.add(runtimeStatement('addTypeCaches(#)', [className]));
_emitClassSignature(c, className, body);
_initExtensionSymbols(c);

5
sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/classes.dart
View file

@ -710,6 +710,8 @@ Object typeTagSymbol(String recipe) {
/// The first element of [interfaceRecipes] must always be the type recipe for
/// the type represented by [classRef].
void addRtiResources(Object classRef, JSArray<String> interfaceRecipes) {
// Create a rti object cache property used in dart:_rti.
JS('', '#[#] = null', classRef, rti.constructorRtiCachePropertyName);
// Attach the [classRef]'s own interface type recipe.
// The recipe is used in dart:_rti to create an [rti.Rti] instance when
// needed.
@ -731,8 +733,7 @@ void addRtiResources(Object classRef, JSArray<String> interfaceRecipes) {
/// monomorphic, which results in faster execution in V8.
addTypeCaches(type) {
if (JS_GET_FLAG('NEW_RUNTIME_TYPES')) {
// Create a rti object cache property used in dart:_rti.
JS('', '#[#] = null', type, rti.constructorRtiCachePropertyName);
throwUnimplementedInCurrentRti();
} else {
JS('', '#[#] = void 0', type, _cachedLegacy);
JS('', '#[#] = void 0', type, _cachedNullable);