languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 00:13:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[dds] Unskip tests for checking devtools base href tags

Browse source 
Change-Id: Ic31344a65b04cb252aa661b2f9af411b5a148bd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243903
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
This commit is contained in:
Danny Tuppeny 2022-05-09 13:28:23 +00:00 committed by Commit Bot
parent 5ee800b366
commit f6e025ed27
2 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkg/dds/test/devtools_server/devtools_server_path_strategy_dds_test.dart
View file

@ -71,7 +71,5 @@ void main() {
} finally {
proc.kill();
}
// TODO(dantup): Unskip this test once DevTools has rolled into
// the SDK so that contains the (newly-added) base href tag.
}, timeout: const Timeout.factor(10), skip: true);
}, timeout: const Timeout.factor(10));
}

4
pkg/dds/test/devtools_server/devtools_server_path_strategy_test.dart
View file

@ -44,9 +44,7 @@ void main() {
httpClient.close();
server.kill();
}
// TODO(dantup): Unskip this test once DevTools has rolled into
// the SDK so that contains the (newly-added) base href tag.
}, timeout: const Timeout.factor(10), skip: true);
}, timeout: const Timeout.factor(10));
test('serves 404 contents for requests that are not pages', () async {
final server = await DevToolsServerDriver.create();