From f3793ab22d20d092869d93a873b3705cc18b9e41 Mon Sep 17 00:00:00 2001 From: Daco Harkes Date: Thu, 26 Sep 2019 17:31:50 +0000 Subject: [PATCH] [tools] Update generate_idefiles.py to exclude analyzing sdk_nnbd After https://dart-review.googlesource.com/c/sdk/+/116527 was landed, running the analyzer on the sdk root produces 14k+ messages instead of 2k+ messages. Note 1800 of those 2200 messages are TODOs. Change-Id: I9d75924b83ac9e2c42fd2ce4ca64b73d55c8fc53 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118987 Commit-Queue: Daco Harkes Auto-Submit: Daco Harkes Reviewed-by: Vijay Menon --- tools/generate_idefiles.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/generate_idefiles.py b/tools/generate_idefiles.py index 6e8ead53c8b..a7b89d801ce 100755 --- a/tools/generate_idefiles.py +++ b/tools/generate_idefiles.py @@ -84,7 +84,7 @@ def GenerateAnalysisOptions(options): To prevent dartanalyzer from tripping on the non-Dart files when it is started from the root dart-sdk directory. - https://github.com/Dart-Code/Dart-Code/issues/1295 + https://github.com/dart-lang/sdk/issues/35562 Args: options: supported options include: force, dir @@ -96,6 +96,7 @@ def GenerateAnalysisOptions(options): - runtime/** - samples-dev/swarm/** - sdk/lib/** + - sdk_nnbd/lib/** - tests/** - third_party/observatory_pub_packages/** - third_party/pkg/** @@ -106,7 +107,7 @@ def GenerateAnalysisOptions(options): - tools/dom/** - tools/sdks/dart-sdk/lib/** - tools/status_clean.dart - - xcodebuild / **""" + - xcodebuild/**""" fname = os.path.join(options.dir, "analysis_options.yaml")