languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-15 22:00:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

[VM/Runtime] - Remove TimelineEventBlockIterator which is dead code.

Browse source 
Dead since ff2fd8fe54.

TEST=Deleted code, no new functionality added. Regular CI runs.
Change-Id: I95716abfe9807eba48dbbc7fa3efc7f58cd1b11d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209760
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
This commit is contained in:
asiva 2021-08-10 19:53:41 +00:00 committed by commit-bot@chromium.org
parent 5447c3981e
commit f21c9d54ea
3 changed files with 0 additions and 59 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
runtime/vm/os_thread.h
View file

@ -62,7 +62,6 @@ class Mutex {
friend class MutexLocker;
friend class SafepointMutexLocker;
friend class OSThreadIterator;
friend class TimelineEventBlockIterator;
friend class TimelineEventRecorder;
friend class PageSpace;
friend void Dart_TestMutex();

38
runtime/vm/timeline.cc
View file

@ -1516,44 +1516,6 @@ void TimelineEventBlock::Finish() {
#endif
}
TimelineEventBlockIterator::TimelineEventBlockIterator(
TimelineEventRecorder* recorder)
: current_(NULL), recorder_(NULL) {
Reset(recorder);
}
TimelineEventBlockIterator::~TimelineEventBlockIterator() {
Reset(NULL);
}
void TimelineEventBlockIterator::Reset(TimelineEventRecorder* recorder) {
// Clear current.
current_ = NULL;
if (recorder_ != NULL) {
// Unlock old recorder.
recorder_->lock_.Unlock();
}
recorder_ = recorder;
if (recorder_ == NULL) {
return;
}
// Lock new recorder.
recorder_->lock_.Lock();
// Queue up first block.
current_ = recorder_->GetHeadBlockLocked();
}
bool TimelineEventBlockIterator::HasNext() const {
return current_ != NULL;
}
TimelineEventBlock* TimelineEventBlockIterator::Next() {
ASSERT(current_ != NULL);
TimelineEventBlock* r = current_;
current_ = current_->next();
return r;
}
void DartTimelineEventHelpers::ReportTaskEvent(Thread* thread,
TimelineEvent* event,
int64_t id,

20
runtime/vm/timeline.h
View file

@ -757,7 +757,6 @@ class TimelineEventRecorder : public MallocAllocated {
int64_t time_high_micros_;
friend class TimelineEvent;
friend class TimelineEventBlockIterator;
friend class TimelineStream;
friend class TimelineTestHelper;
friend class Timeline;
@ -887,25 +886,6 @@ class TimelineEventEndlessRecorder : public TimelineEventRecorder {
friend class TimelineTestHelper;
};
// An iterator for blocks.
class TimelineEventBlockIterator {
public:
explicit TimelineEventBlockIterator(TimelineEventRecorder* recorder);
~TimelineEventBlockIterator();
void Reset(TimelineEventRecorder* recorder);
// Returns false when there are no more blocks.
bool HasNext() const;
// Returns the next block and moves forward.
TimelineEventBlock* Next();
private:
TimelineEventBlock* current_;
TimelineEventRecorder* recorder_;
};
// The TimelineEventPlatformRecorder records timeline events to a platform
// specific destination. It's implementation is in the timeline_{linux,...}.cc
// files.