languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 12:24:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

[dart2js] stop using the deprecated NoSuchMethod consturctor

Browse source 
This change is a small incremental step, but should allow us to delete
the public NoSuchMethod constructor in dart:core. The change simply creates
a private constructor in the dart2js patch file and uses that instead.

https://github.com/dart-lang/sdk/issues/49529

Change-Id: I51cb2ec3b7f169a6cb831e753a3e5e9bf0752dbd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260940
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
This commit is contained in:
Sigmund Cherem 2022-09-29 01:58:56 +00:00 committed by Commit Queue
parent e1b5cbd266
commit efb509c114
2 changed files with 16 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
sdk/lib/_internal/js_runtime/lib/core_patch.dart
View file

@ -63,8 +63,7 @@ class Object {
@patch
dynamic noSuchMethod(Invocation invocation) {
throw new NoSuchMethodError(this, invocation.memberName,
invocation.positionalArguments, invocation.namedArguments);
throw new NoSuchMethodError.withInvocation(this, invocation);
}
@patch
@ -703,11 +702,17 @@ class NoSuchMethodError {
@patch
factory NoSuchMethodError.withInvocation(
Object? receiver, Invocation invocation) =>
NoSuchMethodError(receiver, invocation.memberName,
NoSuchMethodError._(receiver, invocation.memberName,
invocation.positionalArguments, invocation.namedArguments);
@patch
NoSuchMethodError(Object? receiver, Symbol memberName,
List? positionalArguments, Map<Symbol, dynamic>? namedArguments,
[List? existingArgumentNames = null])
: this._(receiver, memberName, positionalArguments, namedArguments,
existingArgumentNames);
NoSuchMethodError._(Object? receiver, Symbol memberName,
List? positionalArguments, Map<Symbol, dynamic>? namedArguments,
[List? existingArgumentNames = null])
: _receiver = receiver,
@ -848,7 +853,7 @@ _malformedTypeError(message) => new RuntimeError(message);
// Called from kernel generated code.
_genericNoSuchMethod(receiver, memberName, positionalArguments, namedArguments,
existingArguments) {
return new NoSuchMethodError(
return new NoSuchMethodError._(
receiver, memberName, positionalArguments, namedArguments);
}
@ -859,7 +864,7 @@ _unresolvedConstructorError(receiver, memberName, positionalArguments,
//
// No constructor '$memberName' declared in class '$receiver'.
return new NoSuchMethodError(
return new NoSuchMethodError._(
receiver, memberName, positionalArguments, namedArguments);
}
@ -867,7 +872,7 @@ _unresolvedConstructorError(receiver, memberName, positionalArguments,
_unresolvedStaticGetterError(receiver, memberName, positionalArguments,
namedArguments, existingArguments) {
// TODO(sra): Generate customized message.
return new NoSuchMethodError(
return new NoSuchMethodError._(
receiver, memberName, positionalArguments, namedArguments);
}
@ -875,7 +880,7 @@ _unresolvedStaticGetterError(receiver, memberName, positionalArguments,
_unresolvedStaticSetterError(receiver, memberName, positionalArguments,
namedArguments, existingArguments) {
// TODO(sra): Generate customized message.
return new NoSuchMethodError(
return new NoSuchMethodError._(
receiver, memberName, positionalArguments, namedArguments);
}
@ -883,7 +888,7 @@ _unresolvedStaticSetterError(receiver, memberName, positionalArguments,
_unresolvedStaticMethodError(receiver, memberName, positionalArguments,
namedArguments, existingArguments) {
// TODO(sra): Generate customized message.
return new NoSuchMethodError(
return new NoSuchMethodError._(
receiver, memberName, positionalArguments, namedArguments);
}
@ -891,7 +896,7 @@ _unresolvedStaticMethodError(receiver, memberName, positionalArguments,
_unresolvedTopLevelGetterError(receiver, memberName, positionalArguments,
namedArguments, existingArguments) {
// TODO(sra): Generate customized message.
return new NoSuchMethodError(
return new NoSuchMethodError._(
receiver, memberName, positionalArguments, namedArguments);
}
@ -899,7 +904,7 @@ _unresolvedTopLevelGetterError(receiver, memberName, positionalArguments,
_unresolvedTopLevelSetterError(receiver, memberName, positionalArguments,
namedArguments, existingArguments) {
// TODO(sra): Generate customized message.
return new NoSuchMethodError(
return new NoSuchMethodError._(
receiver, memberName, positionalArguments, namedArguments);
}
@ -907,7 +912,7 @@ _unresolvedTopLevelSetterError(receiver, memberName, positionalArguments,
_unresolvedTopLevelMethodError(receiver, memberName, positionalArguments,
namedArguments, existingArguments) {
// TODO(sra): Generate customized message.
return new NoSuchMethodError(
return new NoSuchMethodError._(
receiver, memberName, positionalArguments, namedArguments);
}

1
sdk/lib/core/errors.dart
View file

@ -489,7 +489,6 @@ class NoSuchMethodError extends Error {
external factory NoSuchMethodError.withInvocation(
Object? receiver, Invocation invocation);
// Deprecated constructor to be removed after dart2js updates to the above.
/// Create a [NoSuchMethodError] corresponding to a failed method call.
///
/// The [receiver] is the receiver of the method call.