languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 01:13:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Collect informative data for extensions.

Browse source 
R=brianwilkerson@google.com

Change-Id: I77866f1bb5e92c074ce700d041a392639f829efb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110130
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This commit is contained in:
Konstantin Shcheglov 2019-07-23 22:17:12 +00:00 committed by commit-bot@chromium.org
parent 6c43390cd8
commit ecaa530faf
4 changed files with 73 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

53
pkg/analyzer/lib/src/summary/format.dart
View file

@ -23367,6 +23367,7 @@ class UnlinkedInformativeDataBuilder extends Object
kind == idl.LinkedNodeKind.constructorDeclaration ||
kind == idl.LinkedNodeKind.defaultFormalParameter ||
kind == idl.LinkedNodeKind.enumDeclaration ||
kind == idl.LinkedNodeKind.extensionDeclaration ||
kind == idl.LinkedNodeKind.fieldFormalParameter ||
kind == idl.LinkedNodeKind.functionDeclaration ||
kind == idl.LinkedNodeKind.functionTypeAlias ||
@ -23387,6 +23388,7 @@ class UnlinkedInformativeDataBuilder extends Object
kind == idl.LinkedNodeKind.constructorDeclaration ||
kind == idl.LinkedNodeKind.defaultFormalParameter ||
kind == idl.LinkedNodeKind.enumDeclaration ||
kind == idl.LinkedNodeKind.extensionDeclaration ||
kind == idl.LinkedNodeKind.fieldFormalParameter ||
kind == idl.LinkedNodeKind.functionDeclaration ||
kind == idl.LinkedNodeKind.functionTypeAlias ||
@ -23409,6 +23411,7 @@ class UnlinkedInformativeDataBuilder extends Object
kind == idl.LinkedNodeKind.constructorDeclaration ||
kind == idl.LinkedNodeKind.defaultFormalParameter ||
kind == idl.LinkedNodeKind.enumDeclaration ||
kind == idl.LinkedNodeKind.extensionDeclaration ||
kind == idl.LinkedNodeKind.fieldFormalParameter ||
kind == idl.LinkedNodeKind.functionDeclaration ||
kind == idl.LinkedNodeKind.functionTypeAlias ||
@ -23429,6 +23432,7 @@ class UnlinkedInformativeDataBuilder extends Object
kind == idl.LinkedNodeKind.constructorDeclaration ||
kind == idl.LinkedNodeKind.defaultFormalParameter ||
kind == idl.LinkedNodeKind.enumDeclaration ||
kind == idl.LinkedNodeKind.extensionDeclaration ||
kind == idl.LinkedNodeKind.fieldFormalParameter ||
kind == idl.LinkedNodeKind.functionDeclaration ||
kind == idl.LinkedNodeKind.functionTypeAlias ||
@ -23497,6 +23501,7 @@ class UnlinkedInformativeDataBuilder extends Object
kind == idl.LinkedNodeKind.constructorDeclaration ||
kind == idl.LinkedNodeKind.enumConstantDeclaration ||
kind == idl.LinkedNodeKind.enumDeclaration ||
kind == idl.LinkedNodeKind.extensionDeclaration ||
kind == idl.LinkedNodeKind.fieldFormalParameter ||
kind == idl.LinkedNodeKind.functionDeclaration ||
kind == idl.LinkedNodeKind.functionTypedFormalParameter ||
@ -23526,6 +23531,7 @@ class UnlinkedInformativeDataBuilder extends Object
kind == idl.LinkedNodeKind.constructorDeclaration ||
kind == idl.LinkedNodeKind.enumConstantDeclaration ||
kind == idl.LinkedNodeKind.enumDeclaration ||
kind == idl.LinkedNodeKind.extensionDeclaration ||
kind == idl.LinkedNodeKind.fieldFormalParameter ||
kind == idl.LinkedNodeKind.functionDeclaration ||
kind == idl.LinkedNodeKind.functionTypedFormalParameter ||
@ -23547,6 +23553,7 @@ class UnlinkedInformativeDataBuilder extends Object
kind == idl.LinkedNodeKind.constructorDeclaration ||
kind == idl.LinkedNodeKind.enumDeclaration ||
kind == idl.LinkedNodeKind.enumConstantDeclaration ||
kind == idl.LinkedNodeKind.extensionDeclaration ||
kind == idl.LinkedNodeKind.fieldDeclaration ||
kind == idl.LinkedNodeKind.functionDeclaration ||
kind == idl.LinkedNodeKind.functionTypeAlias ||
@ -23564,6 +23571,7 @@ class UnlinkedInformativeDataBuilder extends Object
kind == idl.LinkedNodeKind.constructorDeclaration ||
kind == idl.LinkedNodeKind.enumDeclaration ||
kind == idl.LinkedNodeKind.enumConstantDeclaration ||
kind == idl.LinkedNodeKind.extensionDeclaration ||
kind == idl.LinkedNodeKind.fieldDeclaration ||
kind == idl.LinkedNodeKind.functionDeclaration ||
kind == idl.LinkedNodeKind.functionTypeAlias ||
@ -23659,6 +23667,17 @@ class UnlinkedInformativeDataBuilder extends Object
}) : _kind = idl.LinkedNodeKind.exportDirective,
_variantField_1 = directiveKeywordOffset;
UnlinkedInformativeDataBuilder.extensionDeclaration({
int codeLength,
int codeOffset,
int nameOffset,
List<String> documentationComment_tokens,
}) : _kind = idl.LinkedNodeKind.extensionDeclaration,
_variantField_2 = codeLength,
_variantField_3 = codeOffset,
_variantField_1 = nameOffset,
_variantField_4 = documentationComment_tokens;
UnlinkedInformativeDataBuilder.fieldDeclaration({
List<String> documentationComment_tokens,
}) : _kind = idl.LinkedNodeKind.fieldDeclaration,
@ -23801,6 +23820,7 @@ class UnlinkedInformativeDataBuilder extends Object
} else if (kind == idl.LinkedNodeKind.enumConstantDeclaration) {
} else if (kind == idl.LinkedNodeKind.enumDeclaration) {
} else if (kind == idl.LinkedNodeKind.exportDirective) {
} else if (kind == idl.LinkedNodeKind.extensionDeclaration) {
} else if (kind == idl.LinkedNodeKind.fieldDeclaration) {
} else if (kind == idl.LinkedNodeKind.fieldFormalParameter) {
} else if (kind == idl.LinkedNodeKind.functionDeclaration) {
@ -23905,6 +23925,19 @@ class UnlinkedInformativeDataBuilder extends Object
} else if (kind == idl.LinkedNodeKind.exportDirective) {
signature.addInt(this.kind == null ? 0 : this.kind.index);
signature.addInt(this.directiveKeywordOffset ?? 0);
} else if (kind == idl.LinkedNodeKind.extensionDeclaration) {
signature.addInt(this.kind == null ? 0 : this.kind.index);
signature.addInt(this.nameOffset ?? 0);
signature.addInt(this.codeLength ?? 0);
signature.addInt(this.codeOffset ?? 0);
if (this.documentationComment_tokens == null) {
signature.addInt(0);
} else {
signature.addInt(this.documentationComment_tokens.length);
for (var x in this.documentationComment_tokens) {
signature.addString(x);
}
}
} else if (kind == idl.LinkedNodeKind.fieldDeclaration) {
signature.addInt(this.kind == null ? 0 : this.kind.index);
if (this.documentationComment_tokens == null) {
@ -24111,6 +24144,7 @@ class _UnlinkedInformativeDataImpl extends Object
kind == idl.LinkedNodeKind.constructorDeclaration ||
kind == idl.LinkedNodeKind.defaultFormalParameter ||
kind == idl.LinkedNodeKind.enumDeclaration ||
kind == idl.LinkedNodeKind.extensionDeclaration ||
kind == idl.LinkedNodeKind.fieldFormalParameter ||
kind == idl.LinkedNodeKind.functionDeclaration ||
kind == idl.LinkedNodeKind.functionTypeAlias ||
@ -24133,6 +24167,7 @@ class _UnlinkedInformativeDataImpl extends Object
kind == idl.LinkedNodeKind.constructorDeclaration ||
kind == idl.LinkedNodeKind.defaultFormalParameter ||
kind == idl.LinkedNodeKind.enumDeclaration ||
kind == idl.LinkedNodeKind.extensionDeclaration ||
kind == idl.LinkedNodeKind.fieldFormalParameter ||
kind == idl.LinkedNodeKind.functionDeclaration ||
kind == idl.LinkedNodeKind.functionTypeAlias ||
@ -24187,6 +24222,7 @@ class _UnlinkedInformativeDataImpl extends Object
kind == idl.LinkedNodeKind.constructorDeclaration ||
kind == idl.LinkedNodeKind.enumConstantDeclaration ||
kind == idl.LinkedNodeKind.enumDeclaration ||
kind == idl.LinkedNodeKind.extensionDeclaration ||
kind == idl.LinkedNodeKind.fieldFormalParameter ||
kind == idl.LinkedNodeKind.functionDeclaration ||
kind == idl.LinkedNodeKind.functionTypedFormalParameter ||
@ -24208,6 +24244,7 @@ class _UnlinkedInformativeDataImpl extends Object
kind == idl.LinkedNodeKind.constructorDeclaration ||
kind == idl.LinkedNodeKind.enumDeclaration ||
kind == idl.LinkedNodeKind.enumConstantDeclaration ||
kind == idl.LinkedNodeKind.extensionDeclaration ||
kind == idl.LinkedNodeKind.fieldDeclaration ||
kind == idl.LinkedNodeKind.functionDeclaration ||
kind == idl.LinkedNodeKind.functionTypeAlias ||
@ -24289,6 +24326,13 @@ abstract class _UnlinkedInformativeDataMixin
if (directiveKeywordOffset != 0)
_result["directiveKeywordOffset"] = directiveKeywordOffset;
}
if (kind == idl.LinkedNodeKind.extensionDeclaration) {
if (codeLength != 0) _result["codeLength"] = codeLength;
if (codeOffset != 0) _result["codeOffset"] = codeOffset;
if (nameOffset != 0) _result["nameOffset"] = nameOffset;
if (documentationComment_tokens.isNotEmpty)
_result["documentationComment_tokens"] = documentationComment_tokens;
}
if (kind == idl.LinkedNodeKind.fieldDeclaration) {
if (documentationComment_tokens.isNotEmpty)
_result["documentationComment_tokens"] = documentationComment_tokens;
@ -24448,6 +24492,15 @@ abstract class _UnlinkedInformativeDataMixin
"kind": kind,
};
}
if (kind == idl.LinkedNodeKind.extensionDeclaration) {
return {
"codeLength": codeLength,
"codeOffset": codeOffset,
"nameOffset": nameOffset,
"documentationComment_tokens": documentationComment_tokens,
"kind": kind,
};
}
if (kind == idl.LinkedNodeKind.fieldDeclaration) {
return {
"documentationComment_tokens": documentationComment_tokens,

4
pkg/analyzer/lib/src/summary/idl.dart
View file

@ -3621,6 +3621,7 @@ abstract class UnlinkedInformativeData extends base.SummaryClass {
LinkedNodeKind.constructorDeclaration,
LinkedNodeKind.defaultFormalParameter,
LinkedNodeKind.enumDeclaration,
LinkedNodeKind.extensionDeclaration,
LinkedNodeKind.fieldFormalParameter,
LinkedNodeKind.functionDeclaration,
LinkedNodeKind.functionTypeAlias,
@ -3641,6 +3642,7 @@ abstract class UnlinkedInformativeData extends base.SummaryClass {
LinkedNodeKind.constructorDeclaration,
LinkedNodeKind.defaultFormalParameter,
LinkedNodeKind.enumDeclaration,
LinkedNodeKind.extensionDeclaration,
LinkedNodeKind.fieldFormalParameter,
LinkedNodeKind.functionDeclaration,
LinkedNodeKind.functionTypeAlias,
@ -3679,6 +3681,7 @@ abstract class UnlinkedInformativeData extends base.SummaryClass {
LinkedNodeKind.constructorDeclaration,
LinkedNodeKind.enumDeclaration,
LinkedNodeKind.enumConstantDeclaration,
LinkedNodeKind.extensionDeclaration,
LinkedNodeKind.fieldDeclaration,
LinkedNodeKind.functionDeclaration,
LinkedNodeKind.functionTypeAlias,
@ -3700,6 +3703,7 @@ abstract class UnlinkedInformativeData extends base.SummaryClass {
LinkedNodeKind.constructorDeclaration,
LinkedNodeKind.enumConstantDeclaration,
LinkedNodeKind.enumDeclaration,
LinkedNodeKind.extensionDeclaration,
LinkedNodeKind.fieldFormalParameter,
LinkedNodeKind.functionDeclaration,
LinkedNodeKind.functionTypedFormalParameter,

16
pkg/analyzer/lib/src/summary2/informative_data.dart
View file

@ -145,6 +145,22 @@ class _SetInformativeId extends SimpleAstVisitor<void> {
);
}
@override
void visitExtensionDeclaration(ExtensionDeclaration node) {
setData(
node,
UnlinkedInformativeDataBuilder.extensionDeclaration(
codeOffset: node.offset,
codeLength: node.length,
documentationComment_tokens: _nodeCommentTokens(node),
nameOffset: node.name.offset,
),
);
node.typeParameters?.accept(this);
node.members.accept(this);
}
@override
void visitFieldDeclaration(FieldDeclaration node) {
setData(

6
pkg/analyzer/test/src/summary/resynthesize_ast2_test.dart
View file

@ -136,12 +136,6 @@ class ResynthesizeAst2Test extends ResynthesizeTestStrategyTwoPhase
return elementFactory.libraryOfUri('${source.uri}');
}
@failingTest
@override
test_extension_documented_tripleSlash() async {
await super.test_extension_documented_tripleSlash();
}
void _addLibraryUnits(
Source definingSource,
CompilationUnit definingUnit,