From ea5840c2c5af4f78090044f092cfbdf38dba4bef Mon Sep 17 00:00:00 2001
From: William Hesse <whesse@google.com>
Date: Mon, 22 May 2023 14:14:42 +0000
Subject: [PATCH] [benchmarks] Update legacy benchmarks to use the List.filled
 constructor

The legacy Dart 2.9 benchmarks that used the default List(int size)
constructor are changed to use the equivalent List.filled(size, null)
constructor, because the default List constructor is removed.

Bug: b/280275041
Change-Id: I2813537ae22e19d473abde70d677368940585423
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/304700
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: William Hesse <whesse@google.com>
---
 DEPS                                        | 2 +-
 benchmarks/MD5/dart2/md5.dart               | 2 +-
 benchmarks/Richards/dart2/Richards.dart     | 4 ++--
 benchmarks/SHA1/dart2/sha1.dart             | 2 +-
 benchmarks/SHA256/dart2/sha256.dart         | 2 +-
 benchmarks/Utf8Encode/dart2/Utf8Encode.dart | 2 +-
 6 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/DEPS b/DEPS
index 660bf21381a..6295d9e9d40 100644
--- a/DEPS
+++ b/DEPS
@@ -55,7 +55,7 @@ vars = {
   "co19_2_rev": "ae846ed2a987a2d2dbe4b9e9c68448a21f91ef5b",
 
   # The internal benchmarks to use. See go/dart-benchmarks-internal
-  "benchmarks_internal_rev": "599aa474a03c37be146f82dfbad85f34f25ffa47",
+  "benchmarks_internal_rev": "a72da9eed591014535eb47d81185deca39e65ef5",
   "checkout_benchmarks_internal": False,
 
   # Checkout Android dependencies only on Mac and Linux.
diff --git a/benchmarks/MD5/dart2/md5.dart b/benchmarks/MD5/dart2/md5.dart
index ab0e2d2e046..e73b901c62d 100644
--- a/benchmarks/MD5/dart2/md5.dart
+++ b/benchmarks/MD5/dart2/md5.dart
@@ -15,7 +15,7 @@ class MD5Bench extends BenchmarkBase {
   List<int> data;
 
   MD5Bench() : super('MD5') {
-    data = List<int>(size);
+    data = List<int>.filled(size, null);
     for (int i = 0; i < data.length; i++) {
       data[i] = i % 256;
     }
diff --git a/benchmarks/Richards/dart2/Richards.dart b/benchmarks/Richards/dart2/Richards.dart
index 0cb0a1a0107..5e74efe4f2e 100644
--- a/benchmarks/Richards/dart2/Richards.dart
+++ b/benchmarks/Richards/dart2/Richards.dart
@@ -117,7 +117,7 @@ class Scheduler {
   int currentId;
   TaskControlBlock list;
   List<TaskControlBlock> blocks =
-      List<TaskControlBlock>(Richards.NUMBER_OF_IDS);
+      List<TaskControlBlock>.filled(Richards.NUMBER_OF_IDS, null);
 
   /// Add an idle task to this scheduler.
   void addIdleTask(int id, int priority, Packet queue, int count) {
@@ -428,7 +428,7 @@ class Packet {
   int kind; // The type of this packet.
   int a1 = 0;
 
-  List<int> a2 = List(Richards.DATA_SIZE);
+  List<int> a2 = List.filled(Richards.DATA_SIZE, null);
 
   Packet(this.link, this.id, this.kind);
 
diff --git a/benchmarks/SHA1/dart2/sha1.dart b/benchmarks/SHA1/dart2/sha1.dart
index 6c5c95af0cc..0b7128faf78 100644
--- a/benchmarks/SHA1/dart2/sha1.dart
+++ b/benchmarks/SHA1/dart2/sha1.dart
@@ -15,7 +15,7 @@ class SHA1Bench extends BenchmarkBase {
   List<int> data;
 
   SHA1Bench() : super('SHA1') {
-    data = List<int>(size);
+    data = List<int>.filled(size, null);
     for (int i = 0; i < data.length; i++) {
       data[i] = i % 256;
     }
diff --git a/benchmarks/SHA256/dart2/sha256.dart b/benchmarks/SHA256/dart2/sha256.dart
index dd3cae6ec94..e381dc0cf82 100644
--- a/benchmarks/SHA256/dart2/sha256.dart
+++ b/benchmarks/SHA256/dart2/sha256.dart
@@ -16,7 +16,7 @@ class SHA256Bench extends BenchmarkBase {
   List<int> data;
 
   SHA256Bench() : super('SHA256') {
-    data = List<int>(size);
+    data = List<int>.filled(size, null);
     for (int i = 0; i < data.length; i++) {
       data[i] = i % 256;
     }
diff --git a/benchmarks/Utf8Encode/dart2/Utf8Encode.dart b/benchmarks/Utf8Encode/dart2/Utf8Encode.dart
index 7bfaffbadbf..422756fe28e 100644
--- a/benchmarks/Utf8Encode/dart2/Utf8Encode.dart
+++ b/benchmarks/Utf8Encode/dart2/Utf8Encode.dart
@@ -45,7 +45,7 @@ class Utf8Encode extends BenchmarkBase {
     final String repeatedText = originalText * (size / nRunes).ceil();
     final List<int> runes = repeatedText.runes.toList();
     final int nChunks = (size < nRunes) ? (nRunes / size).floor() : 1;
-    benchmarkTextChunks = List<String>(nChunks);
+    benchmarkTextChunks = List<String>.filled(nChunks, null);
     for (int i = 0; i < nChunks; i++) {
       final offset = i * size;
       benchmarkTextChunks[i] =