From ea43e6e2670b806a7a0a0f907d73d17f01ce6723 Mon Sep 17 00:00:00 2001 From: Alexander Aprelev Date: Tue, 4 Aug 2020 21:25:39 +0000 Subject: [PATCH] [build] Make clang-cl targeting ia32 to be goma-compatible. Stack-alignment flags are not supported by clang-cl, warning messages produced by clang-cl throw off gomas compiler version detection. Change-Id: I259ed57e72f6c26eb1f01ac2c6dd49ec2e90978c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157100 Reviewed-by: Ryan Macnak Commit-Queue: Alexander Aprelev --- build/config/compiler/BUILD.gn | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn index 2db2871fdb2..3e06c162cf5 100644 --- a/build/config/compiler/BUILD.gn +++ b/build/config/compiler/BUILD.gn @@ -377,7 +377,7 @@ config("compiler") { # configs -= [ "//build/config/compiler:clang_stackrealign" ] # See https://crbug.com/556393 for details of where it must be avoided. config("clang_stackrealign") { - if (is_clang && current_cpu == "x86" && !is_nacl) { + if (is_clang && current_cpu == "x86" && !is_nacl && !is_win) { cflags = [ # Align the stack on 16-byte boundaries, http://crbug.com/418554. "-mstack-alignment=16", @@ -516,14 +516,14 @@ if (is_win) { if (is_clang) { default_warning_flags += [ - "-Wno-deprecated-declarations", # crashpad - "-Wno-ignored-pragma-optimize", # icu, double-conversion - "-Wno-implicit-int-float-conversion", # icu + "-Wno-deprecated-declarations", # crashpad + "-Wno-ignored-pragma-optimize", # icu, double-conversion + "-Wno-implicit-int-float-conversion", # icu "-Wno-macro-redefined", "-Wno-microsoft-cast", "-Wno-microsoft-unqualified-friend", - "-Wno-unknown-argument", # icu - "-Wno-unused-value", # crashpad + "-Wno-unknown-argument", # icu + "-Wno-unused-value", # crashpad ] } else { default_warning_flags += [