languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 01:59:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "[pkg/test_runner] Write experiments to results.json"

Browse source 
This reverts commit 4e34ea06a9.

Reason for revert: The data does not show up in bigquery

Original change's description:
> [pkg/test_runner] Write experiments to results.json
>
> Change-Id: I32423ddf665a24443de1ad60ca8f323f5c6d3aca
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196489
> Reviewed-by: Alexander Thomas <athom@google.com>
> Commit-Queue: Karl Klose <karlklose@google.com>

TBR=karlklose@google.com,athom@google.com

Change-Id: Ifccdf3a6031dd55bebfe5d282bcce21c5ab5632a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198403
Reviewed-by: Karl Klose <karlklose@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
This commit is contained in:
Karl Klose 2021-05-06 06:14:54 +00:00 committed by commit-bot@chromium.org
parent 4e34ea06a9
commit e97329da49
3 changed files with 6 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
pkg/test_runner/lib/src/compiler_configuration.dart
View file

@ -9,7 +9,6 @@ import 'configuration.dart';
import 'path.dart';
import 'repository.dart';
import 'runtime_configuration.dart';
import 'test_case.dart' show TestCase;
import 'test_file.dart';
import 'utils.dart';
@ -26,7 +25,10 @@ List<String> _replaceDartFiles(List<String> list, String replacement) {
/// list allows the result of calling this to be spread into another list.
List<String> _experimentsArgument(
TestConfiguration configuration, TestFile testFile) {
var experiments = TestCase.getExperiments(testFile, configuration);
var experiments = {
...configuration.experiments,
...testFile.experiments,
};
if (experiments.isEmpty) {
return const [];
}

10
pkg/test_runner/lib/src/test_case.dart
View file

@ -66,16 +66,6 @@ class TestCase {
assert(commands.isNotEmpty);
}
List<String> get experiments => getExperiments(testFile, configuration);
static List<String> getExperiments(
TestFile testFile, TestConfiguration configuration) {
return [
...testFile.experiments,
...configuration.experiments,
];
}
TestCase indexedCopy(int index) {
var newCommands = commands.map((c) => c.indexedCopy(index)).toList();
return TestCase(displayName, newCommands, configuration, expectedOutcomes,

5
pkg/test_runner/lib/src/test_progress.dart
View file

@ -656,7 +656,7 @@ class ResultWriter extends EventListener {
var testName = name.substring(index + 1);
var time =
test.commandOutputs.values.fold(Duration.zero, (d, o) => d + o.time);
var experiments = test.experiments;
var record = {
"name": name,
"configuration": test.configuration.configuration.name,
@ -665,8 +665,7 @@ class ResultWriter extends EventListener {
"time_ms": time.inMilliseconds,
"result": test.realResult.toString(),
"expected": test.realExpected.toString(),
"matches": test.realResult.canBeOutcomeOf(test.realExpected),
if (experiments.isNotEmpty) "experiments": experiments,
"matches": test.realResult.canBeOutcomeOf(test.realExpected)
};
_results.add(record);
if (test.configuration.writeLogs && record['matches'] != true) {