languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-07-20 08:54:56 +00:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

[SDK] Makes --lazy_async_stack default.

Browse source 
Bug: https://github.com/dart-lang/sdk/issues/42062
Change-Id: If22ed42b363e2d75d0be5cc14aef9e909b8ff2e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149288
Commit-Queue: Clement Skau <cskau@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
This commit is contained in:
Clement Skau 2020-11-06 14:12:52 +00:00 committed by commit-bot@chromium.org
parent 6101e4653b
commit e90967f29d
3 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pkg/test_runner/lib/src/compiler_configuration.dart
View file

@ -1085,8 +1085,7 @@ class SpecParserCompilerConfiguration extends CompilerConfiguration {
}
abstract class VMKernelCompilerMixin {
static final noCausalAsyncStacksRegExp =
RegExp('--no[_-]causal[_-]async[_-]stacks');
static final causalAsyncStacksRegExp = RegExp('--causal[_-]async[_-]stacks');
TestConfiguration get _configuration;
@ -1117,7 +1116,7 @@ abstract class VMKernelCompilerMixin {
var isProductMode = _configuration.configuration.mode == Mode.product;
var causalAsyncStacks = !arguments.any(noCausalAsyncStacksRegExp.hasMatch);
var causalAsyncStacks = arguments.any(causalAsyncStacksRegExp.hasMatch);
var args = [
_isAot ? '--aot' : '--no-aot',

2
runtime/vm/BUILD.gn
View file

@ -180,7 +180,7 @@ template("gen_vm_platform") {
"$root_out_dir/vm_outline" + output_postfix + ".dill",
]
args = [ "dart:core" ]
allow_causal_async_stacks = !is_product_flag
allow_causal_async_stacks = false
args += [
"-Ddart.vm.product=$is_product_flag",
"-Ddart.developer.causal_async_stacks=$allow_causal_async_stacks",

4
runtime/vm/flag_list.h
View file

@ -55,8 +55,8 @@ constexpr bool kDartUseBackgroundCompilation = true;
#define VM_GLOBAL_FLAG_LIST(P, R, C, D) \
P(dwarf_stack_traces_mode, bool, false, \
"Use --[no-]dwarf-stack-traces instead.") \
P(causal_async_stacks, bool, !USING_PRODUCT, "Improved async stacks") \
P(lazy_async_stacks, bool, false, "Reconstruct async stacks from listeners") \
P(causal_async_stacks, bool, false, "Improved async stacks") \
P(lazy_async_stacks, bool, true, "Reconstruct async stacks from listeners") \
P(lazy_dispatchers, bool, true, "Generate dispatchers lazily") \
P(use_bare_instructions, bool, true, "Enable bare instructions mode.") \
R(dedup_instructions, true, bool, false, \