languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 01:21:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

[dart2js] Use simple load ids on some bots.

Browse source 
Change-Id: I593a702b94f0c91d234d888750f260a022f49e77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197107
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Joshua Litt <joshualitt@google.com>
This commit is contained in:
Joshua Litt 2021-04-29 17:19:05 +00:00 committed by commit-bot@chromium.org
parent a89fccb482
commit e6a0238898
2 changed files with 23 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
tests/web/internal/deferred/load_in_correct_order_test.dart
View file

@ -76,9 +76,22 @@ self.content = {};
self.currentLoadLibraryCall = 0;
self.filesPerLoadLibraryCall = null;
function equal(a, b) {
return a.length === b.length &&
a.every(function (value, index) {
return value === b[index];
});
}
self.initFilesPerLoadLibraryCall = function() {
// We assume we load d1, then d2, then d3.
var loadOrder = ['d1', 'd2', 'd3'];
// We assume we load d1, then d2, then d3. However, we may have integer load
// ids instead of the full load id.
var loadOrder = Object.keys(init.deferredLibraryParts);
var expectedLoadOrder = equal(loadOrder, ['d1', 'd2', 'd3']) ||
equal(loadOrder, ['1', '2', '3']);
if (!expectedLoadOrder) {
throw 'Unexpected load order ' + loadOrder;
}
var uniques = {};
self.filesPerLoadLibraryCall = [];
for (var i = 0; i < loadOrder.length; i++) {

12
tools/bots/test_matrix.json
View file

@ -625,7 +625,8 @@
"dart2js-options": [
"--libraries-spec=sdk/lib/libraries.json",
"--platform-binaries=out/ReleaseX64/",
"--merge-fragments-threshold=3"
"--merge-fragments-threshold=3",
"--simple-load-ids"
]
}
},
@ -653,7 +654,8 @@
"dart2js-options": [
"--libraries-spec=sdk/lib/libraries.json",
"--platform-binaries=out/ReleaseX64/",
"--merge-fragments-threshold=3"
"--merge-fragments-threshold=3",
"--simple-load-ids"
]
}
},
@ -718,7 +720,8 @@
"dart2js-options": [
"--libraries-spec=sdk/lib/libraries.json",
"--platform-binaries=out/ReleaseX64/",
"--merge-fragments-threshold=3"
"--merge-fragments-threshold=3",
"--simple-load-ids"
]
}
},
@ -752,7 +755,8 @@
"dart2js-options": [
"--libraries-spec=sdk/lib/libraries.json",
"--platform-binaries=out/ReleaseX64/",
"--merge-fragments-threshold=3"
"--merge-fragments-threshold=3",
"--simple-load-ids"
]
}
},