From e610d803b17effbbeddca73f852a4c544305b6aa Mon Sep 17 00:00:00 2001 From: Alan Knight Date: Fri, 15 Jul 2016 15:00:15 -0700 Subject: [PATCH] Update test status for webgl extension tests, fix one typo in extension name BUG= Review URL: https://codereview.chromium.org/2152393002 . --- sdk/lib/web_gl/dart2js/web_gl_dart2js.dart | 2 +- tests/co19/co19-dart2js.status | 1 - tests/html/html.status | 6 ++++++ tools/dom/scripts/generator.py | 4 ++-- 4 files changed, 9 insertions(+), 4 deletions(-) diff --git a/sdk/lib/web_gl/dart2js/web_gl_dart2js.dart b/sdk/lib/web_gl/dart2js/web_gl_dart2js.dart index 645b1e242d4..3dd54a86420 100644 --- a/sdk/lib/web_gl/dart2js/web_gl_dart2js.dart +++ b/sdk/lib/web_gl/dart2js/web_gl_dart2js.dart @@ -847,7 +847,7 @@ class EXTsRgb extends Interceptor { @DocsEditable() @DomName('EXTBlendMinMax') @Experimental() // untriaged -@Native("EXTBlendMinMax,EXT_blend_min_max") +@Native("EXTBlendMinMax,EXT_blend_minmax") class ExtBlendMinMax extends Interceptor { // To suppress missing implicit constructor warnings. factory ExtBlendMinMax._() { throw new UnsupportedError("Not supported"); } diff --git a/tests/co19/co19-dart2js.status b/tests/co19/co19-dart2js.status index 6b245262a49..52ef7379113 100644 --- a/tests/co19/co19-dart2js.status +++ b/tests/co19/co19-dart2js.status @@ -1881,7 +1881,6 @@ LayoutTests/fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-t LayoutTests/fast/canvas/webgl/context-destroyed-crash_t01: RuntimeError # Please triage this failure LayoutTests/fast/canvas/webgl/context-lost-restored_t01: RuntimeError # Please triage this failure LayoutTests/fast/canvas/webgl/context-lost_t01: RuntimeError # Please triage this failure -LayoutTests/fast/canvas/webgl/oes-vertex-array-object_t01: RuntimeError # Please triage this failure LayoutTests/fast/canvas/webgl/renderer-and-vendor-strings_t01: RuntimeError # Please triage this failure LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view_t01: Skip # Times out. LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image_t01: RuntimeError # Please triage this failure diff --git a/tests/html/html.status b/tests/html/html.status index 590fd9d6303..da27d619585 100644 --- a/tests/html/html.status +++ b/tests/html/html.status @@ -347,6 +347,12 @@ request_animation_frame_test: Skip # Async test hangs. [ $runtime == drt ] webgl_extensions_test: Skip # webgl does not work properly on DRT, which is 'headless'. +[ $runtime == dartium && ($system == windows || $system == linux) ] +webgl_extensions_test: Fail # WebGL extension tests fail on Dartium without graphics. This is dependent on our bot configuration. + +[ $runtime == chrome && ($system == windows || $system == linux) ] +webgl_extensions_test: Fail # WebGL extension tests fail without graphics. This is dependent on our bot configuration. + [ $compiler == dart2js && $csp && ($runtime == drt || $runtime == safari || $runtime == ff || $runtime == chrome || $runtime == chromeOnAndroid) ] # Note: these tests are all injecting scripts by design. This is not allowed under CSP. # TODO(sra): Change these tests to use a same-origin JavaScript script file. diff --git a/tools/dom/scripts/generator.py b/tools/dom/scripts/generator.py index fc74f05d384..9e15a96b391 100644 --- a/tools/dom/scripts/generator.py +++ b/tools/dom/scripts/generator.py @@ -332,7 +332,7 @@ _dart2js_dom_custom_native_specs = monitored.Dict( 'ANGLEInstancedArrays': 'ANGLEInstancedArrays,ANGLE_instanced_arrays', 'EXTsRGB': 'EXTsRGB,EXT_sRGB', - 'EXTBlendMinMax': 'EXTBlendMinMax,EXT_blend_min_max', + 'EXTBlendMinMax': 'EXTBlendMinMax,EXT_blend_minmax', 'EXTFragDepth': 'EXTFragDepth,EXT_frag_depth', 'EXTShaderTextureLOD': 'EXTShaderTextureLOD,EXT_shader_texture_lod', 'EXTTextureFilterAnisotropic': @@ -731,7 +731,7 @@ class OperationInfo(object): # Events fired need use a JSFunction not a anonymous closure to # insure the event can really be removed. parameters.append('js.allowInterop(%s)' % p.name) -# These commented out cases don't actually generate any code. +# These commented out cases don't actually generate any code. # elif dart_js_interop and type_id == 'FontFaceSetForEachCallback': # forEach is supported in the DOM for FontFaceSet as it iterates # over the Javascript Object the callback parameters are also