languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 04:27:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused support for disabling error messages

Browse source 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1424793008 .
This commit is contained in:
Brian Wilkerson 2015-10-31 08:53:40 -07:00
parent dde638f7db
commit e37a7bddfc
2 changed files with 1 additions and 86 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

56
pkg/analyzer/lib/src/generated/error.dart
View file

@ -2475,62 +2475,6 @@ class CompileTimeErrorCode extends ErrorCode {
ErrorType get type => ErrorType.COMPILE_TIME_ERROR;
}
/**
* An error listener that can be enabled or disabled while executing a function.
*/
class DisablableErrorListener implements AnalysisErrorListener {
/**
* The listener to which errors will be reported if this listener is enabled.
*/
final AnalysisErrorListener baseListener;
/**
* A flag indicating whether this listener is currently enabled.
*/
bool enabled = true;
/**
* Initialize a newly created listener to report errors to the given
* [baseListener].
*/
DisablableErrorListener(this.baseListener);
/**
* Disable the processing of errors while evaluating the given [function].
* Return the value returned by the function.
*/
dynamic disableWhile(dynamic function()) {
bool wasEnabled = enabled;
try {
enabled = false;
return function();
} finally {
enabled = wasEnabled;
}
}
/**
* Disable the processing of errors while evaluating the given [function].
* Return the value returned by the function.
*/
dynamic enableWhile(dynamic function()) {
bool wasEnabled = enabled;
try {
enabled = true;
return function();
} finally {
enabled = wasEnabled;
}
}
@override
void onError(AnalysisError error) {
if (enabled) {
baseListener.onError(error);
}
}
}
/**
* An error code associated with an [AnalysisError].
*

31
pkg/analyzer/lib/src/generated/resolver.dart
View file

@ -9745,13 +9745,6 @@ class PartialResolverVisitor extends ResolverVisitor {
*/
final List<VariableElement> variablesAndFields = <VariableElement>[];
/**
* A flag indicating whether we should discard errors while resolving the
* initializer for variable declarations. We do this for top-level variables
* and fields because their initializer will be re-resolved at a later time.
*/
bool discardErrorsInInitializer = false;
/**
* Initialize a newly created visitor to resolve the nodes in an AST node.
*
@ -9775,8 +9768,7 @@ class PartialResolverVisitor extends ResolverVisitor {
InheritanceManager inheritanceManager,
StaticTypeAnalyzerFactory typeAnalyzerFactory})
: strongMode = definingLibrary.context.analysisOptions.strongMode,
super(definingLibrary, source, typeProvider,
new DisablableErrorListener(errorListener));
super(definingLibrary, source, typeProvider, errorListener);
@override
Object visitBlockFunctionBody(BlockFunctionBody node) {
@ -9798,26 +9790,12 @@ class PartialResolverVisitor extends ResolverVisitor {
Object visitFieldDeclaration(FieldDeclaration node) {
if (strongMode && node.isStatic) {
_addVariables(node.fields.variables);
bool wasDiscarding = discardErrorsInInitializer;
discardErrorsInInitializer = true;
try {
return super.visitFieldDeclaration(node);
} finally {
discardErrorsInInitializer = wasDiscarding;
}
}
return super.visitFieldDeclaration(node);
}
@override
Object visitNode(AstNode node) {
if (discardErrorsInInitializer) {
AstNode parent = node.parent;
if (parent is VariableDeclaration && parent.initializer == node) {
DisablableErrorListener listener = errorListener;
return listener.disableWhile(() => super.visitNode(node));
}
}
return super.visitNode(node);
}
@ -9825,13 +9803,6 @@ class PartialResolverVisitor extends ResolverVisitor {
Object visitTopLevelVariableDeclaration(TopLevelVariableDeclaration node) {
if (strongMode) {
_addVariables(node.variables.variables);
bool wasDiscarding = discardErrorsInInitializer;
discardErrorsInInitializer = true;
try {
return super.visitTopLevelVariableDeclaration(node);
} finally {
discardErrorsInInitializer = wasDiscarding;
}
}
return super.visitTopLevelVariableDeclaration(node);
}