From e349b3faef43300427454b0c1419ce837bc7cbe4 Mon Sep 17 00:00:00 2001 From: Brian Wilkerson Date: Tue, 13 Feb 2024 17:11:29 +0000 Subject: [PATCH] Address a review comment that keeps getting missed Change-Id: I74b0b77da6524300ee3cd4c6a32ce0b225391eab Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352048 Auto-Submit: Brian Wilkerson Reviewed-by: Samuel Rawlins Commit-Queue: Samuel Rawlins --- .../src/services/completion/dart/in_scope_completion_pass.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart b/pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart index afae4b90927..357b27fbc99 100644 --- a/pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart +++ b/pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart @@ -2519,7 +2519,6 @@ class InScopeCompletionPass extends SimpleAstVisitor { /// beginning of a redirecting constructor invocation. void _forRedirectingConstructorInvocation( ConstructorDeclaration constructor) { - var constructorName = constructor.name?.lexeme; var container = constructor.parent; var thisType = switch (container) { ClassDeclaration() => container.declaredElement?.thisType, @@ -2528,6 +2527,7 @@ class InScopeCompletionPass extends SimpleAstVisitor { _ => null, }; if (thisType != null) { + var constructorName = constructor.name?.lexeme; declarationHelper(mustBeConstant: constructor.constKeyword != null) .addConstructorNamesForType(type: thisType, exclude: constructorName); }