languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-02 23:49:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

bulk fix for prefer_final_fields

Browse source 
Change-Id: Iabfb6aae5186171f4143d23aeb18a124ceab4a0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
This commit is contained in:
pq 2020-08-10 15:10:41 +00:00 committed by commit-bot@chromium.org
parent 9d279d41e3
commit e2a67723ca
3 changed files with 43 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/analysis_server/lib/src/services/correction/bulk_fix_processor.dart
View file

@ -15,6 +15,7 @@ import 'package:analysis_server/src/services/correction/dart/convert_documentati
import 'package:analysis_server/src/services/correction/dart/convert_quotes.dart';
import 'package:analysis_server/src/services/correction/dart/convert_to_contains.dart';
import 'package:analysis_server/src/services/correction/dart/create_method.dart';
import 'package:analysis_server/src/services/correction/dart/make_final.dart';
import 'package:analysis_server/src/services/correction/dart/remove_argument.dart';
import 'package:analysis_server/src/services/correction/dart/remove_await.dart';
import 'package:analysis_server/src/services/correction/dart/remove_const.dart';
@ -78,6 +79,7 @@ class BulkFixProcessor {
LintNames.prefer_contains: ConvertToContains.newInstance,
LintNames.prefer_equal_for_default_values:
ReplaceColonWithEquals.newInstance,
LintNames.prefer_final_fields: MakeFinal.newInstance,
LintNames.prefer_if_elements_to_conditional_expressions:
ConvertConditionalExpressionToIfElement.newInstance,
LintNames.prefer_is_empty: ReplaceWithIsEmpty.newInstance,

39
pkg/analysis_server/test/src/services/correction/fix/bulk/make_final_test.dart Normal file
View file

@ -0,0 +1,39 @@
// Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
import 'package:analysis_server/src/services/linter/lint_names.dart';
import 'package:test_reflective_loader/test_reflective_loader.dart';
import 'bulk_fix_processor.dart';
void main() {
defineReflectiveSuite(() {
defineReflectiveTests(PreferFinalFieldsTest);
});
}
@reflectiveTest
class PreferFinalFieldsTest extends BulkFixProcessorTest {
@override
String get lintCode => LintNames.prefer_final_fields;
Future<void> test_singleFile() async {
await resolveTestUnit('''
class C {
int _f = 2;
var _f2 = 2;
int get g => _f;
int get g2 => _f2;
}
''');
await assertHasFix('''
class C {
final int _f = 2;
final _f2 = 2;
int get g => _f;
int get g2 => _f2;
}
''');
}
}

2
pkg/analysis_server/test/src/services/correction/fix/bulk/test_all.dart
View file

@ -13,6 +13,7 @@ import 'convert_to_single_quoted_strings_test.dart'
as convert_to_single_quoted_strings;
import 'convert_to_spread_test.dart' as convert_to_spread;
import 'create_method_test.dart' as create_method;
import 'make_final_test.dart' as make_final;
import 'remove_argument_test.dart' as remove_argument;
import 'remove_await_test.dart' as remove_await;
import 'remove_duplicate_case_test.dart' as remove_duplicate_case;
@ -47,6 +48,7 @@ void main() {
convert_to_single_quoted_strings.main();
convert_to_spread.main();
create_method.main();
make_final.main();
remove_argument.main();
remove_await.main();
remove_duplicate_case.main();