languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 11:18:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix corelib_2/iterable_to_set_test to reflect strong mode runtime checks

Browse source 
`Set<dynamic>` should not be a subtype of `Set<int>` in strong mode.

R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2993743002 .
This commit is contained in:
Jennifer Messerly 2017-08-04 17:06:10 -07:00
parent f5d2688206
commit e1f4de9a6e
2 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
tests/corelib_2/corelib_2.status
View file

@ -165,6 +165,7 @@ typed_data_with_limited_ints_test: Skip # dart2js and dartdevc don't know about
[ $compiler == dart2js && $runtime != none ]
nan_infinity_test/01: RuntimeError
iterable_to_set_test: RuntimeError # is-checks do not implement strong mode type system
[ $compiler == dart2js && $runtime == drt && $csp && $minified ]
core_runtime_types_test: Pass, Fail # Issue 27913
@ -172,7 +173,7 @@ core_runtime_types_test: Pass, Fail # Issue 27913
[ $compiler != dartdevc ]
error_stack_trace_test/static: MissingCompileTimeError
[ $compiler == dartdevc ]
[ $compiler == dartdevc && $runtime != none ]
error_stack_trace_test/nullThrown: RuntimeError # .stackTrace not present for exception caught from 'throw null;'
list_fill_range_test: RuntimeError # Issue 29921
list_insert_test: RuntimeError # Issue 29921
@ -296,6 +297,7 @@ big_integer_parsed_mul_div_vm_test: Pass, Timeout # --no_intrinsify
[ $compiler == none && ($runtime == vm || $runtime == flutter)]
string_trimlr_test/02: RuntimeError # Issue 29060
iterable_to_set_test: RuntimeError # is-checks do not implement strong mode type system
[ $compiler == precompiler || $compiler == app_jit ]
string_trimlr_test/02: RuntimeError # Issue 29060
@ -343,6 +345,7 @@ from_environment_const_type_undefined_test/12: MissingCompileTimeError
from_environment_const_type_undefined_test/13: MissingCompileTimeError
from_environment_const_type_undefined_test/14: MissingCompileTimeError
from_environment_const_type_undefined_test/16: MissingCompileTimeError
iterable_to_set_test: RuntimeError # is-checks do not implement strong mode type system
[ $compiler == dart2js && $runtime == safari ]
regexp/no-extensions_test: RuntimeError

11
tests/corelib_2/iterable_to_set_test.dart
View file

@ -45,9 +45,10 @@ main() {
Expect.isFalse(setStrCopy is Set<int>);
Expect.isFalse(identical(setStrCopy, set2));
setCopy = set3.toSet();
Expect.setEquals(set3, setCopy);
Expect.isTrue(setCopy is Set<String>);
Expect.isTrue(setCopy is Set<int>);
Expect.isFalse(identical(setCopy, set3));
var set3Copy = set3.toSet();
Expect.setEquals(set3, set3Copy);
Expect.isTrue(set3Copy is Set);
Expect.isFalse(set3Copy is Set<String>);
Expect.isFalse(set3Copy is Set<int>);
Expect.isFalse(identical(set3Copy, set3));
}