languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-15 21:10:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Eliminate dynamic call of .createElement in html_dart2js.

Browse source 
Change-Id: I76ab0063eee4213f20483172c16f86e651536945
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256740
Reviewed-by: Lasse Nielsen <lrn@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
This commit is contained in:
Kallen Tu 2022-08-30 15:48:40 +00:00 committed by Commit Bot
parent 8e4dc26b2a
commit e0884c91f1
3 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkg/compiler/test/analyses/api_allowed.json
View file

@ -33,8 +33,7 @@
"Dynamic invocation of 'toLowerCase'.": 1,
"Dynamic invocation of 'attached'.": 1,
"Dynamic invocation of 'detached'.": 1,
"Dynamic invocation of 'attributeChanged'.": 1,
"Dynamic invocation of 'createElement'.": 1
"Dynamic invocation of 'attributeChanged'.": 1
},
"org-dartlang-sdk:///lib/html/html_common/conversions.dart": {
"Dynamic invocation of '[]='.": 1

3
sdk/lib/html/dart2js/html_dart2js.dart
View file

@ -40207,7 +40207,8 @@ void _checkExtendsNativeClassOrTemplate(
}
}
Function _registerCustomElement(context, document, String tag, [Map? options]) {
Function _registerCustomElement(context, Document document, String tag,
[Map? options]) {
// Function follows the same pattern as the following JavaScript code for
// registering a custom element.
//

3
tools/dom/src/dart2js_CustomElementSupport.dart
View file

@ -66,7 +66,8 @@ void _checkExtendsNativeClassOrTemplate(
}
}
Function _registerCustomElement(context, document, String tag, [Map? options]) {
Function _registerCustomElement(context, Document document, String tag,
[Map? options]) {
// Function follows the same pattern as the following JavaScript code for
// registering a custom element.
//