From df5e7aac17365b0bcca8fe6d4fb6c4838e2d67ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9gis=20Crelier?= Date: Mon, 17 Jun 2019 21:24:21 +0000 Subject: [PATCH] [vm/bytecode] Intermediate out.dill not needed anymore when testing bytecode. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I213e023b8b6ba15fcd723c0a49a0b5d7ec471e15 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106420 Reviewed-by: Alexander Markov Commit-Queue: Régis Crelier --- pkg/test_runner/lib/src/compiler_configuration.dart | 4 +--- pkg/vm/bin/kernel_service.dart | 5 +++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/pkg/test_runner/lib/src/compiler_configuration.dart b/pkg/test_runner/lib/src/compiler_configuration.dart index eb8fb4e2b6d..8a5ee3788e2 100644 --- a/pkg/test_runner/lib/src/compiler_configuration.dart +++ b/pkg/test_runner/lib/src/compiler_configuration.dart @@ -78,6 +78,7 @@ abstract class CompilerConfiguration { previewDart2: false); case Compiler.dartk: + case Compiler.dartkb: if (configuration.architecture == Architecture.simdbc64 || configuration.architecture == Architecture.simarm || configuration.architecture == Architecture.simarm64 || @@ -86,9 +87,6 @@ abstract class CompilerConfiguration { } return NoneCompilerConfiguration(configuration); - case Compiler.dartkb: - return VMKernelCompilerConfiguration(configuration); - case Compiler.dartkp: return PrecompilerCompilerConfiguration(configuration); diff --git a/pkg/vm/bin/kernel_service.dart b/pkg/vm/bin/kernel_service.dart index be1e4ee6cc9..4685f798c47 100644 --- a/pkg/vm/bin/kernel_service.dart +++ b/pkg/vm/bin/kernel_service.dart @@ -145,11 +145,12 @@ abstract class Compiler { if (options.bytecode && errors.isEmpty) { await runWithFrontEndCompilerContext(script, options, component, () { - // TODO(alexmarkov): pass environment defines // TODO(alexmarkov): disable source positions and local variables // in VM PRODUCT mode. generateBytecode(component, - emitSourcePositions: true, emitLocalVarInfo: true); + environmentDefines: options.environmentDefines, + emitSourcePositions: true, + emitLocalVarInfo: true); }); }