languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 02:17:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

[data driven fix] Add more information to matcher for property

Browse source 
accessors.

Fixes https://github.com/dart-lang/sdk/issues/54730

Change-Id: Ia8bf540b157594a3400bb5c567b5a4c4886520ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/350400
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
This commit is contained in:
Keerti Parthasarathy 2024-02-05 23:32:50 +00:00 committed by Commit Queue
parent 00be96e511
commit df52948967
3 changed files with 19 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
pkg/analysis_server/lib/src/services/correction/fix/data_driven/element_matcher.dart
View file

@ -6,7 +6,12 @@ import 'package:analysis_server/src/services/correction/fix/data_driven/element_
import 'package:analysis_server/src/services/correction/fix/data_driven/element_kind.dart';
import 'package:analyzer/dart/ast/token.dart';
import 'package:analyzer/dart/element/element.dart'
show ExtensionElement, InterfaceElement, PrefixElement;
show
CompilationUnitElement,
ExtensionElement,
InterfaceElement,
PrefixElement,
PropertyAccessorElement;
import 'package:analyzer/dart/element/type.dart';
import 'package:analyzer/src/dart/ast/ast.dart';
@ -528,6 +533,18 @@ class _MatcherBuilder {
if (node.staticType is InvalidType) {
_addMatcher(components: [node.name], kinds: [], node: node);
} else {
var staticElement = node.staticElement;
// Add enclosing element to the matcher for non top level property
// accessors when possible.
if (staticElement is PropertyAccessorElement) {
var enclosingElement = staticElement.enclosingElement;
if (enclosingElement is! CompilationUnitElement) {
_addMatcher(
components: [node.name, enclosingElement.displayName],
kinds: []);
return;
}
}
_addMatcher(components: [node.name], kinds: []);
}
}

2
pkg/analysis_server/test/src/services/correction/fix/data_driven/element_matcher_test.dart
View file

@ -112,7 +112,7 @@ class C {
}
}
''');
_assertMatcher('g;', expectedComponents: ['g']);
_assertMatcher('g;', expectedComponents: ['g', 'C']);
}
Future<void> test_getter_withoutTarget_unresolved() async {

1
pkg/analysis_server/test/src/services/correction/fix/data_driven/flutter_use_case_test.dart
View file

@ -1875,7 +1875,6 @@ void f(TextTheme theme) {
''');
}
@FailingTest(issue: 'https://github.com/Dart-Code/Dart-Code/issues/4857')
Future<void> test_material_TextTheme_title_renamed() async {
setPackageContent('''
class Text() {