From de44a23dd1e045376f40e5d41f1579070e1bb6e4 Mon Sep 17 00:00:00 2001 From: Nicholas Shahan Date: Tue, 7 Mar 2023 02:09:16 +0000 Subject: [PATCH] [test_runner] Cleanup unused compiler names "dartdevc" and "dartdevk" have been replaced with "ddc". Change-Id: I823bc029a0bbe1295fd731efcc32961e61c6c175 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/282485 Commit-Queue: Nicholas Shahan Reviewed-by: Alexander Thomas --- pkg/dev_compiler/lib/ddc.dart | 7 ++- pkg/expect/lib/config.dart | 5 +- pkg/smith/lib/configuration.dart | 10 --- pkg/smith/test/configuration_test.dart | 5 +- pkg/smith/test/test_matrix_test.dart | 6 +- .../lib/src/build_configurations.dart | 4 +- pkg/test_runner/lib/src/command.dart | 4 +- pkg/test_runner/lib/src/command_output.dart | 2 - .../lib/src/compiler_configuration.dart | 5 +- pkg/test_runner/lib/src/configuration.dart | 2 - pkg/test_runner/lib/src/options.dart | 2 - pkg/test_runner/lib/src/process_queue.dart | 2 - pkg/test_runner/lib/src/test_suite.dart | 4 -- tests/co19/co19-dartdevc.status | 2 +- tests/co19_2/co19_2-dartdevc.status | 2 +- tests/corelib/corelib.status | 20 +++--- tests/corelib_2/corelib_2.status | 20 +++--- .../dartdevc_native_dartdevc.status | 2 +- tests/language/language_dartdevc.status | 4 +- tests/language_2/language_2_dartdevc.status | 10 +-- tests/lib/lib.status | 2 +- tests/lib/lib_dartdevc.status | 61 ++++++++++--------- tests/lib_2/lib_2.status | 2 +- tests/lib_2/lib_2_dartdevc.status | 23 ++++--- tests/standalone/standalone.status | 2 +- tests/standalone_2/standalone_2.status | 2 +- 26 files changed, 93 insertions(+), 117 deletions(-) diff --git a/pkg/dev_compiler/lib/ddc.dart b/pkg/dev_compiler/lib/ddc.dart index 5b5a01a7d8d..c0e9d0f35dc 100755 --- a/pkg/dev_compiler/lib/ddc.dart +++ b/pkg/dev_compiler/lib/ddc.dart @@ -2,8 +2,9 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. -/// Command line entry point for Dart Development Compiler (dartdevc), used to -/// compile a collection of dart libraries into a single JS module +/// Command line entry point for Dart Development Compiler (known as ddc, +/// dartdevc, dev compiler), used to compile a collection of dart libraries into +/// a single JS module. import 'dart:async'; import 'dart:convert'; @@ -90,7 +91,7 @@ class _BatchHelper { /// on the terminal (I think `set DDC_LEAK_TEST="true"` on Windows). /// Then one could run test.py, say /// ``` - /// python3 tools/test.py -t10000 -c dartdevk --nnbd weak -m release -r none \ + /// python3 tools/test.py -t10000 -c ddc --nnbd weak -m release -r none \ /// --enable-asserts --no-use-sdk -j 1 co19/LanguageFeatures/ /// ``` /// and attach the leak tester via diff --git a/pkg/expect/lib/config.dart b/pkg/expect/lib/config.dart index f54fb8cfd7c..cb6a3283823 100644 --- a/pkg/expect/lib/config.dart +++ b/pkg/expect/lib/config.dart @@ -24,10 +24,7 @@ bool get isDart2jsConfiguration => _configuration.compiler == Compiler.dart2js; bool get isDart2WasmConfiguration => _configuration.compiler == Compiler.dart2wasm; -bool get isDdcConfiguration => - _configuration.compiler == Compiler.dartdevk || - _configuration.compiler == Compiler.dartdevc || - _configuration.compiler == Compiler.ddc; +bool get isDdcConfiguration => _configuration.compiler == Compiler.ddc; bool get isVmJitConfiguration => _configuration.compiler == Compiler.dartk; diff --git a/pkg/smith/lib/configuration.dart b/pkg/smith/lib/configuration.dart index 24ee89b7def..0eb2f22d5b4 100644 --- a/pkg/smith/lib/configuration.dart +++ b/pkg/smith/lib/configuration.dart @@ -764,8 +764,6 @@ class Compiler extends NamedEnum { static const dart2js = Compiler._('dart2js'); static const dart2analyzer = Compiler._('dart2analyzer'); static const dart2wasm = Compiler._('dart2wasm'); - static const dartdevc = Compiler._('dartdevc'); - static const dartdevk = Compiler._('dartdevk'); static const ddc = Compiler._('ddc'); static const appJitk = Compiler._('app_jitk'); static const dartk = Compiler._('dartk'); @@ -779,8 +777,6 @@ class Compiler extends NamedEnum { dart2js, dart2analyzer, dart2wasm, - dartdevc, - dartdevk, ddc, appJitk, dartk, @@ -820,8 +816,6 @@ class Compiler extends NamedEnum { Runtime.chromeOnAndroid, ]; - case Compiler.dartdevc: - case Compiler.dartdevk: case Compiler.ddc: return const [ Runtime.none, @@ -862,8 +856,6 @@ class Compiler extends NamedEnum { return Runtime.d8; case Compiler.dart2wasm: return Runtime.d8; - case Compiler.dartdevc: - case Compiler.dartdevk: case Compiler.ddc: return Runtime.chrome; case Compiler.dart2analyzer: @@ -886,8 +878,6 @@ class Compiler extends NamedEnum { case Compiler.dart2analyzer: case Compiler.dart2js: case Compiler.dart2wasm: - case Compiler.dartdevc: - case Compiler.dartdevk: case Compiler.ddc: case Compiler.fasta: return Mode.release; diff --git a/pkg/smith/test/configuration_test.dart b/pkg/smith/test/configuration_test.dart index 4ee1c67839b..b34c07475c0 100644 --- a/pkg/smith/test/configuration_test.dart +++ b/pkg/smith/test/configuration_test.dart @@ -183,12 +183,11 @@ void main() { }); test("runtime defaults to compiler's default runtime", () { - expect(Configuration.parse("dartdevc", {}).runtime, - equals(Runtime.chrome)); + expect(Configuration.parse("ddc", {}).runtime, equals(Runtime.chrome)); }); test("runtime defaults to compiler's default runtime from option", () { - expect(Configuration.parse("wat", {"compiler": "dartdevc"}).runtime, + expect(Configuration.parse("wat", {"compiler": "ddc"}).runtime, equals(Runtime.chrome)); }); diff --git a/pkg/smith/test/test_matrix_test.dart b/pkg/smith/test/test_matrix_test.dart index 9787567f562..7724fa0c0a5 100644 --- a/pkg/smith/test/test_matrix_test.dart +++ b/pkg/smith/test/test_matrix_test.dart @@ -13,7 +13,7 @@ void main() { "x64-dart2js-debug-vm-linux": { "options": {"enable-asserts": true}, }, - "x64-dartdevc-vm-linux": { + "x64-ddc-vm-linux": { "options": { "mode": "release", "enable-asserts": true @@ -30,8 +30,8 @@ void main() { enableAsserts: true))); expect( testMatrix.configurations[1], - equals(Configuration("x64-dartdevc-vm-linux", Architecture.x64, - Compiler.dartdevc, Mode.release, Runtime.vm, System.linux, + equals(Configuration("x64-ddc-vm-linux", Architecture.x64, + Compiler.ddc, Mode.release, Runtime.vm, System.linux, enableAsserts: true))); }); diff --git a/pkg/test_runner/lib/src/build_configurations.dart b/pkg/test_runner/lib/src/build_configurations.dart index adbe31af53f..b3f1b5aaa48 100644 --- a/pkg/test_runner/lib/src/build_configurations.dart +++ b/pkg/test_runner/lib/src/build_configurations.dart @@ -83,7 +83,6 @@ List _selectBuildTargets(Configuration inner) { Compiler.dartkp: ['runtime', 'dart_precompiled_runtime'], Compiler.appJitk: ['runtime'], Compiler.fasta: ['create_sdk', 'dartdevc_test', 'kernel_platform_files'], - Compiler.dartdevk: ['dartdevc_test'], Compiler.ddc: ['dartdevc_test'], Compiler.dart2js: ['create_sdk'], Compiler.dart2analyzer: ['create_sdk', 'utils/dartanalyzer'], @@ -110,8 +109,7 @@ List _selectBuildTargets(Configuration inner) { result.add('analyze_snapshot'); } - if ((compiler == Compiler.dartdevk || compiler == Compiler.ddc) && - !inner.useSdk) { + if (compiler == Compiler.ddc && !inner.useSdk) { result ..remove('dartdevc_test') ..add('dartdevc_test_local'); diff --git a/pkg/test_runner/lib/src/command.dart b/pkg/test_runner/lib/src/command.dart index 29106a0fecb..b1317a42418 100644 --- a/pkg/test_runner/lib/src/command.dart +++ b/pkg/test_runner/lib/src/command.dart @@ -327,8 +327,8 @@ class DevCompilerCompilationCommand extends CompilationCommand { required bool alwaysCompile, String? workingDirectory, int index = 0}) - : super("dartdevc", outputFile, bootstrapDependencies, executable, - arguments, environmentOverrides, + : super("ddc", outputFile, bootstrapDependencies, executable, arguments, + environmentOverrides, alwaysCompile: alwaysCompile, workingDirectory: workingDirectory, index: index); diff --git a/pkg/test_runner/lib/src/command_output.dart b/pkg/test_runner/lib/src/command_output.dart index a114ca8d545..5a47b19621b 100644 --- a/pkg/test_runner/lib/src/command_output.dart +++ b/pkg/test_runner/lib/src/command_output.dart @@ -1638,8 +1638,6 @@ mixin _StaticErrorOutput on CommandOutput { Compiler.dart2analyzer: ErrorSource.analyzer, Compiler.dart2js: ErrorSource.web, Compiler.dart2wasm: ErrorSource.web, - Compiler.dartdevc: ErrorSource.web, - Compiler.dartdevk: ErrorSource.web, Compiler.ddc: ErrorSource.web, Compiler.fasta: ErrorSource.cfe }[testCase.configuration.compiler]!; diff --git a/pkg/test_runner/lib/src/compiler_configuration.dart b/pkg/test_runner/lib/src/compiler_configuration.dart index 28cd729d50d..15e246d766d 100644 --- a/pkg/test_runner/lib/src/compiler_configuration.dart +++ b/pkg/test_runner/lib/src/compiler_configuration.dart @@ -86,8 +86,6 @@ abstract class CompilerConfiguration { case Compiler.dart2wasm: return Dart2WasmCompilerConfiguration(configuration); - case Compiler.dartdevc: - case Compiler.dartdevk: case Compiler.ddc: return DevCompilerConfiguration(configuration); @@ -585,8 +583,7 @@ class Dart2WasmCompilerConfiguration extends CompilerConfiguration { } } -/// Configuration for "dartdevc", "dartdevk", and "ddc". -// TODO(nshahan): Cleanup mulitple aliases for the compiler. +/// Configuration for "ddc". class DevCompilerConfiguration extends CompilerConfiguration { DevCompilerConfiguration(TestConfiguration configuration) : super._subclass(configuration); diff --git a/pkg/test_runner/lib/src/configuration.dart b/pkg/test_runner/lib/src/configuration.dart index dceeec87396..b246d500191 100644 --- a/pkg/test_runner/lib/src/configuration.dart +++ b/pkg/test_runner/lib/src/configuration.dart @@ -195,8 +195,6 @@ class TestConfiguration { bool get usesFasta { var fastaCompilers = const [ Compiler.appJitk, - Compiler.dartdevc, - Compiler.dartdevk, Compiler.ddc, Compiler.dartk, Compiler.dartkp, diff --git a/pkg/test_runner/lib/src/options.dart b/pkg/test_runner/lib/src/options.dart index 6eb254281f4..9a4c0b184f4 100644 --- a/pkg/test_runner/lib/src/options.dart +++ b/pkg/test_runner/lib/src/options.dart @@ -87,8 +87,6 @@ dart2js: Compile to JavaScript using dart2js. dart2analyzer: Perform static analysis on Dart code using the analyzer. compare_analyzer_cfe: Compare analyzer and common front end representations. ddc: Compile to JavaScript using dartdevc. -dartdevc: Compile to JavaScript using dartdevc (same as ddc). -dartdevk: Compile to JavaScript using dartdevc (same as ddc). app_jitk: Compile the Dart code into Kernel and then into an app snapshot. dartk: Compile the Dart code into Kernel before running test. diff --git a/pkg/test_runner/lib/src/process_queue.dart b/pkg/test_runner/lib/src/process_queue.dart index ef11326df93..0ab2ab9c55c 100644 --- a/pkg/test_runner/lib/src/process_queue.dart +++ b/pkg/test_runner/lib/src/process_queue.dart @@ -569,8 +569,6 @@ class CommandExecutorImpl implements CommandExecutor { .runCommand(command.displayName, command, timeout, command.arguments); } else if (command is CompilationCommand && (command.displayName == 'dart2js' || - command.displayName == 'dartdevc' || - command.displayName == 'dartdevk' || command.displayName == 'ddc' || command.displayName == 'fasta') && globalConfiguration.batch) { diff --git a/pkg/test_runner/lib/src/test_suite.dart b/pkg/test_runner/lib/src/test_suite.dart index 3cadbf03465..244a9161cb5 100644 --- a/pkg/test_runner/lib/src/test_suite.dart +++ b/pkg/test_runner/lib/src/test_suite.dart @@ -175,8 +175,6 @@ abstract class TestSuite { if (testFile.isWebStaticErrorTest && const { Compiler.dart2js, - Compiler.dartdevc, - Compiler.dartdevk, Compiler.ddc, }.contains(configuration.compiler)) { return true; @@ -967,8 +965,6 @@ class StandardTestSuite extends TestSuite { const supportedCompilers = { Compiler.dart2js, Compiler.dart2wasm, - Compiler.dartdevc, - Compiler.dartdevk, Compiler.ddc }; assert(supportedCompilers.contains(configuration.compiler)); diff --git a/tests/co19/co19-dartdevc.status b/tests/co19/co19-dartdevc.status index bc638f7cace..66b4c1499ba 100644 --- a/tests/co19/co19-dartdevc.status +++ b/tests/co19/co19-dartdevc.status @@ -2,7 +2,7 @@ # for details. All rights reserved. Use of this source code is governed by a # BSD-style license that can be found in the LICENSE file. -[ $compiler == dartdevc || $compiler == dartdevk || $compiler == ddc ] +[ $compiler == ddc ] Language/Expressions/Constants/integer_size_t03: SkipByDesign # uses integer literal not representable as JavaScript number Language/Expressions/Constants/integer_size_t04: SkipByDesign # uses integer literal not representable as JavaScript number Language/Expressions/Constants/literal_number_t01: SkipByDesign # uses integer literal not representable as JavaScript number diff --git a/tests/co19_2/co19_2-dartdevc.status b/tests/co19_2/co19_2-dartdevc.status index 3358f9ef0e2..61809eb5bf6 100644 --- a/tests/co19_2/co19_2-dartdevc.status +++ b/tests/co19_2/co19_2-dartdevc.status @@ -2,7 +2,7 @@ # for details. All rights reserved. Use of this source code is governed by a # BSD-style license that can be found in the LICENSE file. -[ $compiler == dartdevc || $compiler == dartdevk || $compiler == ddc ] +[ $compiler == ddc ] Language/Classes/Constructors/Generative_Constructors/formal_parameter_t07: SkipSlow Language/Classes/Constructors/Generative_Constructors/fresh_instance_t01: SkipSlow Language/Classes/Constructors/Generative_Constructors/implicit_superinitializer_t01: SkipSlow diff --git a/tests/corelib/corelib.status b/tests/corelib/corelib.status index 17c47f566f0..cf47a9858e3 100644 --- a/tests/corelib/corelib.status +++ b/tests/corelib/corelib.status @@ -10,6 +10,14 @@ bigint_parse_radix_test: Slow, Pass # --no_intrinsify bigint_test/03: SkipSlow # --no_intrinsify bigint_test/15: SkipSlow # --no_intrinsify +[ $compiler == ddc ] +bigint_test/03: SkipSlow # modPow is very slow +bigint_test/15: SkipSlow # modPow is very slow +list_concurrent_modify_self_test: SkipSlow # missing check causes list to grow to whole heap +regexp/lookbehind_test/01: Skip # Flaky in uncatchable way. Issue 36280 +uri_parse_test: Slow, Pass +uri_test: Slow, Pass + [ $mode == debug ] regexp/pcre_test: Slow, Pass # Issue 22008 @@ -26,7 +34,7 @@ dynamic_nosuchmethod_test: SkipByDesign # Expects names in NSM error_stack_trace1_test: SkipByDesign # Expects unobfuscated stack trace type_tostring_test: SkipByDesign # Expects names in Type.toString() -[ $compiler != dart2analyzer && $compiler != dart2js && $compiler != dartdevc && $compiler != dartdevk && $compiler != ddc ] +[ $compiler != dart2analyzer && $compiler != dart2js && $compiler != ddc ] bigint_js_test: SkipByDesign # JavaScript-specific test [ $compiler == dart2js && $runtime != none ] @@ -42,7 +50,7 @@ regexp/unicode-regexp-restricted-syntax_test: Skip # evades flake detection http [ $runtime != dart_precompiled && $runtime != vm ] reg_exp_receive_port_test: SkipByDesign # uses SendPort/ReceivePort -[ $runtime != none && ($compiler == dart2js || $compiler == dartdevc || $compiler == dartdevk || $compiler == ddc) ] +[ $runtime != none && ($compiler == dart2js || $compiler == ddc) ] int_parse_with_limited_ints_test: SkipByDesign # Requires fixed-size int64 support. integer_arith_vm_test: SkipByDesign # Is a VM optimization test that requires int64 support. iterable_return_type_int64_test: SkipByDesign # Requires int64 support. @@ -52,14 +60,6 @@ typed_data_with_limited_ints_test: SkipByDesign # Requires fixed-size int64 supp bigint_parse_radix_test: Skip # Issue 31659 bigint_test: Skip # Issue 31659 -[ $compiler == dartdevc || $compiler == dartdevk || $compiler == ddc ] -bigint_test/03: SkipSlow # modPow is very slow -bigint_test/15: SkipSlow # modPow is very slow -list_concurrent_modify_self_test: SkipSlow # missing check causes list to grow to whole heap -regexp/lookbehind_test/01: Skip # Flaky in uncatchable way. Issue 36280 -uri_parse_test: Slow, Pass -uri_test: Slow, Pass - [ $runtime == dart_precompiled || $runtime == vm ] regexp/global_test: Skip # Issue 21709 regexp/pcre_test: Slow, Pass diff --git a/tests/corelib_2/corelib_2.status b/tests/corelib_2/corelib_2.status index 0c8b7994e98..39fd807e5b8 100644 --- a/tests/corelib_2/corelib_2.status +++ b/tests/corelib_2/corelib_2.status @@ -10,6 +10,14 @@ bigint_parse_radix_test: Slow, Pass # --no_intrinsify bigint_test/03: SkipSlow # --no_intrinsify bigint_test/15: SkipSlow # --no_intrinsify +[ $compiler == ddc ] +bigint_test/03: SkipSlow # modPow is very slow +bigint_test/15: SkipSlow # modPow is very slow +list_concurrent_modify_self_test: SkipSlow # missing check causes list to grow to whole heap +regexp/lookbehind_test/01: Skip # Flaky in uncatchable way. Issue 36280 +uri_parse_test: Slow, Pass +uri_test: Slow, Pass + [ $mode == debug ] regexp/pcre_test: Slow, Pass # Issue 22008 @@ -29,7 +37,7 @@ dynamic_nosuchmethod_test: SkipByDesign # Expects names in NSM error_stack_trace1_test: SkipByDesign # Expects unobfuscated stack trace type_tostring_test: SkipByDesign # Expects names in Type.toString() -[ $compiler != dart2analyzer && $compiler != dart2js && $compiler != dartdevc && $compiler != dartdevk && $compiler != ddc ] +[ $compiler != dart2analyzer && $compiler != dart2js && $compiler != ddc ] bigint_js_test: SkipByDesign # JavaScript-specific test [ $compiler == dart2js && $runtime != none ] @@ -45,7 +53,7 @@ regexp/unicode-regexp-restricted-syntax_test: Skip # evades flake detection http [ $runtime != dart_precompiled && $runtime != vm ] reg_exp_receive_port_test: SkipByDesign # uses SendPort/ReceivePort -[ $runtime != none && ($compiler == dart2js || $compiler == dartdevc || $compiler == dartdevk || $compiler == ddc) ] +[ $runtime != none && ($compiler == dart2js || $compiler == ddc) ] int_parse_with_limited_ints_test: SkipByDesign # Requires fixed-size int64 support. integer_arith_vm_test: SkipByDesign # Is a VM optimization test that requires int64 support. iterable_return_type_int64_test: SkipByDesign # Requires int64 support. @@ -55,14 +63,6 @@ typed_data_with_limited_ints_test: SkipByDesign # Requires fixed-size int64 supp bigint_parse_radix_test: Skip # Issue 31659 bigint_test: Skip # Issue 31659 -[ $compiler == dartdevc || $compiler == dartdevk || $compiler == ddc ] -bigint_test/03: SkipSlow # modPow is very slow -bigint_test/15: SkipSlow # modPow is very slow -list_concurrent_modify_self_test: SkipSlow # missing check causes list to grow to whole heap -regexp/lookbehind_test/01: Skip # Flaky in uncatchable way. Issue 36280 -uri_parse_test: Slow, Pass -uri_test: Slow, Pass - [ $runtime == dart_precompiled || $runtime == vm ] regexp/global_test: Skip # Issue 21709 regexp/pcre_test: Slow, Pass diff --git a/tests/dartdevc_2/dartdevc_native_dartdevc.status b/tests/dartdevc_2/dartdevc_native_dartdevc.status index ab3a010713e..29bea2bba07 100644 --- a/tests/dartdevc_2/dartdevc_native_dartdevc.status +++ b/tests/dartdevc_2/dartdevc_native_dartdevc.status @@ -2,4 +2,4 @@ # for details. All rights reserved. Use of this source code is governed by a # BSD-style license that can be found in the LICENSE file. -# Sections in this file should contain "$compiler == dartdevc", dartdevk or ddc. +# Sections in this file should contain "$compiler == ddc". diff --git a/tests/language/language_dartdevc.status b/tests/language/language_dartdevc.status index d133e2e058c..483a8c97e8a 100644 --- a/tests/language/language_dartdevc.status +++ b/tests/language/language_dartdevc.status @@ -2,9 +2,9 @@ # for details. All rights reserved. Use of this source code is governed by a # BSD-style license that can be found in the LICENSE file. -# Sections in this file should contain "$compiler == dartdevc", dartdevk or ddc. +# Sections in this file should contain "$compiler == ddc". -[ $compiler == dartdevc || $compiler == dartdevk || $compiler == ddc ] +[ $compiler == ddc ] async_star/async_star_await_for_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/51086 async_star/throw_in_catch_test: Skip # Times out. Issue 29920 external_abstract_fields/external_fields_test: SkipByDesign # Non-JS-interop external members are not supported diff --git a/tests/language_2/language_2_dartdevc.status b/tests/language_2/language_2_dartdevc.status index 77f99ef9112..ebdbee41cbe 100644 --- a/tests/language_2/language_2_dartdevc.status +++ b/tests/language_2/language_2_dartdevc.status @@ -2,15 +2,15 @@ # for details. All rights reserved. Use of this source code is governed by a # BSD-style license that can be found in the LICENSE file. -# Sections in this file should contain "$compiler == dartdevc", dartdevk or ddc. +# Sections in this file should contain "$compiler == ddc". -[ ($compiler == dartdevc || $compiler == dartdevk || $compiler == ddc) && ($runtime == ff || $runtime == firefox) ] -async/return_throw_test: Skip # Flaky but not enough to be detected. Re-enable pending a decision on the correct behavior. https://github.com/dart-lang/sdk/issues/44395 - -[ $compiler == dartdevc || $compiler == dartdevk || $compiler == ddc ] +[ $compiler == ddc ] async_star/async_star_await_for_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/51086 async_star/throw_in_catch_test: Skip # Times out. Issue 29920 external_abstract_fields/external_fields_test: SkipByDesign # Non-JS-interop external members are not supported number/int64_literal_runtime*_test: Skip # This is testing Dart 2.0 int64 semantics. superinterface_variance/*: Skip # Issue dart-lang/language#113 vm/*: SkipByDesign # VM only tests.; VM only tests. + +[ $compiler == ddc && ($runtime == ff || $runtime == firefox) ] +async/return_throw_test: Skip # Flaky but not enough to be detected. Re-enable pending a decision on the correct behavior. https://github.com/dart-lang/sdk/issues/44395 diff --git a/tests/lib/lib.status b/tests/lib/lib.status index 74e3e386e16..66602e585a6 100644 --- a/tests/lib/lib.status +++ b/tests/lib/lib.status @@ -83,7 +83,7 @@ js/static_interop_test/native_error_test: SkipByDesign # Issue 42085. CSP policy js/static_interop_test/typed_data_test: SkipByDesign # Issue 42085. CSP policy disallows injected JS code js/trust_types_test: SkipByDesign # Issue 42085. CSP policy disallows injected JS code -[ $compiler != dart2js && $compiler != dartdevc && $compiler != dartdevk && $compiler != ddc ] +[ $compiler != dart2js && $compiler != ddc ] web/*: SkipByDesign [ $runtime == chrome && $system == macos ] diff --git a/tests/lib/lib_dartdevc.status b/tests/lib/lib_dartdevc.status index bd70ee57574..8fb9f623151 100644 --- a/tests/lib/lib_dartdevc.status +++ b/tests/lib/lib_dartdevc.status @@ -2,33 +2,7 @@ # for details. All rights reserved. Use of this source code is governed by a # BSD-style license that can be found in the LICENSE file. -[ $builder_tag == canary && ($compiler == dartdevc || $compiler == dartdevk || $compiler == ddc) ] -async/catch_errors11_test: Skip # Issue 50666 -async/catch_errors12_test: Skip # Issue 50666 -async/catch_errors15_test: Skip # Issue 50666 -async/catch_errors17_test: Skip # Issue 50666 -async/catch_errors20_test: Skip # Issue 50666 -async/catch_errors21_test: Skip # Issue 50666 -async/catch_errors23_test: Skip # Issue 50666 -async/catch_errors24_test: Skip # Issue 50666 -async/catch_errors26_test: Skip # Issue 50666 -async/catch_errors27_test: Skip # Issue 50666 -async/catch_errors5_test: Skip # Issue 50666 -async/catch_errors7_test: Skip # Issue 50666 -async/catch_errors8_test: Skip # Issue 50666 -async/stream_iterator_test: Skip # Issue 50666 -async/stream_zones_test: Skip # Issue 50666 - -[ $runtime == chrome && ($compiler == dartdevc || $compiler == dartdevk || $compiler == ddc) ] -html/js_dispatch_property_test: Skip # Timeout Issue 31030 - -[ $system == macos && ($compiler == dartdevc || $compiler == dartdevk || $compiler == ddc) ] -html/interactive_media_test: Skip # Requires interactive camera, microphone permissions. - -[ $system == windows && ($compiler == dartdevc || $compiler == dartdevk || $compiler == ddc) ] -html/xhr_test: Skip # Times out. Issue 21527 - -[ $compiler == dartdevc || $compiler == dartdevk || $compiler == ddc ] +[ $compiler == ddc ] convert/chunked_conversion_utf88_test: Slow, Pass convert/json_utf8_chunk_test: Slow, Pass convert/streamed_conversion_utf8_decode_test: Slow, Pass # Issue 29922 @@ -51,5 +25,34 @@ html/notification_permission_test: Skip # Issue 32002 isolate/*: SkipByDesign # No support for dart:isolate in dart4web (http://dartbug.com/30538) js/js_util/js_prefix_test: SkipByDesign # JS$ prefix not implemented on ddc. mirrors/*: SkipByDesign # Mirrors not supported on web in Dart 2.0. -typed_data/int64_list_load_store_test: SkipByDesign # dartdevk/c does not support Int64List -typed_data/typed_data_hierarchy_int64_test: SkipByDesign # dartdevk/c does not support Int64List +typed_data/int64_list_load_store_test: SkipByDesign # ddc does not support Int64List +typed_data/typed_data_hierarchy_int64_test: SkipByDesign # ddc does not support Int64List + +[ $builder_tag == canary && $compiler == ddc ] +async/catch_errors11_test: Skip # Issue 50666 +async/catch_errors12_test: Skip # Issue 50666 +async/catch_errors15_test: Skip # Issue 50666 +async/catch_errors17_test: Skip # Issue 50666 +async/catch_errors20_test: Skip # Issue 50666 +async/catch_errors21_test: Skip # Issue 50666 +async/catch_errors23_test: Skip # Issue 50666 +async/catch_errors24_test: Skip # Issue 50666 +async/catch_errors26_test: Skip # Issue 50666 +async/catch_errors27_test: Skip # Issue 50666 +async/catch_errors5_test: Skip # Issue 50666 +async/catch_errors7_test: Skip # Issue 50666 +async/catch_errors8_test: Skip # Issue 50666 +async/stream_iterator_test: Skip # Issue 50666 +async/stream_zones_test: Skip # Issue 50666 + +[ $compiler == ddc && $runtime == chrome ] +html/js_dispatch_property_test: Skip # Timeout Issue 31030 + +[ $compiler == ddc && $system == linux ] +html/interactive_geolocation_test: Skip # Requires allowing geo location. + +[ $compiler == ddc && $system == macos ] +html/interactive_media_test: Skip # Requires interactive camera, microphone permissions. + +[ $compiler == ddc && $system == windows ] +html/xhr_test: Skip # Times out. Issue 21527 diff --git a/tests/lib_2/lib_2.status b/tests/lib_2/lib_2.status index 57a15a68c25..f9ba06a7094 100644 --- a/tests/lib_2/lib_2.status +++ b/tests/lib_2/lib_2.status @@ -68,7 +68,7 @@ js/static_interop_test/external_static_member_lowerings_trusttypes_test: SkipByD js/static_interop_test/external_static_member_lowerings_with_namespaces_test: SkipByDesign # Issue 42085. CSP policy disallows injected JS code js/trust_types_test: SkipByDesign # Issue 42085. CSP policy disallows injected JS code -[ $compiler != dart2js && $compiler != dartdevc && $compiler != dartdevk && $compiler != ddc ] +[ $compiler != dart2js && $compiler != ddc ] web/*: SkipByDesign [ $runtime == chrome && $system == macos ] diff --git a/tests/lib_2/lib_2_dartdevc.status b/tests/lib_2/lib_2_dartdevc.status index f4d63d88e81..6fb023003ba 100644 --- a/tests/lib_2/lib_2_dartdevc.status +++ b/tests/lib_2/lib_2_dartdevc.status @@ -2,16 +2,7 @@ # for details. All rights reserved. Use of this source code is governed by a # BSD-style license that can be found in the LICENSE file. -[ $runtime == chrome && ($compiler == dartdevc || $compiler == dartdevk || $compiler == ddc) ] -html/js_dispatch_property_test: Skip # Timeout Issue 31030 - -[ $system == macos && ($compiler == dartdevc || $compiler == dartdevk || $compiler == ddc) ] -html/interactive_media_test: Skip # Requires interactive camera, microphone permissions. - -[ $system == windows && ($compiler == dartdevc || $compiler == dartdevk || $compiler == ddc) ] -html/xhr_test: Skip # Times out. Issue 21527 - -[ $compiler == dartdevc || $compiler == dartdevk || $compiler == ddc ] +[ $compiler == ddc ] convert/chunked_conversion_utf88_test: Slow, Pass convert/json_utf8_chunk_test: Slow, Pass convert/streamed_conversion_utf8_decode_test: Slow, Pass # Issue 29922 @@ -34,3 +25,15 @@ html/notification_permission_test: Skip # Issue 32002 isolate/*: SkipByDesign # No support for dart:isolate in dart4web (http://dartbug.com/30538) js/js_util/js_prefix_test: SkipByDesign # JS$ prefix not implemented on ddc. mirrors/*: SkipByDesign # Mirrors not supported on web in Dart 2.0. + +[ $compiler == ddc && $runtime == chrome ] +html/js_dispatch_property_test: Skip # Timeout Issue 31030 + +[ $compiler == ddc && $system == linux ] +html/interactive_geolocation_test: Skip # Requires allowing geo location. + +[ $compiler == ddc && $system == macos ] +html/interactive_media_test: Skip # Requires interactive camera, microphone permissions. + +[ $compiler == ddc && $system == windows ] +html/xhr_test: Skip # Times out. Issue 21527 diff --git a/tests/standalone/standalone.status b/tests/standalone/standalone.status index b0e3c9a2a8c..090de572fcd 100644 --- a/tests/standalone/standalone.status +++ b/tests/standalone/standalone.status @@ -102,7 +102,7 @@ fragmentation_typed_data_test: SkipSlow [ $arch == simarm || $arch == simarm64 || $arch == simarm64c || $arch == simriscv32 || $arch == simriscv64 ] io/socket_sigpipe_test: SkipByDesign # Test uses ffi -[ $compiler == dart2js || $compiler == dartdevc || $compiler == dartdevk || $compiler == ddc ] +[ $compiler == dart2js || $compiler == ddc ] *: SkipByDesign [ $runtime == dart_precompiled || $runtime == vm ] diff --git a/tests/standalone_2/standalone_2.status b/tests/standalone_2/standalone_2.status index 8d51ca59381..44235ac9283 100644 --- a/tests/standalone_2/standalone_2.status +++ b/tests/standalone_2/standalone_2.status @@ -109,7 +109,7 @@ fragmentation_typed_data_test: SkipSlow [ $arch == simarm || $arch == simarm64 || $arch == simarm64c || $arch == simriscv32 || $arch == simriscv64 ] io/socket_sigpipe_test: SkipByDesign # Test uses ffi -[ $compiler == dart2js || $compiler == dartdevc || $compiler == dartdevk || $compiler == ddc ] +[ $compiler == dart2js || $compiler == ddc ] *: SkipByDesign [ $runtime == dart_precompiled || $runtime == vm ]