languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 12:24:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

[vm] Fix build on debug IA32.

Browse source 
set_pointer_offsets_length() sets a part of the state_bits bitfield,
so we need to move this check before it's called.

Fixes https://github.com/dart-lang/sdk/issues/52923

TEST=vm-linux-debug-ia32 builds

Cq-Include-Trybots: luci.dart.try:vm-linux-debug-ia32-try
Change-Id: I9f4ec78b03a6b7b2d45f13e9cc277411dcc90493
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313480
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
This commit is contained in:
Tess Strickland 2023-07-13 08:59:36 +00:00 committed by Commit Queue
parent 148af29811
commit db2e318b5d
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
runtime/vm/object.cc
View file

@ -18111,9 +18111,9 @@ CodePtr Code::New(intptr_t pointer_offsets_length) {
auto raw = Object::Allocate<Code>(Heap::kOld, pointer_offsets_length);
NoSafepointScope no_safepoint;
result = raw;
ASSERT_EQUAL(result.untag()->state_bits_, 0);
result.set_pointer_offsets_length(pointer_offsets_length);
}
ASSERT_EQUAL(result.untag()->state_bits_, 0);
DEBUG_ASSERT(result.compile_timestamp() == 0);
#if defined(INCLUDE_IL_PRINTER)
result.set_comments(Comments::New(0));