languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-15 22:31:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[tools] Use pattern matching in find_builders.dart

Browse source 
Minor changes to find_builders.dart script to use pattern
matching, drop duplicate builders, and drop some type casts.

Change-Id: I463ba8352622dc66678aa71627d84130308da9a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/315261
Reviewed-by: Daco Harkes <dacoharkes@google.com>
This commit is contained in:
William Hesse 2023-07-25 09:30:16 +00:00
parent 29ff51a008
commit dab8ab7420
1 changed files with 25 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

51
tools/find_builders.dart
View file

@ -27,28 +27,31 @@ Future<void> main(List<String> args) async {
for (final testName in testNames) ...await _testGetConfigurations(testName),
});
final configurationBuilders = await _configurationBuilders();
final builders = [
final builders = {
for (final config in configurations) configurationBuilders[config]
]..sort();
}.toList()
..sort();
print('Cq-Include-Trybots: luci.dart.try:${builders.join(',')}');
}
Future<List<String>> _testGetConfigurations(String testName) async {
final requestUrl = Uri.parse(
'https://current-results-qvyo5rktwa-uc.a.run.app/v1/results?filter=$testName');
final requestUrl = Uri(
scheme: 'https',
host: 'current-results-qvyo5rktwa-uc.a.run.app',
path: 'v1/results',
queryParameters: {'filter': testName},
);
final response = await _get(requestUrl);
final object = jsonDecode(response) as Map<String, dynamic>;
final results = (object['results'] as List).cast<Map<String, dynamic>>();
return [for (final result in results) result['configuration'] as String];
final object = jsonDecode(response);
return [for (final result in object['results']) result['configuration']];
}
Future<String> _get(Uri requestUrl) async {
final client = HttpClient();
final request = await client.getUrl(requestUrl);
final response = await request.close();
final responseString =
await response.cast<List<int>>().transform(const Utf8Decoder()).join();
final responseString = await response.transform(const Utf8Decoder()).join();
client.close();
return responseString;
}
@ -83,14 +86,11 @@ Stream<Map<String, dynamic>> _configurationDocuments() async* {
},
);
final response = await _get(requestUrl);
final object = jsonDecode(response) as Map<String, dynamic>;
final documents =
(object['documents'] as List).cast<Map<String, dynamic>>();
for (final d in documents) {
yield d;
}
final object = jsonDecode(response);
yield* Stream.fromIterable(
object['documents'].cast<Map<String, dynamic>>());
nextPageToken = object['nextPageToken'] as String?;
nextPageToken = object['nextPageToken'];
if (nextPageToken == null) {
break;
}
@ -98,16 +98,15 @@ Stream<Map<String, dynamic>> _configurationDocuments() async* {
}
Future<Map<String, String>> _configurationBuilders() async {
final result = <String, String>{};
await for (final document in _configurationDocuments()) {
final fullName = document['name'] as String;
final name = fullName.split('/').last;
final builder = document['fields']['builder']['stringValue'] as String?;
if (builder != null) {
result[name] = builder;
}
}
return result;
return {
await for (final document in _configurationDocuments())
if (document
case {
'name': String fullName,
'fields': {'builder': {'stringValue': String builder}}
})
fullName.split('/').last: builder
};
}
void printHelp() {