update the dartdev pubspec file; various lint fixes

Change-Id: Ib4bc6af7f77001895cbc534ef64c6d999008695f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159160
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>

pkg/dartdev/lib/src/analytics.dart

@@ -167,7 +167,7 @@ class DartdevAnalytics extends AnalyticsImpl {
   bool get disclosureShownOnTerminal =>
       (properties['disclosureShown'] as bool) ?? false;
 
-  void set disclosureShownOnTerminal(bool value) {
+  set disclosureShownOnTerminal(bool value) {
     properties['disclosureShown'] = value;
   }
 }

pkg/dartdev/lib/src/commands/test.dart

@@ -2,6 +2,10 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// ignore_for_file: avoid_redundant_argument_values
+// ignore_for_file: lines_longer_than_80_chars
+// ignore_for_file: prefer_initializing_formals
+
 import 'dart:async';
 import 'dart:io';
 import 'dart:math' as math;

pkg/dartdev/pubspec.yaml

@@ -6,22 +6,21 @@ publish_to: none
 environment:
   sdk: '>=2.6.0 <3.0.0'
 dependencies:
+  analysis_server_client:
+    path: ../analysis_server_client
+  analyzer: any
   args: ^1.6.0
   cli_util: '>=0.1.4 <0.3.0'
   dart2native:
     path: ../dart2native
-  dds:
-    path: ../dds
-  intl: ^0.16.1
-  nnbd_migration: any # this uses the SDK version
+  dart_style: any
+  nnbd_migration:
+    path: ../nnbd_migration
   path: ^1.0.0
-  stack_trace: ^1.9.3
   stagehand: 3.3.7
   telemetry:
     path: ../telemetry
   usage: ^3.4.0
-  watcher: ^0.9.6
-  yaml: ^2.2.0
 
 dev_dependencies:
   test: ^1.0.0

pkg/dartdev/test/smoke/smoke_test.dart

@@ -52,8 +52,8 @@ void main() {
       });
 
       test(
-          'dart --sound-null-safety --enable-experiment=non-nullable run smoke.dart',
-          () async {
+          'dart --sound-null-safety --enable-experiment=non-nullable '
+          'run smoke.dart', () async {
         final result = await Process.run(
           Platform.executable,
           [