mirror of
https://github.com/dart-lang/sdk
synced 2024-10-14 11:03:19 +00:00
Remove some unnecessary ignore comments in analyzer packages
Change-Id: I578285132f0d3f200cb2e9069750a1391940711d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274721 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
This commit is contained in:
parent
4981cbffe2
commit
d9482e35ce
|
@ -82,7 +82,6 @@ abstract class TokenStreamRewriter {
|
|||
throw 'Internal Error: Rewriting at eof.';
|
||||
}
|
||||
|
||||
// ignore:unnecessary_null_comparison
|
||||
assert(endGroup.beforeSynthetic != null);
|
||||
if (token == endGroup) return endGroup;
|
||||
Token? errorToken;
|
||||
|
|
|
@ -109,7 +109,6 @@ String white(String string) => wrap(string, WHITE_COLOR);
|
|||
/// determined.
|
||||
bool? _supportsAnsiEscapes(sink) {
|
||||
try {
|
||||
// ignore: undefined_getter
|
||||
return sink.supportsAnsiEscapes;
|
||||
} on NoSuchMethodError {
|
||||
// Ignored: We're running on an older version of the Dart VM which doesn't
|
||||
|
|
|
@ -6,8 +6,6 @@
|
|||
// To regenerate the file, use the script
|
||||
// "pkg/analysis_server/tool/spec/generate_files".
|
||||
|
||||
// ignore_for_file: constant_identifier_names
|
||||
|
||||
const String PROTOCOL_VERSION = '1.33.4';
|
||||
|
||||
const String ANALYSIS_NOTIFICATION_ANALYZED_FILES = 'analysis.analyzedFiles';
|
||||
|
|
|
@ -6,8 +6,6 @@
|
|||
// To regenerate the file, use the script
|
||||
// "pkg/analysis_server/tool/spec/generate_files".
|
||||
|
||||
// ignore_for_file: constant_identifier_names
|
||||
|
||||
import 'dart:convert' hide JsonDecoder;
|
||||
|
||||
import 'package:analysis_server/protocol/protocol.dart';
|
||||
|
|
|
@ -33,7 +33,6 @@ class TypeDefinitionHandler extends MessageHandler<TypeDefinitionParams,
|
|||
@override
|
||||
// The private type in the return type is dictated by the signature of the
|
||||
// super-method and the class's super-class.
|
||||
// ignore: library_private_types_in_public_api
|
||||
Future<ErrorOr<TextDocumentTypeDefinitionResult>> handle(
|
||||
TypeDefinitionParams params,
|
||||
MessageInfo message,
|
||||
|
|
|
@ -2,183 +2,136 @@
|
|||
// for details. All rights reserved. Use of this source code is governed by a
|
||||
// BSD-style license that can be found in the LICENSE file.
|
||||
|
||||
// ignore_for_file: prefer_single_quotes, slash_for_doc_comments
|
||||
import 'package:analyzer/error/error.dart';
|
||||
|
||||
/// An error code representing a problem in a file containing an encoding of a
|
||||
/// transform set.
|
||||
class TransformSetErrorCode extends ErrorCode {
|
||||
/**
|
||||
* Parameters:
|
||||
* 0: the conflicting key
|
||||
* 1: the key that it conflicts with
|
||||
*/
|
||||
/// Parameters:
|
||||
/// 0: the conflicting key
|
||||
/// 1: the key that it conflicts with
|
||||
static const TransformSetErrorCode conflictingKey = TransformSetErrorCode(
|
||||
'conflicting_key',
|
||||
"The key '{0}' can't be used when '{1}' is also used.");
|
||||
|
||||
/**
|
||||
* No parameters.
|
||||
*/
|
||||
/// No parameters.
|
||||
static const TransformSetErrorCode expectedPrimary = TransformSetErrorCode(
|
||||
'expected_primary', "Expected either an identifier or a string literal.");
|
||||
|
||||
/**
|
||||
* Parameters:
|
||||
* 0: the old kind
|
||||
* 1: the new kind
|
||||
*/
|
||||
/// Parameters:
|
||||
/// 0: the old kind
|
||||
/// 1: the new kind
|
||||
static const TransformSetErrorCode incompatibleElementKind =
|
||||
TransformSetErrorCode(
|
||||
'incompatible_element_kind',
|
||||
"An element of kind '{0}' can't be replaced by "
|
||||
"an element of kind '{1}'.");
|
||||
|
||||
/**
|
||||
* Parameters:
|
||||
* 0: the change kind that is invalid
|
||||
* 1: the element kind for the transform
|
||||
*/
|
||||
/// Parameters:
|
||||
/// 0: the change kind that is invalid
|
||||
/// 1: the element kind for the transform
|
||||
static const TransformSetErrorCode invalidChangeForKind =
|
||||
TransformSetErrorCode('invalid_change_for_kind',
|
||||
"A change of type '{0}' can't be used for an element of kind '{1}'.");
|
||||
|
||||
/**
|
||||
* Parameters:
|
||||
* 0: the character that is invalid
|
||||
*/
|
||||
/// Parameters:
|
||||
/// 0: the character that is invalid
|
||||
static const TransformSetErrorCode invalidCharacter =
|
||||
TransformSetErrorCode('invalid_character', "Invalid character '{0}'.");
|
||||
|
||||
/**
|
||||
* Parameters:
|
||||
* 0: the actual type of the key
|
||||
*/
|
||||
/// Parameters:
|
||||
/// 0: the actual type of the key
|
||||
static const TransformSetErrorCode invalidKey = TransformSetErrorCode(
|
||||
'invalid_key', "Keys must be of type 'String' but found the type '{0}'.");
|
||||
|
||||
/**
|
||||
* No parameters.
|
||||
*/
|
||||
/// No parameters.
|
||||
static const TransformSetErrorCode invalidRequiredIf = TransformSetErrorCode(
|
||||
'invalid_required_if',
|
||||
"The key 'requiredIf' can only be used with optional named parameters.");
|
||||
|
||||
/**
|
||||
* Parameters:
|
||||
* 0: the key with which the value is associated
|
||||
* 1: the expected type of the value
|
||||
* 2: the actual type of the value
|
||||
*/
|
||||
/// Parameters:
|
||||
/// 0: the key with which the value is associated
|
||||
/// 1: the expected type of the value
|
||||
/// 2: the actual type of the value
|
||||
static const TransformSetErrorCode invalidValue = TransformSetErrorCode(
|
||||
'invalid_value',
|
||||
"The value of '{0}' should be of type '{1}' but is of type '{2}'.");
|
||||
|
||||
/**
|
||||
* Parameters:
|
||||
* 0: the list of valid parameter styles
|
||||
*/
|
||||
/// Parameters:
|
||||
/// 0: the list of valid parameter styles
|
||||
static const TransformSetErrorCode invalidParameterStyle =
|
||||
TransformSetErrorCode('invalid_parameter_style',
|
||||
"The parameter style must be one of the following: {0}.");
|
||||
|
||||
/**
|
||||
* Parameters:
|
||||
* 0: the key with which the value is associated
|
||||
* 1: the allowed values as a comma-separated list
|
||||
*/
|
||||
/// Parameters:
|
||||
/// 0: the key with which the value is associated
|
||||
/// 1: the allowed values as a comma-separated list
|
||||
static const TransformSetErrorCode invalidValueOneOf = TransformSetErrorCode(
|
||||
'invalid_value_one_of',
|
||||
"The value of '{0}' must be one of the following: '{1}'.");
|
||||
|
||||
/**
|
||||
* Parameters:
|
||||
* 0: the missing key
|
||||
*/
|
||||
/// Parameters:
|
||||
/// 0: the missing key
|
||||
static const TransformSetErrorCode missingKey =
|
||||
TransformSetErrorCode('missing_key', "Missing the required key '{0}'.");
|
||||
|
||||
/**
|
||||
* Parameters:
|
||||
* 0: the list of valid keys
|
||||
*/
|
||||
/// Parameters:
|
||||
/// 0: the list of valid keys
|
||||
static const TransformSetErrorCode missingOneOfMultipleKeys =
|
||||
TransformSetErrorCode('missing_one_of_multiple_keys',
|
||||
"Exactly one of the following keys must be provided: {0}.");
|
||||
|
||||
/**
|
||||
* No parameters.
|
||||
*/
|
||||
/// No parameters.
|
||||
static const TransformSetErrorCode missingTemplateEnd = TransformSetErrorCode(
|
||||
'missing_template_end', "Missing the end brace for the template.");
|
||||
|
||||
/**
|
||||
* Parameters:
|
||||
* 0: a description of the expected kinds of tokens
|
||||
*/
|
||||
/// Parameters:
|
||||
/// 0: a description of the expected kinds of tokens
|
||||
static const TransformSetErrorCode missingToken =
|
||||
TransformSetErrorCode('missing_token', "Expected to find {0}.");
|
||||
|
||||
/**
|
||||
* No parameters.
|
||||
*/
|
||||
/// No parameters.
|
||||
static const TransformSetErrorCode missingUri = TransformSetErrorCode(
|
||||
'missing_uri', "At least one URI must be provided.");
|
||||
|
||||
/**
|
||||
* Parameters:
|
||||
* 0: the missing key
|
||||
*/
|
||||
/// Parameters:
|
||||
/// 0: the missing key
|
||||
static const TransformSetErrorCode undefinedVariable = TransformSetErrorCode(
|
||||
'undefined_variable', "The variable '{0}' isn't defined.");
|
||||
|
||||
/**
|
||||
* Parameters:
|
||||
* 0: the token that was unexpectedly found
|
||||
*/
|
||||
/// Parameters:
|
||||
/// 0: the token that was unexpectedly found
|
||||
static const TransformSetErrorCode unexpectedToken =
|
||||
TransformSetErrorCode('unexpected_token', "Didn't expect to find {0}.");
|
||||
|
||||
/**
|
||||
* Parameters:
|
||||
* 0: a description of the expected kind of token
|
||||
*/
|
||||
/// Parameters:
|
||||
/// 0: a description of the expected kind of token
|
||||
static const TransformSetErrorCode unknownAccessor = TransformSetErrorCode(
|
||||
'unknown_accessor', "The accessor '{0}' is invalid.");
|
||||
|
||||
/**
|
||||
* Parameters:
|
||||
* 0: the unsupported key
|
||||
*/
|
||||
/// Parameters:
|
||||
/// 0: the unsupported key
|
||||
static const TransformSetErrorCode unsupportedKey = TransformSetErrorCode(
|
||||
'unsupported_key', "The key '{0}' isn't supported.");
|
||||
|
||||
/**
|
||||
* No parameters.
|
||||
*/
|
||||
/// No parameters.
|
||||
static const TransformSetErrorCode unsupportedStatic = TransformSetErrorCode(
|
||||
'unsupported_static',
|
||||
"The key 'static' is only supported for elements in a class, enum, "
|
||||
"extension, or mixin.");
|
||||
|
||||
/**
|
||||
* No parameters.
|
||||
*/
|
||||
/// No parameters.
|
||||
static const TransformSetErrorCode unsupportedVersion = TransformSetErrorCode(
|
||||
'unsupported_version', "Only version '1' is supported at this time.");
|
||||
|
||||
/**
|
||||
* Parameters:
|
||||
* 0: a description of the expected kind of token
|
||||
* 1: a description of the actual kind of token
|
||||
*/
|
||||
/// Parameters:
|
||||
/// 0: a description of the expected kind of token
|
||||
/// 1: a description of the actual kind of token
|
||||
static const TransformSetErrorCode wrongToken = TransformSetErrorCode(
|
||||
'wrong_token', "Expected to find {0}, but found {1}.");
|
||||
|
||||
/**
|
||||
* Parameters:
|
||||
* 0: the message produced by the YAML parser
|
||||
*/
|
||||
/// Parameters:
|
||||
/// 0: the message produced by the YAML parser
|
||||
static const TransformSetErrorCode yamlSyntaxError =
|
||||
TransformSetErrorCode('yaml_syntax_error', "Parse error: {0}");
|
||||
|
||||
|
|
|
@ -6,8 +6,6 @@
|
|||
// To regenerate the file, use the script
|
||||
// "pkg/analysis_server/tool/spec/generate_files".
|
||||
|
||||
// ignore_for_file: constant_identifier_names
|
||||
|
||||
/// Convenience methods for running integration tests.
|
||||
import 'dart:async';
|
||||
|
||||
|
|
|
@ -6,8 +6,6 @@
|
|||
// To regenerate the file, use the script
|
||||
// "pkg/analysis_server/tool/spec/generate_files".
|
||||
|
||||
// ignore_for_file: constant_identifier_names
|
||||
|
||||
/// Matchers for data types defined in the analysis server API.
|
||||
import 'package:test/test.dart';
|
||||
|
||||
|
|
|
@ -6,8 +6,6 @@
|
|||
// To regenerate the file, use the script
|
||||
// "pkg/analysis_server/tool/spec/generate_files".
|
||||
|
||||
// ignore_for_file: constant_identifier_names
|
||||
|
||||
import 'package:analysis_server_client/protocol.dart';
|
||||
|
||||
/// [NotificationHandler] processes analysis server notifications
|
||||
|
|
|
@ -6,8 +6,6 @@
|
|||
// To regenerate the file, use the script
|
||||
// "pkg/analysis_server/tool/spec/generate_files".
|
||||
|
||||
// ignore_for_file: constant_identifier_names
|
||||
|
||||
import 'dart:convert' hide JsonDecoder;
|
||||
|
||||
import 'package:analysis_server_client/src/protocol/protocol_base.dart';
|
||||
|
|
|
@ -6,8 +6,6 @@
|
|||
// To regenerate the file, use the script
|
||||
// "pkg/analysis_server/tool/spec/generate_files".
|
||||
|
||||
// ignore_for_file: constant_identifier_names
|
||||
|
||||
const String PROTOCOL_VERSION = '1.33.4';
|
||||
|
||||
const String ANALYSIS_NOTIFICATION_ANALYZED_FILES = 'analysis.analyzedFiles';
|
||||
|
|
|
@ -6,8 +6,6 @@
|
|||
// To regenerate the file, use the script
|
||||
// "pkg/analysis_server/tool/spec/generate_files".
|
||||
|
||||
// ignore_for_file: constant_identifier_names
|
||||
|
||||
import 'dart:convert' hide JsonDecoder;
|
||||
|
||||
import 'package:analysis_server_client/src/protocol/protocol_base.dart';
|
||||
|
|
|
@ -95,7 +95,6 @@ class NamedTypeBuilder extends TypeBuilder {
|
|||
return _type!;
|
||||
}
|
||||
|
||||
// ignore: unnecessary_this
|
||||
final element = this.element;
|
||||
if (element is InterfaceElement) {
|
||||
var parameters = element.typeParameters;
|
||||
|
|
|
@ -204,8 +204,6 @@ f(A a, B b) {
|
|||
}
|
||||
}
|
||||
|
||||
// TODO(srawlins): Re-enable?
|
||||
// ignore: unreachable_from_main
|
||||
class PubSuggestionCodeTest extends PubPackageResolutionTest {
|
||||
// TODO(brianwilkerson) The tests in this class are not being run, and all but
|
||||
// the first would fail. We should implement these checks and enable the
|
||||
|
|
|
@ -23,8 +23,6 @@ main() {
|
|||
});
|
||||
}
|
||||
|
||||
// TODO(srawlins): Re-enable?
|
||||
// ignore: unreachable_from_main
|
||||
class CharacterRangeReaderTest {
|
||||
void test_advance() {
|
||||
CharSequenceReader baseReader = CharSequenceReader("xyzzy");
|
||||
|
|
|
@ -22,8 +22,6 @@ main() {
|
|||
}
|
||||
|
||||
@reflectiveTest
|
||||
// TODO(srawlins): Re-enable?
|
||||
// ignore: unreachable_from_main
|
||||
class ApplyCheckElementTextReplacements {
|
||||
test_applyReplacements() {
|
||||
applyCheckElementTextReplacements();
|
||||
|
|
|
@ -19,8 +19,6 @@ main() {
|
|||
}
|
||||
|
||||
@reflectiveTest
|
||||
// TODO(srawlins): Re-enable?
|
||||
// ignore: unreachable_from_main
|
||||
class ApplyCheckElementTextReplacements {
|
||||
test_applyReplacements() {
|
||||
applyCheckElementTextReplacements();
|
||||
|
|
|
@ -28,8 +28,6 @@ class ListExtensionTest {
|
|||
}
|
||||
|
||||
@reflectiveTest
|
||||
// TODO(srawlins): Re-enable?
|
||||
// ignore: unreachable_from_main
|
||||
class SetExtensionTest {
|
||||
test_addIfNotNull_notNull() {
|
||||
var elements = {0, 1};
|
||||
|
|
|
@ -6,8 +6,6 @@
|
|||
// To regenerate the file, use the script
|
||||
// "pkg/analysis_server/tool/spec/generate_files".
|
||||
|
||||
// ignore_for_file: constant_identifier_names
|
||||
|
||||
import 'dart:convert' hide JsonDecoder;
|
||||
|
||||
import 'package:analyzer_plugin/protocol/protocol.dart';
|
||||
|
|
|
@ -6,8 +6,6 @@
|
|||
// To regenerate the file, use the script
|
||||
// "pkg/analysis_server/tool/spec/generate_files".
|
||||
|
||||
// ignore_for_file: constant_identifier_names
|
||||
|
||||
const String ANALYSIS_NOTIFICATION_ERRORS = 'analysis.errors';
|
||||
const String ANALYSIS_NOTIFICATION_ERRORS_ERRORS = 'errors';
|
||||
const String ANALYSIS_NOTIFICATION_ERRORS_FILE = 'file';
|
||||
|
|
|
@ -6,8 +6,6 @@
|
|||
// To regenerate the file, use the script
|
||||
// "pkg/analysis_server/tool/spec/generate_files".
|
||||
|
||||
// ignore_for_file: constant_identifier_names
|
||||
|
||||
import 'dart:convert' hide JsonDecoder;
|
||||
|
||||
import 'package:analyzer_plugin/protocol/protocol.dart';
|
||||
|
|
|
@ -6,8 +6,6 @@
|
|||
// To regenerate the file, use the script
|
||||
// "pkg/analysis_server/tool/spec/generate_files".
|
||||
|
||||
// ignore_for_file: constant_identifier_names
|
||||
|
||||
/// Convenience methods for running integration tests.
|
||||
import 'dart:async';
|
||||
|
||||
|
|
|
@ -6,8 +6,6 @@
|
|||
// To regenerate the file, use the script
|
||||
// "pkg/analysis_server/tool/spec/generate_files".
|
||||
|
||||
// ignore_for_file: constant_identifier_names
|
||||
|
||||
/// Matchers for data types defined in the analysis server API.
|
||||
import 'package:test/test.dart';
|
||||
|
||||
|
|
|
@ -168,8 +168,6 @@ class CodeGenerator {
|
|||
// This file has been automatically generated. Please do not edit it manually.
|
||||
// To regenerate the file, use the script
|
||||
// "pkg/analysis_server/tool/spec/generate_files".
|
||||
|
||||
// ignore_for_file: constant_identifier_names
|
||||
''';
|
||||
}
|
||||
writeln(header.trim());
|
||||
|
|
Loading…
Reference in a new issue