languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-07-08 12:06:26 +00:00
Code Issues Projects Releases Wiki Activity

[vm] Cleanup dead code RTE ClassID_getID

Browse Source 
This has been dead code since the bytecode interpreter has been removed.

TEST=This removes dead code. Building the SDK tests this code is not
     imported. Running the CQ tests it was not executed.

Change-Id: I75ce3fc2dfccb57d3287db7e716901a8b5a0c20e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/211264
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Tess Strickland <sstrickl@google.com>
Commit-Queue: Tess Strickland <sstrickl@google.com>
This commit is contained in:
Daco Harkes 2021-08-27 07:09:26 +00:00 committed by commit-bot@chromium.org
parent 47b7fd4b75
commit d8093982aa
5 changed files with 4 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
runtime/lib/class_id.cc
View File

@ -1,16 +0,0 @@
// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
#include "platform/assert.h"
#include "vm/bootstrap_natives.h"
namespace dart {
DEFINE_NATIVE_ENTRY(ClassID_getID, 0, 1) {
const Instance& instance =
Instance::CheckedHandle(zone, arguments->NativeArgAt(0));
return Smi::New(instance.GetClassId());
}
} // namespace dart

6
runtime/lib/internal_sources.gni
View File

@ -1,6 +0,0 @@
# Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
# for details. All rights reserved. Use of this source code is governed by a
# BSD-style license that can be found in the LICENSE file.
# Sources that patch the library "dart:_internal".
internal_runtime_cc_files = [ "class_id.cc" ]

9
runtime/vm/BUILD.gn
View File

@ -25,7 +25,6 @@ import("../lib/convert_sources.gni")
import("../lib/core_sources.gni")
import("../lib/developer_sources.gni")
import("../lib/ffi_sources.gni")
import("../lib/internal_sources.gni")
import("../lib/isolate_sources.gni")
import("../lib/math_sources.gni")
import("../lib/mirrors_sources.gni")
@ -153,10 +152,10 @@ library_for_all_configs("libdart_lib") {
}
include_dirs = [ ".." ]
allsources = async_runtime_cc_files + core_runtime_cc_files +
developer_runtime_cc_files + internal_runtime_cc_files +
isolate_runtime_cc_files + math_runtime_cc_files +
mirrors_runtime_cc_files + typed_data_runtime_cc_files +
vmservice_runtime_cc_files + ffi_runtime_cc_files
developer_runtime_cc_files + isolate_runtime_cc_files +
math_runtime_cc_files + mirrors_runtime_cc_files +
typed_data_runtime_cc_files + vmservice_runtime_cc_files +
ffi_runtime_cc_files
sources = [ "bootstrap.cc" ] + rebase_path(allsources, ".", "../lib")
snapshot_sources = []
}

1
runtime/vm/bootstrap_natives.h
View File

@ -356,7 +356,6 @@ namespace dart {
V(UserTag_defaultTag, 0) \
V(UserTag_makeCurrent, 1) \
V(Profiler_getCurrentTag, 0) \
V(ClassID_getID, 1) \
V(VMService_SendIsolateServiceMessage, 2) \
V(VMService_SendRootServiceMessage, 1) \
V(VMService_SendObjectRootServiceMessage, 1) \

14
sdk/lib/_internal/vm/lib/class_id.dart
View File

@ -1,14 +0,0 @@
// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
// part of "internal_patch.dart";
@pragma("vm:entry-point")
class ClassID {
@pragma("vm:entry-point")
@pragma("vm:exact-result-type", "dart:core#_Smi")
static int getID(Object value) native "ClassID_getID";
// VM injects class id constants into this class.
}