From d7e525562a1cb22486fc4a40bb1a187a0239e9e4 Mon Sep 17 00:00:00 2001 From: Alexander Markov Date: Fri, 26 May 2023 20:05:08 +0000 Subject: [PATCH] [test] Skip corelib tests relying on symbol names and stack traces in obfuscated and dwarf modes Change-Id: Ida0c38b11d045a26bb511530e43b06b0a07d0adc Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/306128 Auto-Submit: Alexander Markov Commit-Queue: Alexander Aprelev Reviewed-by: Alexander Aprelev --- tests/corelib/corelib.status | 18 +++++++++--------- tests/corelib_2/corelib_2.status | 18 +++++++++++------- 2 files changed, 20 insertions(+), 16 deletions(-) diff --git a/tests/corelib/corelib.status b/tests/corelib/corelib.status index bb86ce3fc09..533a753fea6 100644 --- a/tests/corelib/corelib.status +++ b/tests/corelib/corelib.status @@ -6,8 +6,12 @@ bigint_parse_radix_test/3: Slow # Issue http://dartbug.com/47050 bigint_test: Pass, Slow [ $builder_tag == obfuscated ] -corelib/nsm_invocation_test: SkipByDesign # Relies on non-obfuscated symbols -corelib/symbol_test: SkipByDesign # Relies on non-obfuscated symbols +apply_generic_function_test: SkipByDesign # Function.apply with named args +apply_test: Skip # Uses new Symbol via symbolToStringMap helper +dynamic_nosuchmethod_test: SkipByDesign # Expects names in NSM +nsm_invocation_test: SkipByDesign # Relies on non-obfuscated symbols +symbol_test: SkipByDesign # Relies on non-obfuscated symbols +type_tostring_test: SkipByDesign # Expects names in Type.toString() [ $compiler == dartkp ] bigint_parse_radix_test: Slow, Pass # --no_intrinsify @@ -35,13 +39,6 @@ bigint_test: Skip # Issue 31659 [ $arch == x64 && $system == windows ] stopwatch_test: Skip # Flaky test due to expected performance behaviour. -[ $builder_tag == obfuscated && $runtime == dart_precompiled ] -apply_generic_function_test: SkipByDesign # Function.apply with named args -apply_test: Skip # Uses new Symbol via symbolToStringMap helper -dynamic_nosuchmethod_test: SkipByDesign # Expects names in NSM -error_stack_trace1_test: SkipByDesign # Relies on symbol names in stack traces. -type_tostring_test: SkipByDesign # Expects names in Type.toString() - [ $compiler != dart2analyzer && $compiler != dart2js && $compiler != ddc ] bigint_js_test: SkipByDesign # JavaScript-specific test @@ -64,6 +61,9 @@ integer_arith_vm_test: SkipByDesign # Is a VM optimization test that requires in iterable_return_type_int64_test: SkipByDesign # Requires int64 support. typed_data_with_limited_ints_test: SkipByDesign # Requires fixed-size int64 support. +[ $builder_tag == dwarf || $builder_tag == obfuscated ] +error_stack_trace1_test: SkipByDesign # Relies on symbol names in stack traces. + [ $runtime == dart_precompiled || $runtime == vm ] regexp/global_test: Skip # Issue 21709 regexp/pcre_test: Slow, Pass diff --git a/tests/corelib_2/corelib_2.status b/tests/corelib_2/corelib_2.status index b4694d7c498..3303dc8c2bf 100644 --- a/tests/corelib_2/corelib_2.status +++ b/tests/corelib_2/corelib_2.status @@ -5,6 +5,14 @@ bigint_parse_radix_test/3: Slow # Issue http://dartbug.com/47050 bigint_test: Pass, Slow +[ $builder_tag == obfuscated ] +apply_generic_function_test: SkipByDesign # Function.apply with named args +apply_test: Skip # Uses new Symbol via symbolMapToStringMap helper +dynamic_nosuchmethod_test: SkipByDesign # Expects names in NSM +nsm_invocation_test: SkipByDesign # Relies on non-obfuscated symbols +symbol_test: SkipByDesign # Relies on non-obfuscated symbols +type_tostring_test: SkipByDesign # Expects names in Type.toString() + [ $compiler == dartkp ] bigint_parse_radix_test: Slow, Pass # --no_intrinsify bigint_test/03: SkipSlow # --no_intrinsify @@ -34,13 +42,6 @@ bigint_test: Skip # Issue 31659 [ $arch == x64 && $system == windows ] stopwatch_test: Skip # Flaky test due to expected performance behaviour. -[ $builder_tag == obfuscated && $runtime == dart_precompiled ] -apply_generic_function_test: SkipByDesign # Function.apply with named args -apply_test: Skip # Uses new Symbol via symbolMapToStringMap helper -dynamic_nosuchmethod_test: SkipByDesign # Expects names in NSM -error_stack_trace1_test: SkipByDesign # Expects unobfuscated stack trace -type_tostring_test: SkipByDesign # Expects names in Type.toString() - [ $compiler != dart2analyzer && $compiler != dart2js && $compiler != ddc ] bigint_js_test: SkipByDesign # JavaScript-specific test @@ -63,6 +64,9 @@ integer_arith_vm_test: SkipByDesign # Is a VM optimization test that requires in iterable_return_type_int64_test: SkipByDesign # Requires int64 support. typed_data_with_limited_ints_test: SkipByDesign # Requires fixed-size int64 support. +[ $builder_tag == dwarf || $builder_tag == obfuscated ] +error_stack_trace1_test: SkipByDesign # Relies on symbol names in stack traces. + [ $runtime == dart_precompiled || $runtime == vm ] regexp/global_test: Skip # Issue 21709 regexp/pcre_test: Slow, Pass