From d7b3812f51d9dd148fe4d03edf1d15de16f89022 Mon Sep 17 00:00:00 2001 From: Brian Wilkerson Date: Tue, 10 Nov 2020 19:15:26 +0000 Subject: [PATCH] Remove a duplication of analysis from some tests Change-Id: Ib358b943519172afaf32ba9185ebec96c57beeda Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171322 Reviewed-by: Konstantin Shcheglov Reviewed-by: Phil Quitslund Commit-Queue: Brian Wilkerson --- .../completion/statement/statement_completion_test.dart | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart b/pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart index eb3883d68b7..504dc74eeaa 100644 --- a/pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart +++ b/pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart @@ -61,10 +61,7 @@ class StatementCompletionTest extends AbstractSingleUnitTest { } Future _computeCompletion(int offset) async { - // TODO(brianwilkerson) I'm fairly confident that `result` is equivalent to - // `testAnalysisResult` and that we're resolving the file twice. - var result = await session.getResolvedUnit(testFile); - var context = StatementCompletionContext(result, offset); + var context = StatementCompletionContext(testAnalysisResult, offset); var processor = StatementCompletionProcessor(context); var completion = await processor.compute(); change = completion.change;