languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 16:41:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix test that expects too much from type inference

Browse source 
R=paulberry@google.com

Change-Id: I7a811b690fe06c3295363e7fccfbafb325a8c9b3
Reviewed-on: https://dart-review.googlesource.com/37740
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Erik Corry <erikcorry@google.com>
This commit is contained in:
Erik Corry 2018-01-31 09:06:31 +00:00 committed by commit-bot@chromium.org
parent abaabd4773
commit d69b81d2e0
3 changed files with 4 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tests/corelib_2/corelib_2.status
View file

@ -406,8 +406,6 @@ apply3_test: CompileTimeError # Issue 31402 (Invocation arguments)
bool_from_environment2_test/03: MissingCompileTimeError
iterable_to_list_test/01: RuntimeError
iterable_to_list_test/none: RuntimeError
list_replace_range_test: RuntimeError
list_set_all_test: RuntimeError
null_nosuchmethod_test/01: CompileTimeError # Issue 31402 (Invocation arguments)
null_nosuchmethod_test/none: CompileTimeError # Issue 31402 (Invocation arguments)
string_from_environment3_test/03: MissingCompileTimeError # Issue 31936 - throwing const constructors.
@ -428,8 +426,6 @@ unicode_test: RuntimeError # Issue 18061: German double S.
bool_from_environment2_test/03: MissingCompileTimeError
iterable_to_list_test/01: RuntimeError
iterable_to_list_test/none: RuntimeError
list_replace_range_test: RuntimeError
list_set_all_test: RuntimeError
null_nosuchmethod_test/01: CompileTimeError # Issue 31402 (Invocation arguments)
null_nosuchmethod_test/none: CompileTimeError # Issue 31402 (Invocation arguments)
regexp/stack-overflow_test: RuntimeError
@ -515,8 +511,6 @@ iterable_return_type_test/02: RuntimeError # Issue 29921
iterable_to_list_test/*: RuntimeError
list_concurrent_modify_test: RuntimeError # DDC uses ES6 array iterators so it does not issue this
list_removeat_test: RuntimeError # Issue 29921
list_replace_range_test: RuntimeError # Issue 29921
list_set_all_test: RuntimeError # Issue 29921
main_test: RuntimeError # Issue 29921
nan_infinity_test/01: RuntimeError # Issue 29921
null_nosuchmethod_test/01: RuntimeError # DDC checks type before too many arguments, so TypeError instead of NSM

4
tests/corelib_2/list_replace_range_test.dart
View file

@ -5,7 +5,7 @@
import "package:expect/expect.dart";
import "dart:collection";
test(List list, int start, int end, Iterable iterable) {
test(List<int> list, int start, int end, Iterable<int> iterable) {
List copy = list.toList();
list.replaceRange(start, end, iterable);
List iterableList = iterable.toList();
@ -22,7 +22,7 @@ test(List list, int start, int end, Iterable iterable) {
}
}
class MyList extends ListBase {
class MyList<T> extends ListBase<T> {
List list;
MyList(this.list);
get length => list.length;

4
tests/corelib_2/list_set_all_test.dart
View file

@ -5,7 +5,7 @@
import "package:expect/expect.dart";
import "dart:collection";
test(List list, int index, Iterable iterable) {
test(List<int> list, int index, Iterable<int> iterable) {
List copy = list.toList();
list.setAll(index, iterable);
Expect.equals(copy.length, list.length);
@ -21,7 +21,7 @@ test(List list, int index, Iterable iterable) {
}
}
class MyList extends ListBase {
class MyList<T> extends ListBase<T> {
List list;
MyList(this.list);
get length => list.length;