From d4e2d78a94fe579fc80e604db47fe3b4cc62d8f8 Mon Sep 17 00:00:00 2001 From: Ryan Macnak Date: Thu, 23 May 2019 17:42:37 +0000 Subject: [PATCH] [vm] Partially disable 5393ce7d35729e6a6b89e6e9316e99c15a8e3639. Avoid flakily failures setting the thread signal mask. Bug: https://github.com/dart-lang/sdk/issues/36908 Change-Id: I3d66214189f3276365b4c1cc333847cb4f65c94f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103400 Commit-Queue: Ryan Macnak Reviewed-by: Alexander Markov --- runtime/vm/os_thread_macos.cc | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/runtime/vm/os_thread_macos.cc b/runtime/vm/os_thread_macos.cc index 50a295288eb..a0d050e017b 100644 --- a/runtime/vm/os_thread_macos.cc +++ b/runtime/vm/os_thread_macos.cc @@ -88,20 +88,6 @@ class ThreadStartData { DISALLOW_COPY_AND_ASSIGN(ThreadStartData); }; -// Spawned threads inherit their spawner's signal mask. We sometimes spawn -// threads for running Dart code from a thread that is blocking SIGPROF. -// This function explicitly unblocks SIGPROF so the profiler continues to -// sample this thread. -static void UnblockSIGPROF() { - sigset_t set; - sigemptyset(&set); - sigaddset(&set, SIGPROF); - int r = pthread_sigmask(SIG_UNBLOCK, &set, NULL); - USE(r); - ASSERT(r == 0); - ASSERT(!CHECK_IS_BLOCKING(SIGPROF)); -} - // Dispatch to the thread start function provided by the caller. This trampoline // is used to ensure that the thread is properly destroyed if the thread just // exits. @@ -121,7 +107,6 @@ static void* ThreadStart(void* data_ptr) { if (thread != NULL) { OSThread::SetCurrent(thread); thread->set_name(name); - UnblockSIGPROF(); // Call the supplied thread start function handing it its parameters. function(parameter); }