languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-06 13:35:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

[vm, compiler] Disable unopt megamorphic call specialization.

Browse source 
Bug: https://github.com/dart-lang/sdk/issues/37260
Change-Id: I66a1661da9483529dc96be804863224d9afb9c48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106006
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
This commit is contained in:
Ryan Macnak 2019-06-14 01:17:30 +00:00 committed by commit-bot@chromium.org
parent 74af4a00b2
commit d47bb87a51
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
runtime/vm/runtime_entry.cc
View file

@ -75,6 +75,15 @@ DEFINE_FLAG(charp,
NULL,
"Deoptimize in named function on stack overflow checks");
DEFINE_FLAG(bool,
unopt_monomorphic_calls,
true,
"Enable specializing monomorphic calls from unoptimized code.");
DEFINE_FLAG(bool,
unopt_megamorphic_calls,
false,
"Enable specializing megamorphic calls from unoptimized code.");
DECLARE_FLAG(int, reload_every);
DECLARE_FLAG(bool, reload_every_optimized);
DECLARE_FLAG(bool, reload_every_back_off);
@ -1117,7 +1126,7 @@ static void TrySwitchInstanceCall(const ICData& ic_data,
intptr_t num_checks = ic_data.NumberOfChecks();
// Monomorphic call.
if (num_checks == 1) {
if (FLAG_unopt_monomorphic_calls && (num_checks == 1)) {
// A call site in the monomorphic state does not load the arguments
// descriptor, so do not allow transition to this state if the callee
// needs it.
@ -1139,7 +1148,8 @@ static void TrySwitchInstanceCall(const ICData& ic_data,
}
// Megamorphic call.
if (num_checks > FLAG_max_polymorphic_checks) {
if (FLAG_unopt_megamorphic_calls &&
(num_checks > FLAG_max_polymorphic_checks)) {
const MegamorphicCache& cache =
MegamorphicCache::Handle(zone, ic_data.AsMegamorphicCache());
ic_data.set_is_megamorphic(true);