Remove (most) uses of the "non-nullable" experiment flag.

Since the flag is now enabled by default, there should be no mention of it.
There are still some uses in front_end/testcases that are not just removable
(it also uses `no-non-nullable`). There migth be more uses that are not
as easily found as grepping for `--enable-experiment

Removes two VM tests where fixing them meant they were just duplicating
the corresponding non *_2/ tests.
Fixes #44941

TEST= Large number of tests chaged.=(no-)?non-nullable`.

Change-Id: Ief755981ccde9a5482fcdf408c2929c74433a710
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/183688
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>

pkg/compiler/test/codegen/codegen_test_helper.dart

@@ -33,7 +33,7 @@ runTests(List<String> args, [int shardIndex]) {
       shards: 2,
       directory: 'data',
       skip: skip,
-      options: ['--enable-experiment=non-nullable', Flags.soundNullSafety]);
+      options: [Flags.soundNullSafety]);
 }
 
 runTests2(List<String> args, [int shardIndex]) {

pkg/compiler/tool/modular_test_suite.dart

@@ -219,7 +219,6 @@ class SourceToDillStep implements IOModularStep {
           .expand((m) => ['--input-linked', '${toUri(m, dillId)}'])),
       ...(sources.expand((String uri) => ['--source', uri])),
       ...(flags.expand((String flag) => ['--enable-experiment', flag])),
-      '--enable-experiment=non-nullable',
     ];
 
     var result =

pkg/dartdev/test/commands/pub_test.dart

@@ -71,26 +71,6 @@ void pub() {
     expect(result.stderr, result2.stderr);
   });
 
-  test('run --enable-experiment', () {
-    p = project();
-    p.file('bin/main.dart',
-        "void main() { int? a; a = null; print('a is \$a.'); }");
-
-    // run 'pub get'
-    p.runSync(['pub', 'get']);
-
-    var result = p.runSync(
-        ['pub', 'run', '--enable-experiment=no-non-nullable', 'main.dart']);
-
-    expect(result.exitCode, 254);
-    expect(result.stdout, isEmpty);
-    expect(
-        result.stderr,
-        contains('bin/main.dart:1:18: Error: This requires the null safety '
-            'language feature, which requires language version of 2.12 or '
-            'higher.\n'));
-  });
-
   test('failure', () {
     p = project(mainSrc: 'int get foo => 1;\n');
     var result = p.runSync(['pub', 'deps']);

pkg/dev_compiler/tool/check_nnbd_sdk.dart

@@ -117,15 +117,12 @@ main() {}
   var result = Process.runSync(dart.toFilePath(), [
     // The NNBD dart binaries / snapshots require this flag to be enabled at
     // VM level.
-    if (analyzerSnapshot.contains('NNBD')) '--enable-experiment=non-nullable',
     analyzerSnapshot,
     '--dart-sdk=${sdkDir}',
     '--format',
     'machine',
     '--sdk-warnings',
     '--no-hints',
-    '--enable-experiment',
-    'non-nullable',
     emptyProgramUri.toFilePath()
   ]);
 

pkg/front_end/test/fasta/testing/suite.dart

@@ -788,7 +788,6 @@ class Run extends Step<ComponentResult, ComponentResult, FastaContext> {
         try {
           var args = <String>[];
           if (experimentalFlags[ExperimentalFlag.nonNullable] == true) {
-            args.add("--enable-experiment=non-nullable");
             if (!context.weak) {
               args.add("--sound-null-safety");
             }

pkg/frontend_server/test/frontend_server_test.dart

@@ -1761,7 +1761,6 @@ class BarState extends State<FizzWidget> {
         '--output-dill=${dillFile.path}',
         '--packages=${package_config.path}',
         '--target=dartdevc',
-        '--enable-experiment=non-nullable',
         file.path,
       ];
 
@@ -1915,7 +1914,6 @@ class BarState extends State<FizzWidget> {
         '--output-dill=${dillFile.path}',
         '--target=dartdevc',
         '--packages=${package_config.path}',
-        '--enable-experiment=non-nullable',
       ];
 
       final StreamController<List<int>> streamController =
@@ -1996,7 +1994,6 @@ class BarState extends State<FizzWidget> {
         '--target=dartdevc',
         '--packages=${package_config.path}',
         '--experimental-emit-debug-metadata',
-        '--enable-experiment=non-nullable',
       ];
 
       final StreamController<List<int>> streamController =
@@ -2243,7 +2240,6 @@ class BarState extends State<FizzWidget> {
         '--output-dill=${dillFile.path}',
         '--target=dartdevc',
         '--packages=${package_config.path}',
-        '--enable-experiment=non-nullable',
       ];
 
       final StreamController<List<int>> streamController =
@@ -2362,7 +2358,6 @@ class BarState extends State<FizzWidget> {
         '--output-dill=${dillFile.path}',
         '--target=dartdevc',
         '--packages=${package_config.path}',
-        '--enable-experiment=non-nullable'
       ];
 
       final StreamController<List<int>> streamController =

runtime/bin/BUILD.gn

@@ -496,7 +496,6 @@ gen_snapshot_action("generate_snapshot_bin") {
     isolate_snapshot_instructions,
   ]
   args = [
-    "--enable-experiment=non-nullable",
     "--sound-null-safety",
     "--deterministic",
     "--snapshot_kind=" + dart_core_snapshot_kind,

runtime/tests/vm/dart/null_safety_autodetection_in_kernel_compiler_test.dart

@@ -29,7 +29,6 @@ compileAndRunTest(String comment, String expectedOutput) async {
     await runGenKernelWithoutStandardOptions('BUILD DILL FILE', [
       "--platform",
       platformDill,
-      '--enable-experiment=non-nullable',
       '--output=$testDillPath',
       testScriptPath,
     ]);

runtime/tests/vm/dart/type_casts_with_null_safety_autodetection_test.dart

@@ -22,7 +22,6 @@ runTest(String script, String output, String temp) async {
   // Do not add Platform.executableArguments into arguments to avoid passing
   // --sound-null-safety / --no-sound-null-safety arguments.
   final result = await runBinary("RUN $script", Platform.executable, [
-    '--enable-experiment=non-nullable',
     '--deterministic',
     '--optimization-counter-threshold=10',
     '--packages=${Platform.packageConfig}',

runtime/tests/vm/dart_2/null_safety_autodetection_in_kernel_compiler_test.dart

@@ -29,7 +29,6 @@ compileAndRunTest(String comment, String expectedOutput) async {
     await runGenKernelWithoutStandardOptions('BUILD DILL FILE', [
       "--platform",
       platformDill,
-      '--enable-experiment=non-nullable',
       '--output=$testDillPath',
       testScriptPath,
     ]);

runtime/vm/BUILD.gn

@@ -183,7 +183,6 @@ template("gen_vm_platform") {
     args += [
       "-Ddart.vm.product=$is_product_flag",
       "-Ddart.isVM=true",
-      "--enable-experiment=non-nullable",
       "--nnbd-agnostic",
     ]
     if (defined(invoker.exclude_source) && invoker.exclude_source) {

sdk/bin/dart2js

@@ -52,4 +52,4 @@ DART_ROOT="$(cd "${SDK_DIR}/.." ; pwd -P)"
 
 DART2JS="package:compiler/src/dart2js.dart"
 
-exec "$DART" "--packages=$DART_ROOT/.packages" --enable-experiment=non-nullable "${EXTRA_VM_OPTIONS[@]}" "$DART2JS" "${EXTRA_OPTIONS[@]}" "$@"
+exec "$DART" "--packages=$DART_ROOT/.packages" "${EXTRA_VM_OPTIONS[@]}" "$DART2JS" "${EXTRA_OPTIONS[@]}" "$@"

sdk/bin/dart2js_sdk

@@ -55,4 +55,4 @@ if [[ $DART_VM_OPTIONS ]]; then
   EXTRA_VM_OPTIONS+=("${OPTIONS[@]}")
 fi
 
-exec "$DART" --enable-experiment=non-nullable "${EXTRA_VM_OPTIONS[@]}" "$SNAPSHOT" "${EXTRA_OPTIONS[@]}" "$@"
+exec "$DART" "${EXTRA_VM_OPTIONS[@]}" "$SNAPSHOT" "${EXTRA_OPTIONS[@]}" "$@"

tests/language/nnbd/flow_analysis/issue41981_error_test.dart

@@ -7,7 +7,6 @@
 // variable, because promotion to `Never` causes the code to be considered
 // unreachable.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 main() {
   late int i;

tests/language/nnbd/flow_analysis/issue43093_test.dart

@@ -6,7 +6,6 @@
 // expression would corrupt the state of flow analysis, causing a crash when
 // trying to finish analyzing an enclosing `if` statement.
 
-// SharedOptions=--enable-experiment=non-nullable
 import 'package:expect/expect.dart';
 
 class C {

tests/language/nnbd/flow_analysis/late_var_assigned_in_try_test.dart

@@ -6,7 +6,6 @@
 // read in a catch or finally block, that there is no compile-time error,
 // because the assignment might happen prior to the exception occurring.
 
-// SharedOptions=--enable-experiment=non-nullable
 import 'package:expect/expect.dart';
 
 void tryCatch() {

tests/language/nnbd/flow_analysis/late_var_used_before_assignment_in_local_function_ok_test.dart

@@ -7,7 +7,6 @@
 // that the assignment might occur before the read, that there is no
 // compile-time error.
 
-// SharedOptions=--enable-experiment=non-nullable
 import 'package:expect/expect.dart';
 
 // First scenario: the variable is written inside the function, and the read

tests/language/nnbd/flow_analysis/late_var_used_before_assignment_in_loop_test.dart

@@ -7,7 +7,6 @@
 // that there is no compile-time error, because the assignment may happen in an
 // earlier iteration than the read.
 
-// SharedOptions=--enable-experiment=non-nullable
 import 'package:expect/expect.dart';
 
 void forLoop() {

tests/language/nnbd/flow_analysis/late_var_used_before_assignment_in_switch_error_test.dart

@@ -8,7 +8,6 @@
 // compile-time error, because the variable is unassigned on all possible
 // control flow paths to the read.
 
-// SharedOptions=--enable-experiment=non-nullable
 import 'package:expect/expect.dart';
 
 void switchBad(int value) {

tests/language/nnbd/flow_analysis/late_var_used_before_assignment_in_switch_test.dart

@@ -7,7 +7,6 @@
 // the assignment occurs somewhere in the switch, that there is no compile-time
 // error, because the assignment may happen prior to a branch to the label.
 
-// SharedOptions=--enable-experiment=non-nullable
 import 'package:expect/expect.dart';
 
 void switchOk(int one) {

tests/language/nnbd/flow_analysis/unreachable_via_getter_get_error_test.dart

@@ -5,7 +5,6 @@
 // This test verifies that if a read is performed on a getter whose type is
 // `Never?`, the resulting code block is considered reachable by flow analysis.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 Never? get neverQuestionGetter => null;
 

tests/language/nnbd/flow_analysis/unreachable_via_getter_get_test.dart

@@ -5,7 +5,6 @@
 // This test verifies that if a read is performed on a getter whose type is
 // `Never`, the resulting code block is considered unreachable by flow analysis.
 
-// SharedOptions=--enable-experiment=non-nullable
 import 'package:expect/expect.dart';
 
 Never get neverGetter => throw 'x';

tests/language/nnbd/flow_analysis/unreachable_via_invocation_error_test.dart

@@ -5,7 +5,6 @@
 // This test verifies that if a method is invoked whose return type is `Never?`,
 // the resulting code block is considered reachable by flow analysis.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 Never? neverQuestionFunction() => null;
 

tests/language/nnbd/flow_analysis/unreachable_via_invocation_test.dart

@@ -5,7 +5,6 @@
 // This test verifies that if a method is invoked whose return type is `Never`,
 // the resulting code block is considered unreachable by flow analysis.
 
-// SharedOptions=--enable-experiment=non-nullable
 import 'package:expect/expect.dart';
 
 Never neverFunction() => throw 'x';

tests/language/nnbd/flow_analysis/unreachable_via_promotion_error_test.dart

@@ -6,7 +6,6 @@
 // resulting code block is considered reachable by flow analysis.  This is in
 // contrast to promotion to `Never`, which is considered unreachable.
 
-// SharedOptions=--enable-experiment=non-nullable
 void promoteViaIsCheck(Object x, Object? y) {
   if (x is! int) {
     if (y is Never?) {

tests/language/nnbd/flow_analysis/unreachable_via_promotion_test.dart

@@ -6,7 +6,6 @@
 // via an explicit `is` check or a comparison to `null`), the resulting code
 // block is considered unreachable by flow analysis.
 
-// SharedOptions=--enable-experiment=non-nullable
 import 'package:expect/expect.dart';
 
 void promoteViaIsCheck(Object x, Object? y) {

tests/language/nnbd/flow_analysis/unreachable_via_variable_get_error_test.dart

@@ -5,7 +5,6 @@
 // This test verifies that if a read is performed on a variable whose type is
 // `Never?`, the resulting code block is considered reachable by flow analysis.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 void explicitNeverQuestionType(Object x, bool b) {
   Never? y = null;

tests/language/nnbd/flow_analysis/unreachable_via_variable_get_test.dart

@@ -5,7 +5,6 @@
 // This test verifies that if a read is performed on a variable whose type is
 // `Never`, the resulting code block is considered unreachable by flow analysis.
 
-// SharedOptions=--enable-experiment=non-nullable
 import 'package:expect/expect.dart';
 
 void explicitNeverType(Never Function() f, Object x, bool b1, bool b2) {

tests/language/nnbd/operator_type_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Tests that language operators and constructrs requiring non-nullable values
 // will not accept an operand with a nullable static type.

tests/language/nnbd/resolution/issue40931_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 main() {}
 

tests/language/nnbd/resolution/issue41479_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 main() {
   A a = A()..foo?.isEven;

tests/language/nnbd/resolution/null_assertion_null_type_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Test that the trailing "!" properly promotes the type `Null` to `Never`, by
 // verifying that it's statically ok to pass it to a function expecting a

tests/language/nnbd/resolution/question_dot_produces_nullable_type_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 bool c = false;
 

tests/language/nnbd/resolution/question_question_lub_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Test that `x ?? y` results in type LUB(x!, y)
 void main() {

tests/language/nnbd/static_errors/await_in_late_local_variable_initializer_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Test that it is a compile time error for a `late` variable initializer
 // to use the `await` expression.

tests/language/nnbd/static_errors/default_value_on_required_parameter_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Test that it is an error if a required named parameter has a default value.
 main() {}

tests/language/nnbd/static_errors/equals_parameter_made_nullable_at_invoke_test.dart

@@ -3,7 +3,6 @@
 // BSD-style license that can be found in the LICENSE file.
 import 'dart:async';
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Test that Object.operator==(Object o) is the signature of ==, but that we can
 // still compare nullable values to Object.

tests/language/nnbd/static_errors/export_legacy_symbol_test.dart

@@ -5,7 +5,6 @@
 // Can't run in strong mode since it contains a legacy library.
 // Requirements=nnbd-weak
 
-// SharedOptions=--enable-experiment=non-nullable
 
 import 'export_legacy_symbol_opted_out_library.dart';
 

tests/language/nnbd/static_errors/implicit_downcasts.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Test that it is an error to do what was once allowed as an "implicit
 // downcast."

tests/language/nnbd/static_errors/late_final_field_with_const_constructor_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Test that it is not a compile time error for a `final` variable to not have
 // an initializer if that variable is declared as `late`.

tests/language/nnbd/static_errors/late_final_without_initializer.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Test that it is not a compile time error for a `final` variable to not have
 // an initializer if that variable is declared as `late`.

tests/language/nnbd/static_errors/missing_default_value_for_parameter_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Test that it is an error if an optional parameter (named or otherwise) with
 // no default value has a potentially non-nullable type.

tests/language/nnbd/static_errors/missing_required_argument_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Test that it is an error if a named parameter that is part of a required
 // group is not bound to an argument at a call site.

tests/language/nnbd/static_errors/non_null_assertion_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 void main() {
   void x;
   int i;

tests/language/nnbd/static_errors/not_assigned_local_if_then_else_else_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // It is an error if a potentially non-nullable local variable which has no
 // initializer expression and is not marked `late` is used before it is

tests/language/nnbd/static_errors/not_assigned_local_if_then_else_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // It is an error if a potentially non-nullable local variable which has no
 // initializer expression and is not marked `late` is used before it is

tests/language/nnbd/static_errors/not_assigned_local_if_then_else_then_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // It is an error if a potentially non-nullable local variable which has no
 // initializer expression and is not marked `late` is used before it is

tests/language/nnbd/static_errors/not_assigned_local_if_then_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // It is an error if a potentially non-nullable local variable which has no
 // initializer expression and is not marked `late` is used before it is

tests/language/nnbd/static_errors/not_assigned_local_initializer_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // It is an error if a potentially non-nullable local variable which has no
 // initializer expression and is not marked `late` is used before it is

tests/language/nnbd/static_errors/not_assigned_local_try_catch_body_catch_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // It is an error if a potentially non-nullable local variable which has no
 // initializer expression and is not marked `late` is used before it is

tests/language/nnbd/static_errors/not_assigned_local_try_catch_body_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // It is an error if a potentially non-nullable local variable which has no
 // initializer expression and is not marked `late` is used before it is

tests/language/nnbd/static_errors/not_assigned_local_while_true_break_after_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // It is an error if a potentially non-nullable local variable which has no
 // initializer expression and is not marked `late` is used before it is

tests/language/nnbd/static_errors/not_assigned_local_while_true_break_before_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // It is an error if a potentially non-nullable local variable which has no
 // initializer expression and is not marked `late` is used before it is

tests/language/nnbd/static_errors/not_initialized_non_nullable_instance_field_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Test that it is an error if an instance field with potentially non-nullable
 // type has no initializer expression and is not initialized in a constructor

tests/language/nnbd/static_errors/not_initialized_non_nullable_static_field_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Test that it is an error if a static field non-nullable type has no
 // initializer expression.

tests/language/nnbd/static_errors/not_initialized_non_nullable_top_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Test that it is an error if a top level variable with non-nullable type has
 // no initializer expression.

tests/language/nnbd/static_errors/nullable_function_types_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 class C {
   call() {}

tests/language/nnbd/static_errors/nullable_supertype_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Test that it is an error to use a nullable type as a supertype.
 import 'package:expect/expect.dart';

tests/language/nnbd/static_errors/subtype_of_never_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Test that it is an error for a class to extend, implement, or mixin the type
 // Never.

tests/language/nnbd/static_errors/super_equals_allows_null_test.dart

@@ -3,7 +3,6 @@
 // BSD-style license that can be found in the LICENSE file.
 import "package:expect/expect.dart";
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Test that `super == x` is allowed when `x` has a nullable type, even if the
 // targeted definition of `operator==` has a parameter with a non-nullable type,

tests/language/nnbd/static_errors/super_equals_disallows_non_matching_type_error_test.dart

@@ -3,7 +3,6 @@
 // BSD-style license that can be found in the LICENSE file.
 import "package:expect/expect.dart";
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Test that `super == x` is properly type checked against the target
 // `operator==` method.  That is, the special allowance in the following spec

tests/language/nnbd/static_errors/this_reference_in_late_field_test.dart

@@ -3,7 +3,6 @@
 // BSD-style license that can be found in the LICENSE file.
 import "package:expect/expect.dart";
 
-// SharedOptions=--enable-experiment=non-nullable
 void main() {
   final c = C();
   Expect.identical(c, c);

tests/language/nnbd/static_errors/throw_of_invalid_type_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Test that it is an error if the static type of `e` in the expression
 // `throw e` is not assignable to `Object`.

tests/language/nnbd/static_errors/unchecked_use_of_nullable_cascaded_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Test that it is an error to use nullable types in unsound ways.
 void main() {

tests/language/nnbd/static_errors/unchecked_use_of_nullable_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Test that it is an error to use nullable types in unsound ways.
 void main() async {

tests/language/nnbd/static_errors/use_nnbd_sdk_test.dart

@@ -3,7 +3,6 @@
 // BSD-style license that can be found in the LICENSE file.
 import "package:expect/expect.dart";
 
-// SharedOptions=--enable-experiment=non-nullable
 void main() {
 }
 

tests/language/nnbd/syntax/cascade_nullcheck_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 import "package:expect/expect.dart";
 

tests/language/nnbd/syntax/class_member_declarations_error_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 class A {
   static late x1;

tests/language/nnbd/syntax/class_member_declarations_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 class A {
   static late final x2;

tests/language/nnbd/syntax/late_modifier_bug_39658.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 import 'package:expect/expect.dart';
 
 int initCalls = 0;

tests/language/nnbd/syntax/late_modifier_edge_cases_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 import 'package:expect/expect.dart';
 
 class A {

tests/language/nnbd/syntax/late_modifier_error_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Invalid uses of "late" modifier
 

tests/language/nnbd/syntax/late_modifier_final_field_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 // VMOptions=--optimization_counter_threshold=10
 import 'package:expect/expect.dart';
 

tests/language/nnbd/syntax/late_modifier_final_local_var_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 // VMOptions=--optimization_counter_threshold=10
 import 'package:expect/expect.dart';
 

tests/language/nnbd/syntax/late_modifier_global_var_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 import 'package:expect/expect.dart';
 
 int initCalls = 0;

tests/language/nnbd/syntax/late_modifier_local_var_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 // VMOptions=--optimization_counter_threshold=10
 import 'package:expect/expect.dart';
 

tests/language/nnbd/syntax/late_modifier_non_final_field_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 // VMOptions=--optimization_counter_threshold=10
 import 'package:expect/expect.dart';
 

tests/language/nnbd/syntax/late_modifier_static_field_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 import 'package:expect/expect.dart';
 
 int initCalls = 0;

tests/language/nnbd/syntax/late_modifier_static_final_field_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 import 'package:expect/expect.dart';
 
 int initCalls = 0;

tests/language/nnbd/syntax/late_modifier_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 import 'package:expect/expect.dart';
 
 late final int d = d_init();

tests/language/nnbd/syntax/non_null_assertion_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Test that the trailing "!" is accepted after a sampling of expression
 // syntaxes.  Verify that the compiler understands the resulting type to be

tests/language/nnbd/syntax/null_assertion_ambiguous_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 import 'package:expect/expect.dart';
 import 'dart:async';
 

tests/language/nnbd/syntax/nullable_type_ambiguous_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 import 'package:expect/expect.dart';
 
 class C {

tests/language/nnbd/syntax/nullable_type_error_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 import 'dart:core';
 import 'dart:core' as core;
 

tests/language/nnbd/syntax/opt_out_nnbd_modifiers_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 // @dart = 2.2
 import 'package:expect/expect.dart';
 

tests/language/nnbd/syntax/required_modifier_error_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 // Invalid uses of "required" modifier
 

tests/language/nnbd/syntax/required_modifier_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 import 'package:expect/expect.dart';
 
 int f({required int i}) => i + 1;

tests/language/nnbd/type_promotion/assignment_inference_after_null_check_test.dart

@@ -7,7 +7,6 @@
 // inference.  This test makes sure that the type argument information is
 // appropriately preserved.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 void f(List<int>? x) {
   if (x == null) {

tests/language/nnbd/type_promotion/assignment_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 void f(Object x) {
   if (x is String) {

tests/language/nnbd/type_promotion/conditional_both_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 void f(bool b, Object x) {
   b ? ((x is String) || (throw 1)) : ((x is String) || (throw 2));

tests/language/nnbd/type_promotion/do_condition_is_not_type_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 void f(Object x) {
   do {

tests/language/nnbd/type_promotion/do_condition_is_type_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 void f(Object x) {
   do {

tests/language/nnbd/type_promotion/do_outer_is_type_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 void f(bool b, Object x) {
   if (x is String) {

tests/language/nnbd/type_promotion/for_outer_is_type_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 void f(bool b, Object x) {
   if (x is String) {

tests/language/nnbd/type_promotion/function_expression_is_type_mutated_in_closure_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 void f() {
   void g(Object x) {

tests/language/nnbd/type_promotion/function_expression_is_type_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 void f() {
   void g(Object x) {

tests/language/nnbd/type_promotion/function_expression_outer_is_type_assigned_outside_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 void f(Object x) {
   late void Function() g;

tests/language/nnbd/type_promotion/if_is_not_type_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 void f(Object x) {
   if (x is! String) {

tests/language/nnbd/type_promotion/if_is_type_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 void f(Object x) {
   if (x is String) {

tests/language/nnbd/type_promotion/logical_or_throw_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-// SharedOptions=--enable-experiment=non-nullable
 
 void f(Object x) {
   x is String || (throw 42);