From cf560fe17bd0e995d7db5d9f2a5c9bb9312426f6 Mon Sep 17 00:00:00 2001 From: Brian Wilkerson Date: Thu, 9 Aug 2018 16:14:56 +0000 Subject: [PATCH] Fix a couple of the tests failing on the analyzer with fasta parser bot Change-Id: Ie955c2577f60efdc0ec6c8b6da0e90e08b1e5c61 Reviewed-on: https://dart-review.googlesource.com/69011 Reviewed-by: Konstantin Shcheglov --- .../dart/completion_contributor_util.dart | 2 +- .../dart/keyword_contributor_test.dart | 16 ---------------- 2 files changed, 1 insertion(+), 17 deletions(-) diff --git a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart index f47d69df466..407c45883f7 100644 --- a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart +++ b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart @@ -47,7 +47,7 @@ abstract class DartCompletionContributorTest extends AbstractContextTest { */ bool get suggestConstructorsWithoutNew => true; - bool get usingFastaParser => analyzer.Parser.useFasta; + bool get usingFastaParser => useCFE || analyzer.Parser.useFasta; void addTestSource(String content) { expect(completionOffset, isNull, reason: 'Call addTestUnit exactly once'); diff --git a/pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart b/pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart index 75ab1eb2ed5..c010d635799 100644 --- a/pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart +++ b/pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart @@ -1884,18 +1884,6 @@ class KeywordContributorTest_UseCFE extends KeywordContributorTest { @override test_after_import2() => super.test_after_import2(); - @failingTest - @override - test_anonymous_function_async2() => super.test_anonymous_function_async2(); - - @failingTest - @override - test_anonymous_function_async7() => super.test_anonymous_function_async7(); - - @failingTest - @override - test_anonymous_function_async9() => super.test_anonymous_function_async9(); - @failingTest @override test_class_extends_name() => super.test_class_extends_name(); @@ -1920,10 +1908,6 @@ class KeywordContributorTest_UseCFE extends KeywordContributorTest { @override test_for_initialization_var() => super.test_for_initialization_var(); - @failingTest - @override - test_function_async() => super.test_function_async(); - @failingTest @override test_function_async4() => super.test_function_async4();