languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-15 21:50:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use isolates for directory listing.

Browse source 
Use isolates to make directory listing asynchroneous from the point
of view of the main Dart isolate. Each listing operation will spawn
a new heavy isolate to perform the actually directory listing using
the synchroneous OS primitives.

R=sgjesse@google.com,iposva@google.com
BUG=
TEST=

Review URL: http://codereview.chromium.org//8232005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@327 260f80e4-7a28-3924-810f-c04153c831b5
This commit is contained in:
ager@google.com 2011-10-11 13:12:14 +00:00
parent d5e6daf99f
commit cf136a7685
2 changed files with 43 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

54
runtime/bin/directory_impl.dart
View file

@ -2,11 +2,39 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
class DirectoryException {
const DirectoryException(String this.message);
final String message;
}
class _DirectoryListingIsolate extends Isolate {
_DirectoryListingIsolate() : super.heavy();
void main() {
port.receive((message, replyTo) {
_list(message['dir'],
message['id'],
message['recursive'],
message['dirHandler'],
message['fileHandler'],
message['doneHandler'],
message['dirErrorHandler']);
});
}
void _list(String dir,
int id,
bool recursive,
ReceivePort dirHandler,
ReceivePort fileHandler,
ReceivePort doneHandler,
ReceivePort dirErrorHandler) native "Directory_List";
}
class _Directory implements Directory {
_Directory.open(String this._dir) {
@ -40,7 +68,6 @@ class _Directory implements Directory {
}
void list([bool recursive = false]) {
// TODO(ager): Spawn an isolate to make the listing an async operation.
if (_closed) {
throw new DirectoryException("Error: directory closed");
}
@ -48,13 +75,17 @@ class _Directory implements Directory {
throw new DirectoryException("Error: listing already in progress");
}
_listing = true;
_list(_dir,
_id,
recursive,
_dirHandler,
_fileHandler,
_doneHandler,
_dirErrorHandler);
new _DirectoryListingIsolate().spawn().then((port) {
// TODO(ager): Do not explicitly transform to send ports when
// that is done automatically.
port.send({ 'dir': _dir,
'id': _id,
'recursive': recursive,
'dirHandler': _dirHandler.toSendPort(),
'fileHandler': _fileHandler.toSendPort(),
'doneHandler': _doneHandler.toSendPort(),
'dirErrorHandler': _dirErrorHandler.toSendPort() });
});
}
// TODO(ager): Implement setting of the handlers as in the process library.
@ -113,13 +144,6 @@ class _Directory implements Directory {
// Native code binding.
bool _open(String dir) native "Directory_Open";
bool _close(int id) native "Directory_Close";
void _list(String dir,
int id,
bool recursive,
ReceivePort dirHandler,
ReceivePort fileHandler,
ReceivePort doneHandler,
ReceivePort dirErrorHandler) native "Directory_List";
ReceivePort _dirHandler;
ReceivePort _fileHandler;

4
runtime/tests/dart/src/DirectoryTest.dart
View file

@ -28,6 +28,10 @@ class DirectoryTest {
});
directory.list();
// Listing is asynchronous, so nothing should be listed at this
// point.
Expect.isFalse(listedSomething);
}
static void testMain() {