From cf0955a83eb3bf37a8006b204b6dc43a821c1d3b Mon Sep 17 00:00:00 2001 From: Natalie Weizenbaum Date: Mon, 27 Jul 2015 11:10:16 -0700 Subject: [PATCH] Include a "jsonrpc" property in all VM service responses. R=johnmccutchan@google.com Review URL: https://codereview.chromium.org//1258733004 . --- CHANGELOG.md | 5 +++++ runtime/vm/service/message.dart | 1 + runtime/vm/service/vmservice.dart | 2 ++ 3 files changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8383615c299..44d3fb4f2a1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -76,6 +76,11 @@ [package spec proposal]: https://github.com/lrhn/dep-pkgspec +### VM Service Protocol Changes + +* Some RPCs that didn't include a `"jsonrpc"` property in their responses now + include one. + ## 1.11.2 ### Core library changes diff --git a/runtime/vm/service/message.dart b/runtime/vm/service/message.dart index 631f0a7673a..d54cb4c338f 100644 --- a/runtime/vm/service/message.dart +++ b/runtime/vm/service/message.dart @@ -143,6 +143,7 @@ class Message { void setErrorResponse(String message) { var response = { + 'jsonrpc': '2.0', 'id': serial, 'result' : { 'type': 'Error', diff --git a/runtime/vm/service/vmservice.dart b/runtime/vm/service/vmservice.dart index e6889bbbe01..7d5217ce792 100644 --- a/runtime/vm/service/vmservice.dart +++ b/runtime/vm/service/vmservice.dart @@ -156,6 +156,7 @@ class VMService extends MessageRouter { String _encodeError(Message message, int code, {String details}) { var response = { + 'jsonrpc': '2.0', 'id' : message.serial, 'error' : { 'code': code, @@ -172,6 +173,7 @@ class VMService extends MessageRouter { String _encodeResult(Message message, Map result) { var response = { + 'jsonrpc': '2.0', 'id' : message.serial, 'result' : result, };