Remove appJit and precompiled compiler options

Towards #37318

- appJit has been replaced by appJitk and is no longer.
- precompiled has been replaced by dartkp and is no longer used.
- For the precompiled runtime, default to dartkp.
- Remove status file references to these compiler options and normalize
  status files.

Change-Id: I48728db13dc84737092a92314e2f474a9309f4d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106942
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
This commit is contained in:
Nate Bosch 2019-06-24 16:07:27 +00:00
parent 37a25d9100
commit cf03e96b90
18 changed files with 59 additions and 237 deletions

View file

@ -585,13 +585,11 @@ class Architecture extends NamedEnum {
class Compiler extends NamedEnum {
static const none = const Compiler._('none');
static const precompiler = const Compiler._('precompiler');
static const dart2js = const Compiler._('dart2js');
static const dart2analyzer = const Compiler._('dart2analyzer');
static const compareAnalyzerCfe = const Compiler._('compare_analyzer_cfe');
static const dartdevc = const Compiler._('dartdevc');
static const dartdevk = const Compiler._('dartdevk');
static const appJit = const Compiler._('app_jit');
static const appJitk = const Compiler._('app_jitk');
static const dartk = const Compiler._('dartk');
static const dartkp = const Compiler._('dartkp');
@ -603,13 +601,11 @@ class Compiler extends NamedEnum {
static final _all = new Map<String, Compiler>.fromIterable([
none,
precompiler,
dart2js,
dart2analyzer,
compareAnalyzerCfe,
dartdevc,
dartdevk,
appJit,
appJitk,
dartk,
dartkp,
@ -664,12 +660,10 @@ class Compiler extends NamedEnum {
case Compiler.dart2analyzer:
case Compiler.compareAnalyzerCfe:
return const [Runtime.none];
case Compiler.appJit:
case Compiler.appJitk:
case Compiler.dartk:
case Compiler.dartkb:
return const [Runtime.vm, Runtime.selfCheck];
case Compiler.precompiler:
case Compiler.dartkp:
return const [Runtime.dartPrecompiled];
case Compiler.specParser:
@ -695,12 +689,10 @@ class Compiler extends NamedEnum {
case Compiler.dart2analyzer:
case Compiler.compareAnalyzerCfe:
return Runtime.none;
case Compiler.appJit:
case Compiler.appJitk:
case Compiler.dartk:
case Compiler.dartkb:
return Runtime.vm;
case Compiler.precompiler:
case Compiler.dartkp:
return Runtime.dartPrecompiled;
case Compiler.specParser:
@ -828,7 +820,7 @@ class Runtime extends NamedEnum {
return Compiler.none;
case dartPrecompiled:
return Compiler.precompiler;
return Compiler.dartkp;
case d8:
case jsshell:

View file

@ -1,6 +0,0 @@
# Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
# for details. All rights reserved. Use of this source code is governed by a
# BSD-style license that can be found in the LICENSE file.
[ $compiler == app_jit ]
mirrors/*: Skip # Issue 27929: Triage

View file

@ -43,13 +43,6 @@ io/socket_info_ipv6_test : Skip
[ $system == windows && $compiler != dart2analyzer ]
io/platform_resolved_executable_test/06: RuntimeError # Issue 23641
[ $compiler == app_jit ]
io/test_extension_test: Skip # Platform.executable
io/test_extension_fail_test: Skip # Platform.executable
io/platform_test: Skip # Platform.executable
full_coverage_test: Skip # Platform.executable
regress_26031_test: Skip # Platform.resolvedExecutable
[ $system == android ]
io/process_exit_test: Skip # Issue 29578
io/process_path_test: Skip # Issue 26376

View file

@ -126,9 +126,6 @@ dart/optimized_stacktrace_line_and_column_test: StaticWarning
[ $compiler == dart2analyzer && $strong ]
*: Skip # Issue 28649
[ $compiler == app_jit ]
dart/snapshot_version_test: Fail,OK # Expects to find script snapshot relative to Dart source.
[ $runtime != vm ]
dart/snapshot_version_test: SkipByDesign # Spawns processes
dart/spawn_infinite_loop_test: Skip # VM shutdown test
@ -156,18 +153,12 @@ cc/IsolateReload_TypeIdentity: Fail # Issue 28349
cc/IsolateReload_TypeIdentityGeneric: Fail # Issue 28349
cc/IsolateReload_TypeIdentityParameter: Fail # Issue 28349
[ $compiler == precompiler ]
dart/byte_array_test: Skip # Incompatible flag --disable_alloc_stubs_after_gc
[ $compiler == precompiler || $mode == product ]
[ $mode == product ]
dart/redirection_type_shuffling_test: SkipByDesign # Imports dart:mirrors
cc/CreateMirrorSystem: SkipByDesign # Imports dart:mirrors
cc/CoreSnapshotSize: SkipByDesign # Imports dart:mirrors
cc/StandaloneSnapshotSize: SkipByDesign # Imports dart:mirrors
[ $compiler == app_jit ]
dart/optimized_stacktrace_line_and_column_test: RuntimeError,OK # app-jit lacks column information
[ $runtime == dart_precompiled ]
dart/optimized_stacktrace_line_and_column_test: RuntimeError,OK # AOT lacks column information
dart/data_uri_spawn_test: SkipByDesign # Isolate.spawnUri

View file

@ -67,16 +67,9 @@ abstract class CompilerConfiguration {
case Compiler.dartdevk:
return DevCompilerConfiguration(configuration);
case Compiler.appJit:
return AppJitCompilerConfiguration(configuration, previewDart2: false);
case Compiler.appJitk:
return AppJitCompilerConfiguration(configuration);
case Compiler.precompiler:
return PrecompilerCompilerConfiguration(configuration,
previewDart2: false);
case Compiler.dartk:
case Compiler.dartkb:
if (configuration.architecture == Architecture.simdbc64 ||
@ -653,8 +646,6 @@ class DevCompilerConfiguration extends CompilerConfiguration {
class PrecompilerCompilerConfiguration extends CompilerConfiguration
with VMKernelCompilerMixin {
final bool previewDart2;
bool get _isAndroid => _configuration.system == System.android;
bool get _isArm => _configuration.architecture == Architecture.arm;
@ -663,8 +654,7 @@ class PrecompilerCompilerConfiguration extends CompilerConfiguration
bool get _isAot => true;
PrecompilerCompilerConfiguration(TestConfiguration configuration,
{this.previewDart2 = true})
PrecompilerCompilerConfiguration(TestConfiguration configuration)
: super._subclass(configuration);
int get timeoutMultiplier {
@ -905,10 +895,7 @@ class PrecompilerCompilerConfiguration extends CompilerConfiguration
}
class AppJitCompilerConfiguration extends CompilerConfiguration {
final bool previewDart2;
AppJitCompilerConfiguration(TestConfiguration configuration,
{this.previewDart2 = true})
AppJitCompilerConfiguration(TestConfiguration configuration)
: super._subclass(configuration);
int get timeoutMultiplier {

View file

@ -1286,8 +1286,6 @@ class StandardTestSuite extends TestSuite {
Compiler.dartk,
Compiler.dartkb,
Compiler.dartkp,
Compiler.precompiler,
Compiler.appJit,
Compiler.appJitk,
];

View file

@ -424,9 +424,7 @@ class TestUtils {
}
static void deleteTempSnapshotDirectory(TestConfiguration configuration) {
if (configuration.compiler == Compiler.appJit ||
configuration.compiler == Compiler.precompiler ||
configuration.compiler == Compiler.dartk ||
if (configuration.compiler == Compiler.dartk ||
configuration.compiler == Compiler.dartkb ||
configuration.compiler == Compiler.dartkp) {
var checked = configuration.isChecked ? '-checked' : '';

View file

@ -15,28 +15,6 @@ valid_source_locations_test: Pass, Slow # Generally slow, even in release-x64.
[ $arch == arm ]
process_service_test: Pass, Fail # Issue 24344
[ $compiler == app_jit ]
bad_reload_test: RuntimeError # Issue 27806
complex_reload_test: RuntimeError # Issue 27806
debugger_location_second_test: Skip # Issue 28180
evaluate_activation_test/instance: RuntimeError # Issue 27806
evaluate_activation_test/scope: RuntimeError # Issue 27806
get_object_rpc_test: RuntimeError # Issue 27806
get_source_report_test: RuntimeError # Issue 27806
next_through_closure_test: RuntimeError # Snapshots don't include source and generated source is not 1-to-1. The column offsets are thus off.
next_through_create_list_and_map_test: RuntimeError # Snapshots don't include source and generated source is not 1-to-1. The column offsets are thus off.
next_through_for_each_loop_test: RuntimeError # Snapshots don't include source and generated source is not 1-to-1. The column offsets are thus off.
next_through_implicit_call_test: RuntimeError # Snapshots don't include source and generated source is not 1-to-1. The column offsets are thus off.
pause_on_unhandled_async_exceptions2_test: Pass, RuntimeError, Timeout, Crash # Issue 29178
process_service_test: RuntimeError # Spawned process runs in Dart2 mode
set_name_rpc_test: RuntimeError # Issue 27806
simple_reload_test: RuntimeError # Issue 27806
step_through_constructor_calls_test: RuntimeError # Snapshots don't include source and generated source is not 1-to-1. The column offsets are thus off.
step_through_function_test: RuntimeError # Snapshots don't include source and generated source is not 1-to-1. The column offsets are thus off.
step_through_switch_test: RuntimeError # Snapshots don't include source and generated source is not 1-to-1. The column offsets are thus off.
step_through_switch_with_continue_test: RuntimeError # Snapshots don't include source and generated source is not 1-to-1. The column offsets are thus off.
unused_changes_in_last_reload_test: RuntimeError # Issue 27806
# Tests with known analyzer issues
[ $compiler == dart2analyzer ]
developer_extension_test: SkipByDesign
@ -47,9 +25,6 @@ get_isolate_after_language_error_test: SkipByDesign
add_breakpoint_rpc_kernel_test: SkipByDesign # kernel specific version of add_breakpoint_rpc_test
evaluate_function_type_parameters_test: SkipByDesign # only supported in kernel
[ $compiler == precompiler ]
*: Skip # Issue 24651
# Service protocol is not supported in product mode.
[ $mode == product ]
*: SkipByDesign
@ -62,6 +37,10 @@ dev_fs_weird_char_test: Skip # Windows disallows question mark in paths
[ $compiler == none && $runtime == vm && $system == fuchsia ]
*: Skip # Not yet triaged.
[ $compiler == none && ($runtime == dart_precompiled || $runtime == vm) ]
evaluate_activation_test/instance: RuntimeError # http://dartbug.com/20047
evaluate_activation_test/scope: RuntimeError # http://dartbug.com/20047
[ $mode == debug && $system == windows && $checked ]
async_scope_test: Pass, Slow
@ -74,10 +53,6 @@ async_scope_test: Pass, Slow
[ !$strong && ($compiler == dartk || $compiler == dartkp) ]
*: Skip
[ ($compiler == none || $compiler == precompiler) && ($runtime == dart_precompiled || $runtime == vm) ]
evaluate_activation_test/instance: RuntimeError # http://dartbug.com/20047
evaluate_activation_test/scope: RuntimeError # http://dartbug.com/20047
[ $arch != ia32 || $arch != x64 || $system != linux ]
get_native_allocation_samples_test: Skip # Unsupported.

View file

@ -43,9 +43,6 @@ dart/v8_snapshot_profile_writer_test: Pass, Slow # Can be slow due to re-invokin
[ $compiler == fasta ]
dart/data_uri_import_test/badencodeddate: CompileTimeError
[ $compiler == precompiler ]
dart/byte_array_test: SkipByDesign # Incompatible flag --disable_alloc_stubs_after_gc
[ $mode == debug ]
cc/CorelibIsolateStartup: SkipByDesign # This is a benchmark that is not informative in debug mode.
cc/IRTest_TypedDataAOT_FunctionalGetSet: Skip # run_vm_tests contains JIT/AOT but FLAG_precompiled_mode is not always correct. This causes this test to fail in debug mode, hitting an assertion. See http://dartbug.com/36521
@ -54,6 +51,12 @@ cc/VerifyImplicit_Crash: Crash # Negative tests of VerifiedMemory should crash i
dart/appjit_cha_deopt_test: Pass, Slow # Quite slow in debug mode, uses --optimization-counter-threshold=100
dart/spawn_shutdown_test: Pass, Slow # VM Shutdown test, It can take some time for all the isolates to shutdown in a Debug build.
[ $mode == product ]
cc/CoreSnapshotSize: SkipByDesign # Imports dart:mirrors
cc/CreateMirrorSystem: SkipByDesign # Imports dart:mirrors
cc/StandaloneSnapshotSize: SkipByDesign # Imports dart:mirrors
dart/redirection_type_shuffling_test: SkipByDesign # Imports dart:mirrors
[ $runtime == dart_precompiled ]
dart/data_uri_spawn_test: SkipByDesign # Isolate.spawnUri
dart/issue32950_test: SkipByDesign # uses spawnUri.
@ -257,12 +260,6 @@ dart/entrypoints/jit/*: SkipByDesign # Only supported in the Dart 2 JIT and AOT,
[ $compiler != dartkp || $hot_reload || $hot_reload_rollback || $arch != arm && $arch != simarm && $arch != x64 ]
dart/entrypoints/aot/*: SkipByDesign # Only supported in the Dart 2 JIT and AOT, and test optimizations - hence disabled on hotreload bots.
[ $compiler == precompiler || $mode == product ]
cc/CoreSnapshotSize: SkipByDesign # Imports dart:mirrors
cc/CreateMirrorSystem: SkipByDesign # Imports dart:mirrors
cc/StandaloneSnapshotSize: SkipByDesign # Imports dart:mirrors
dart/redirection_type_shuffling_test: SkipByDesign # Imports dart:mirrors
[ $mode == debug || $runtime != dart_precompiled || $system == android ]
dart/use_bare_instructions_flag_test: SkipByDesign # This test is for VM AOT only and is quite slow (so we don't run it in debug mode).

View file

@ -8,9 +8,6 @@ sample_extension/test/*: Skip # Issue 14705
[ $builder_tag == optimization_counter_threshold ]
sample_extension/test/sample_extension_app_snapshot_test: SkipByDesign # This test is too slow for testing with low optimization counter threshold.
[ $compiler == precompiler ]
sample_extension/test/*: Skip # These tests attempt to spawn another script using the precompiled runtime.
[ $compiler == dart2js && $runtime == none ]
*: Fail, Pass # TODO(ahe): Triage these tests.

View file

@ -70,11 +70,21 @@ string_from_environment3_test/03: MissingCompileTimeError
bool_from_environment2_test/03: MissingCompileTimeError
string_from_environment3_test/03: MissingCompileTimeError
[ $compiler == precompiler ]
bigint_test: Pass, Timeout # --no_intrinsify
int_parse_radix_test: Pass, Timeout # --no_intrinsify
integer_parsed_mul_div_vm_test: Pass, Timeout # --no_intrinsify
regexp/stack-overflow_test: RuntimeError, OK # Smaller limit with irregex interpreter
[ $compiler == none ]
int_parse_radix_bad_handler_test: MissingCompileTimeError
symbol_operator_test/03: Fail # Issue 11669
symbol_reserved_word_test/02: CompileTimeError # Issue 20191
symbol_reserved_word_test/04: MissingCompileTimeError # Issue 11669, 19972, With the exception of 'void', const Symbol() should not accept reserved words.
symbol_reserved_word_test/06: RuntimeError # Issue 11669, With the exception of 'void', new Symbol() should not accept reserved words.
symbol_reserved_word_test/07: MissingCompileTimeError # Issue 11669, 19972, With the exception of 'void', const Symbol() should not accept reserved words.
symbol_reserved_word_test/09: RuntimeError # Issue 11669, With the exception of 'void', new Symbol() should not accept reserved words.
symbol_reserved_word_test/10: MissingCompileTimeError # Issue 11669, 19972, With the exception of 'void', const Symbol() should not accept reserved words.
symbol_reserved_word_test/12: RuntimeError # Issue 11669, With the exception of 'void', new Symbol() should not accept reserved words.
symbol_test/01: Fail, Pass # Issue 11669
symbol_test/02: MissingCompileTimeError # Issue 11669
symbol_test/03: MissingCompileTimeError # Issue 11669
symbol_test/none: Fail # Issue 11669
unicode_test: Fail # Issue 6706
[ $mode == debug ]
regexp/pcre_test: Pass, Slow # Issue 22008
@ -235,9 +245,11 @@ from_environment_const_type_undefined_test/16: MissingCompileTimeError
iterable_to_set_test: RuntimeError # is-checks do not implement strong mode type system
string_base_vm_static_test: MissingCompileTimeError
[ $compiler == precompiler && $runtime == dart_precompiled && !$checked ]
iterable_generate_test/01: RuntimeError
splay_tree_from_iterable_test: RuntimeError
# We no longer expect Dart2 tests to run with the standalone VM without the new
# common front end, but for now we get better coverage by still running them in
# checked mode, which is mostly Dart2-compatible.
[ $compiler == none && !$checked && ($runtime == dart_precompiled || $runtime == vm) ]
*: SkipByDesign
[ $mode == release && $hot_reload && ($compiler == dartk || $compiler == dartkb) ]
bigint_parse_radix_test: Crash
@ -271,12 +283,6 @@ symbol_reserved_word_test/12: RuntimeError # Issues 11669 and 31936 - throwing c
symbol_test/none: RuntimeError # Issues 11669 and 31936 - throwing const constructors.
unicode_test: RuntimeError # Issue 18061: German double S.
# We no longer expect Dart2 tests to run with the standalone VM without the new
# common front end, but for now we get better coverage by still running them in
# checked mode, which is mostly Dart2-compatible.
[ !$checked && ($compiler == app_jit || $compiler == none || $compiler == precompiler) && ($runtime == dart_precompiled || $runtime == vm) ]
*: SkipByDesign
[ !$preview_dart_2 && ($runtime == dart_precompiled || $runtime == vm) ]
*: SkipByDesign # Deprecating all Dart1 modes of execution
@ -290,49 +296,6 @@ bigint_test: Skip # Issue 31659
[ $arch == simdbc || $arch == simdbc64 ]
regexp/stack-overflow_test: RuntimeError, OK # Smaller limit with irregex interpreter
[ $compiler == app_jit || $compiler == none || $compiler == precompiler ]
int_parse_radix_bad_handler_test: MissingCompileTimeError
symbol_operator_test/03: Fail # Issue 11669
symbol_reserved_word_test/02: CompileTimeError # Issue 20191
symbol_reserved_word_test/04: MissingCompileTimeError # Issue 11669, 19972, With the exception of 'void', const Symbol() should not accept reserved words.
symbol_reserved_word_test/06: RuntimeError # Issue 11669, With the exception of 'void', new Symbol() should not accept reserved words.
symbol_reserved_word_test/07: MissingCompileTimeError # Issue 11669, 19972, With the exception of 'void', const Symbol() should not accept reserved words.
symbol_reserved_word_test/09: RuntimeError # Issue 11669, With the exception of 'void', new Symbol() should not accept reserved words.
symbol_reserved_word_test/10: MissingCompileTimeError # Issue 11669, 19972, With the exception of 'void', const Symbol() should not accept reserved words.
symbol_reserved_word_test/12: RuntimeError # Issue 11669, With the exception of 'void', new Symbol() should not accept reserved words.
symbol_test/01: Fail, Pass # Issue 11669
symbol_test/02: MissingCompileTimeError # Issue 11669
symbol_test/03: MissingCompileTimeError # Issue 11669
symbol_test/none: Fail # Issue 11669
unicode_test: Fail # Issue 6706
[ $compiler == app_jit || $compiler == precompiler ]
from_environment_const_type_test/02: MissingCompileTimeError
from_environment_const_type_test/03: MissingCompileTimeError
from_environment_const_type_test/04: MissingCompileTimeError
from_environment_const_type_test/06: MissingCompileTimeError
from_environment_const_type_test/07: MissingCompileTimeError
from_environment_const_type_test/08: MissingCompileTimeError
from_environment_const_type_test/09: MissingCompileTimeError
from_environment_const_type_test/11: MissingCompileTimeError
from_environment_const_type_test/12: MissingCompileTimeError
from_environment_const_type_test/13: MissingCompileTimeError
from_environment_const_type_test/14: MissingCompileTimeError
from_environment_const_type_test/16: MissingCompileTimeError
from_environment_const_type_undefined_test/02: MissingCompileTimeError
from_environment_const_type_undefined_test/03: MissingCompileTimeError
from_environment_const_type_undefined_test/04: MissingCompileTimeError
from_environment_const_type_undefined_test/06: MissingCompileTimeError
from_environment_const_type_undefined_test/07: MissingCompileTimeError
from_environment_const_type_undefined_test/08: MissingCompileTimeError
from_environment_const_type_undefined_test/09: MissingCompileTimeError
from_environment_const_type_undefined_test/11: MissingCompileTimeError
from_environment_const_type_undefined_test/12: MissingCompileTimeError
from_environment_const_type_undefined_test/13: MissingCompileTimeError
from_environment_const_type_undefined_test/14: MissingCompileTimeError
from_environment_const_type_undefined_test/16: MissingCompileTimeError
iterable_to_set_test: RuntimeError # is-checks do not implement strong mode type system
[ $compiler == dartdevc || $compiler == dartdevk ]
bigint_from_test: RuntimeError # Issue 32589
bigint_test: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351

View file

@ -2,9 +2,6 @@
# for details. All rights reserved. Use of this source code is governed by a
# BSD-style license that can be found in the LICENSE file.
[ $compiler == app_jit ]
deferred_inheritance_constraints_test/redirecting_constructor: Crash
[ $compiler == compare_analyzer_cfe ]
const_native_factory_test: Fail # Issue 29763
deferred_global_test: Fail # Issue 34503
@ -24,6 +21,11 @@ nested_generic_closure_test: Fail # Issue 28515
[ $compiler != dart2analyzer ]
switch_case_warn_test: Skip # Analyzer only, see language_analyzer2.status
[ $compiler == none ]
invalid_returns/*: Skip # https://github.com/dart-lang/sdk/issues/34013
library_env_test/has_no_mirror_support: RuntimeError, OK
void/*: Skip # https://github.com/dart-lang/sdk/issues/34013
[ $compiler == spec_parser ]
double_literals/*: Skip # https://github.com/dart-lang/sdk/issues/34355
invalid_returns/*: Skip # https://github.com/dart-lang/sdk/issues/34015
@ -58,9 +60,6 @@ partial_instantiation_static_bounds_check_test/01: MissingCompileTimeError # Iss
partial_instantiation_static_bounds_check_test/02: MissingCompileTimeError # Issue 34327
partial_instantiation_static_bounds_check_test/03: MissingCompileTimeError # Issue 34327
[ $compiler != app_jitk && $compiler != dartk && $compiler != dartkb && $compiler != dartkp && $mode == debug && $runtime == vm ]
built_in_identifier_type_annotation_test/set: Crash # Not supported by legacy VM front-end.
[ $compiler != compare_analyzer_cfe && $compiler != dart2js && $compiler != spec_parser && !$fasta ]
compile_time_constant_static5_test/11: CompileTimeError # Issue 30546
compile_time_constant_static5_test/16: CompileTimeError # Issue 30546
@ -93,14 +92,12 @@ implicit_creation/implicit_const_not_default_values_test/e9: MissingCompileTimeE
[ $compiler != dart2js && $compiler != dartdevc && !$checked ]
function_type/*: Skip # Needs checked mode.
[ $compiler != dartk && $compiler != dartkb && $compiler != dartkp && $mode == debug && $runtime == vm ]
built_in_identifier_type_annotation_test/set: Crash # Not supported by legacy VM front-end.
[ !$preview_dart_2 && ($runtime == dart_precompiled || $runtime == vm) ]
*: SkipByDesign # Deprecating all Dart1 modes of execution
[ $compiler == app_jit || $compiler == none ]
invalid_returns/*: Skip # https://github.com/dart-lang/sdk/issues/34013
library_env_test/has_no_mirror_support: RuntimeError, OK
void/*: Skip # https://github.com/dart-lang/sdk/issues/34013
[ $hot_reload || $hot_reload_rollback ]
cha_deopt1_test: Crash # Requires deferred libraries
cha_deopt2_test: Crash # Requires deferred libraries

View file

@ -18,15 +18,6 @@ async_star/async_star_await_for_test: RuntimeError
async_star/async_star_cancel_test: RuntimeError
async_star/async_star_test: RuntimeError
[ $compiler == precompiler && $runtime == dart_precompiled ]
async_star/async_star_await_for_test: RuntimeError
async_star/async_star_cancel_test: RuntimeError
async_star/async_star_invalid_test/01: MissingCompileTimeError
async_star/async_star_invalid_test/02: MissingCompileTimeError
async_star/async_star_invalid_test/04: MissingCompileTimeError
async_star/async_star_invalid_test/none: RuntimeError
async_star/async_star_test: RuntimeError
[ $runtime == dart_precompiled && $minified ]
cyclic_type_test/*: Skip
enum_duplicate_test/*: Skip # Uses Enum.toString()

View file

@ -184,21 +184,18 @@ html/custom_elements_test: Pass, Timeout # Issue 26789
html/request_animation_frame_test: Skip # Times out. Issue 22167
html/transition_event_test: Skip # Times out. Issue 22167
[ $runtime != dart_precompiled && ($runtime != vm || $compiler != dartk && $compiler != none) ]
isolate/vm_rehash_test: SkipByDesign
[ !$preview_dart_2 && ($runtime == dart_precompiled || $runtime == vm) ]
*: SkipByDesign # Deprecating all Dart1 modes of execution
[ ($compiler != precompiler || $runtime != dart_precompiled) && ($runtime != vm || $compiler != dartk && $compiler != none) ]
isolate/vm_rehash_test: SkipByDesign
[ $arch == simarm || $arch == simarmv5te || $arch == simarmv6 ]
convert/utf85_test: Skip # Pass, Slow Issue 12644.
[ $arch != x64 || $compiler == dartkb || $runtime != vm ]
isolate/int32_length_overflow_test: SkipSlow
[ $compiler == app_jit || $mode == product || $runtime != vm ]
isolate/checked_test: Skip # Unsupported.
[ $compiler != none || $runtime != vm ]
isolate/package_config_test: SkipByDesign # Uses Isolate.packageConfig
isolate/package_resolve_test: SkipByDesign # Uses Isolate.resolvePackageUri
@ -206,6 +203,9 @@ isolate/package_root_test: SkipByDesign # Uses Isolate.packageRoot
isolate/scenarios/*: SkipByDesign # Use automatic package resolution, spawnFunction and .dart URIs.
isolate/spawn_uri_fail_test: SkipByDesign # Uses dart:io.
[ $mode == product || $runtime != vm ]
isolate/checked_test: Skip # Unsupported.
[ $runtime == chrome || $runtime == chromeOnAndroid ]
html/webgl_1_test: Pass, Fail # Issue 8219

View file

@ -2,5 +2,5 @@
# for details. All rights reserved. Use of this source code is governed by a
# BSD-style license that can be found in the LICENSE file.
[ $compiler == app_jit || $compiler == app_jitk ]
[ $compiler == app_jitk ]
mirrors/*: Skip # Issue 27929: Triage

View file

@ -2,35 +2,7 @@
# for details. All rights reserved. Use of this source code is governed by a
# BSD-style license that can be found in the LICENSE file.
[ $compiler == precompiler ]
async/async_no_await_zones_test: RuntimeError # Issue 33700
convert/chunked_conversion_utf88_test: Pass, Timeout
convert/utf85_test: Pass, Timeout
html/*: SkipByDesign # dart:html not supported on AOT.
isolate/count_test: SkipByDesign
isolate/cross_isolate_message_test: SkipByDesign
isolate/illegal_msg_function_test: SkipByDesign
isolate/illegal_msg_mirror_test: SkipByDesign
isolate/isolate_complex_messages_test: SkipByDesign
isolate/mandel_isolate_test: SkipByDesign
isolate/message2_test: SkipByDesign
isolate/message_test: SkipByDesign
isolate/mint_maker_test: SkipByDesign
isolate/nested_spawn2_test: SkipByDesign
isolate/nested_spawn_test: SkipByDesign
isolate/raw_port_test: SkipByDesign
isolate/request_reply_test: SkipByDesign
isolate/spawn_function_custom_class_test: SkipByDesign
isolate/spawn_function_test: SkipByDesign
isolate/stacktrace_message_test: SkipByDesign
isolate/static_function_test: SkipByDesign
isolate/unresolved_ports_test: SkipByDesign
js/datetime_roundtrip_test: CompileTimeError
js/null_test: CompileTimeError
js/prototype_access_test: CompileTimeError
mirrors/*: SkipByDesign # Mirrors not supported on AOT.
[ $compiler == app_jit || $compiler == none || $compiler == precompiler ]
[ $compiler == none ]
async/future_or_strong_test: RuntimeError
async/timer_not_available_test: SkipByDesign # only meant to test when there is no way to implement timer (currently only in d8)
isolate/compile_time_error_test/01: Skip # Issue 12587

View file

@ -5,10 +5,6 @@
[ $builder_tag == obfuscated ]
dwarf_stack_trace_test: Pass, RuntimeError # Issue 35563
[ $compiler == precompiler ]
io/web_socket_test: Pass, RuntimeError # Issue 24674
map_insert_remove_oom_test: Skip # Heap limit too low. Increasing iteration count to make a higher limit a meaningful test makes it too slow for simarm[64] bots.
[ $runtime == dart_precompiled ]
http_launch_test: Skip
io/addlatexhash_test: Skip
@ -49,6 +45,14 @@ io/stdio_nonblocking_test: Skip
io/test_extension_fail_test: Skip
io/test_extension_test: Skip
io/windows_environment_test: Skip
package/scenarios/empty_packages_file/empty_packages_file_noimports_test: Skip
package/scenarios/invalid/invalid_utf8_test: Skip
package/scenarios/invalid/non_existent_packages_file_test: Skip
package/scenarios/invalid/same_package_twice_test: Skip
package/scenarios/packages_file_strange_formatting/empty_lines_test: Skip
package/scenarios/packages_file_strange_formatting/mixed_line_ends_test: Skip
package/scenarios/packages_option_only/packages_option_only_noimports_test: Skip
package/scenarios/packages_option_only/packages_option_only_test: Skip
[ $arch == arm && $mode == release && $runtime == dart_precompiled && $system == android ]
io/socket_cancel_connect_test: RuntimeError # Issue 34142
@ -60,18 +64,5 @@ dwarf_stack_trace_test: Pass, RuntimeError # Results will flake due to identical
[ $runtime == dart_precompiled && $checked ]
io/namespace_test: RuntimeError
[ $compiler == app_jit || $compiler == precompiler ]
io/compile_all_test: Skip # Incompatible flag --compile_all
[ $compiler == app_jit || $runtime == dart_precompiled ]
package/scenarios/empty_packages_file/empty_packages_file_noimports_test: Skip
package/scenarios/invalid/invalid_utf8_test: Skip
package/scenarios/invalid/non_existent_packages_file_test: Skip
package/scenarios/invalid/same_package_twice_test: Skip
package/scenarios/packages_file_strange_formatting/empty_lines_test: Skip
package/scenarios/packages_file_strange_formatting/mixed_line_ends_test: Skip
package/scenarios/packages_option_only/packages_option_only_noimports_test: Skip
package/scenarios/packages_option_only/packages_option_only_test: Skip
[ $mode == product || $runtime == dart_precompiled ]
no_assert_test: SkipByDesign # Requires checked mode.

View file

@ -6,20 +6,6 @@
link_natives_lazily_test: SkipByDesign # Not supported.
no_allow_absolute_addresses_test: SkipByDesign # Not supported.
[ $compiler == app_jit ]
full_coverage_test: Skip # Platform.executable
io/namespace_test: RuntimeError # Issue 33168
io/platform_resolved_executable_test/00: RuntimeError # Issue 33168
io/platform_resolved_executable_test/01: RuntimeError # Issue 33168
io/platform_resolved_executable_test/02: RuntimeError # Issue 33168
io/platform_resolved_executable_test/03: RuntimeError # Issue 33168
io/platform_resolved_executable_test/04: RuntimeError # Issue 33168
io/platform_resolved_executable_test/05: RuntimeError # Issue 33168
io/platform_test: Skip # Platform.executable
io/test_extension_fail_test: Skip # Platform.executable
io/test_extension_test: Skip # Platform.executable
regress_26031_test: Skip # Platform.resolvedExecutable
[ $system == android ]
io/file_stat_test: Skip # Issue 26376
io/file_system_watcher_test: Skip # Issue 26376