languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-21 07:21:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow Window.open to return null in dart2js

Browse source 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1540333002 .
This commit is contained in:
Alan Knight 2015-12-21 13:32:29 -08:00
parent d2c403704c
commit ced1e5d1e7
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
sdk/lib/html/dart2js/html_dart2js.dart
View file

@ -31962,10 +31962,11 @@ class Window extends EventTarget implements WindowEventHandlers, WindowBase, Glo
*/
Document get document => JS('Document', '#.document', this);
WindowBase _open2(url, name) => JS('Window', '#.open(#,#)', this, url, name);
WindowBase _open2(url, name) =>
JS('Window|Null', '#.open(#,#)', this, url, name);
WindowBase _open3(url, name, options) =>
JS('Window', '#.open(#,#,#)', this, url, name, options);
JS('Window|Null', '#.open(#,#,#)', this, url, name, options);
/**
* Opens a new window.

5
tools/dom/templates/html/impl/impl_Window.darttemplate
View file

@ -47,10 +47,11 @@ $if DART2JS
*/
Document get document => JS('Document', '#.document', this);
WindowBase _open2(url, name) => JS('Window', '#.open(#,#)', this, url, name);
WindowBase _open2(url, name) =>
JS('Window|Null', '#.open(#,#)', this, url, name);
WindowBase _open3(url, name, options) =>
JS('Window', '#.open(#,#,#)', this, url, name, options);
JS('Window|Null', '#.open(#,#,#)', this, url, name, options);
/**
* Opens a new window.