languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 08:24:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Emit API-only summaries

Browse source 
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2435203002 .
This commit is contained in:
Vijay Menon 2016-10-20 16:21:53 -07:00
parent cc1ad8cdde
commit ce963596f0
2 changed files with 20 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pkg/dev_compiler/lib/src/compiler/code_generator.dart
View file

@ -217,7 +217,10 @@ class CodeGenerator extends GeneralizingAstVisitor
true)
.forEach(assembler.addLinkedLibrary);
return assembler.assemble().toBuffer();
var bundle = assembler.assemble();
// Preserve only API-level information in the summary.
bundle.flushInformative();
return bundle.toBuffer();
}
JS.Program _emitModule(List<CompilationUnit> compilationUnits) {

17
pkg/dev_compiler/lib/src/compiler/command.dart
View file

@ -81,6 +81,15 @@ $stackTrace
}
}
bool _changed(List<int> list1, List<int> list2) {
var length = list1.length;
if (length != list2.length) return true;
for (var i = 0; i < length; ++i) {
if (list1[i] != list2[i]) return true;
}
return false;
}
void _compile(ArgResults argResults, void printFn(Object obj)) {
var compiler =
new ModuleCompiler(new AnalyzerOptions.fromArguments(argResults));
@ -150,7 +159,13 @@ void _compile(ArgResults argResults, void printFn(Object obj)) {
if (module.summaryBytes != null) {
var summaryPath =
path.withoutExtension(outPath) + '.${compilerOpts.summaryExtension}';
new File(summaryPath).writeAsBytesSync(module.summaryBytes);
// Only overwrite if summary changed. This plays better with timestamp
// based build systems.
var file = new File(summaryPath);
if (!file.existsSync() ||
_changed(file.readAsBytesSync(), module.summaryBytes)) {
file.writeAsBytesSync(module.summaryBytes);
}
}
}
}