languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-04 18:07:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change GN debug builds to use -O2, which is the value used by GYP.

Browse source 
Running the language tests in debug mode, I got the following times
GYP -O2 1:50
GN -O1 4:48
GN -O2 1:55

R=zra@google.com

Review-Url: https://codereview.chromium.org/2614003003 .
This commit is contained in:
Ryan Macnak 2017-01-09 09:09:40 -08:00
parent badfd146d2
commit ccd6cc7fc5
3 changed files with 19 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
build/config/compiler/BUILD.gn
View file

@ -745,7 +745,7 @@ config("no_optimize") {
ldflags = common_optimize_on_ldflags ldflags = common_optimize_on_ldflags
} else { } else {
cflags = [ cflags = [
"-O1", "-O2",
"-fdata-sections", "-fdata-sections",
"-ffunction-sections", "-ffunction-sections",
] ]

2
runtime/BUILD.gn
View file

@ -163,7 +163,7 @@ config("dart_config") {
] ]
if (dart_debug) { if (dart_debug) {
cflags += [ "-O1" ] cflags += [ "-O2" ]
} else { } else {
cflags += [ "-O3" ] cflags += [ "-O3" ]
} }

17
runtime/tests/vm/vm.status
View file

@ -31,6 +31,23 @@ cc/Sleep: Pass, Fail
dart/data_uri_import_test/none: SkipByDesign dart/data_uri_import_test/none: SkipByDesign
[ $mode == debug ] [ $mode == debug ]
cc/Profiler_ArrayAllocation: Fail # 28304
cc/Profiler_BasicSourcePosition: Fail # 28304
cc/Profiler_BasicSourcePositionOptimized: Fail # 28304
cc/Profiler_BinaryOperatorSourcePosition: Fail # 28304
cc/Profiler_BinaryOperatorSourcePositionOptimized: Fail # 28304
cc/Profiler_ChainedSamples: Fail # 28304
cc/Profiler_ClosureAllocation: Fail # 28304
cc/Profiler_CodeTicks: Fail # 28304
cc/Profiler_ContextAllocation: Fail # 28304
cc/Profiler_FunctionInline: Fail # 28304
cc/Profiler_FunctionTicks: Fail # 28304
cc/Profiler_SourcePosition: Fail # 28304
cc/Profiler_SourcePositionOptimized: Fail # 28304
cc/Profiler_ToggleRecordAllocation: Fail # 28304
cc/Profiler_TrivialRecordAllocation: Fail # 28304
cc/Profiler_TypedArrayAllocation: Fail # 28304
# This is a benchmark that is not informative in debug mode. # This is a benchmark that is not informative in debug mode.
cc/CorelibIsolateStartup: Skip cc/CorelibIsolateStartup: Skip
# Negative tests of VerifiedMemory should crash iff in DEBUG mode. # Negative tests of VerifiedMemory should crash iff in DEBUG mode.