diff --git a/runtime/lib/convert_patch.dart b/runtime/lib/convert_patch.dart index a2c802d5a59..34fa1e64720 100644 --- a/runtime/lib/convert_patch.dart +++ b/runtime/lib/convert_patch.dart @@ -620,22 +620,6 @@ abstract class _ChunkedJsonParser { return double.parse(getString(start, end, asciiBits)); } - /** - * Create a _NumberBuffer containing the digits from [start] to [chunkEnd]. - * - * This creates a number buffer and initializes it with the part of the - * number literal ending the current chunk - */ - void createNumberBuffer(int start) { - assert(start >= 0); - assert(start < chunkEnd); - int length = chunkEnd - start; - var buffer = new _NumberBuffer(length); - copyCharsToList(start, chunkEnd, buffer.list, 0); - buffer.length = length; - return buffer; - } - /** * Continues parsing a partial value. */ diff --git a/runtime/observatory/tests/service/test_helper.dart b/runtime/observatory/tests/service/test_helper.dart index c8a41113006..391385444cc 100644 --- a/runtime/observatory/tests/service/test_helper.dart +++ b/runtime/observatory/tests/service/test_helper.dart @@ -334,7 +334,7 @@ class _ServiceTesterRunner { print('All service tests completed successfully.'); testsDone = true; - await process.requestExit(); + process.requestExit(); }); }, onError: (error, stackTrace) { if (testsDone) { diff --git a/runtime/tests/vm/dart/byte_array_optimized_test.dart b/runtime/tests/vm/dart/byte_array_optimized_test.dart index 763fa52c90e..827b93c259e 100644 --- a/runtime/tests/vm/dart/byte_array_optimized_test.dart +++ b/runtime/tests/vm/dart/byte_array_optimized_test.dart @@ -24,7 +24,7 @@ class OptimizedByteArrayTest { return e is RangeError; }); Expect.throws(() { - return array[-1]; + array[-1]; }, (e) { return e is RangeError; }); @@ -130,7 +130,7 @@ class OptimizedByteArrayTest { return e is RangeError; }); Expect.throws(() { - return array[-1]; + array[-1]; }, (e) { return e is RangeError; }); @@ -227,7 +227,7 @@ class OptimizedByteArrayTest { return e is RangeError; }); Expect.throws(() { - return array[-1]; + array[-1]; }, (e) { return e is RangeError; }); @@ -353,7 +353,7 @@ class OptimizedByteArrayTest { return e is RangeError; }); Expect.throws(() { - return array[-1]; + array[-1]; }, (e) { return e is RangeError; }); @@ -460,7 +460,7 @@ class OptimizedByteArrayTest { return e is RangeError; }); Expect.throws(() { - return array[-1]; + array[-1]; }, (e) { return e is RangeError; }); @@ -586,7 +586,7 @@ class OptimizedByteArrayTest { return e is RangeError; }); Expect.throws(() { - return array[-1]; + array[-1]; }, (e) { return e is RangeError; }); @@ -698,7 +698,7 @@ class OptimizedByteArrayTest { return e is RangeError; }); Expect.throws(() { - return array[-1]; + array[-1]; }, (e) { return e is RangeError; }); @@ -822,7 +822,7 @@ class OptimizedByteArrayTest { return e is RangeError; }); Expect.throws(() { - return array[-1]; + array[-1]; }, (e) { return e is RangeError; }); @@ -928,7 +928,7 @@ class OptimizedByteArrayTest { return e is RangeError; }); Expect.throws(() { - return array[-1]; + array[-1]; }, (e) { return e is RangeError; }); @@ -1030,7 +1030,7 @@ class OptimizedByteArrayTest { return e is RangeError; }); Expect.throws(() { - return array[-1]; + array[-1]; }, (e) { return e is RangeError; }); @@ -1172,7 +1172,7 @@ class OptimizedByteArrayTest { return e is RangeError; }); Expect.throws(() { - return view[-1]; + view[-1]; }, (e) { return e is RangeError; }); @@ -1346,7 +1346,7 @@ class OptimizedByteArrayTest { return e is RangeError; }); Expect.throws(() { - return view[-1]; + view[-1]; }, (e) { return e is RangeError; }); @@ -1480,7 +1480,7 @@ class OptimizedByteArrayTest { return e is RangeError; }); Expect.throws(() { - return view[-1]; + view[-1]; }, (e) { return e is RangeError; }); @@ -1808,7 +1808,7 @@ class OptimizedByteArrayTest { return e is RangeError; }); Expect.throws(() { - return view[-1]; + view[-1]; }, (e) { return e is RangeError; }); @@ -2054,7 +2054,7 @@ class OptimizedByteArrayTest { return e is RangeError; }); Expect.throws(() { - return view[-1]; + view[-1]; }, (e) { return e is RangeError; }); @@ -2521,7 +2521,7 @@ class OptimizedByteArrayTest { return e is RangeError; }); Expect.throws(() { - return view[-1]; + view[-1]; }, (e) { return e is RangeError; }); @@ -2862,7 +2862,7 @@ class OptimizedByteArrayTest { return e is RangeError; }); Expect.throws(() { - return view[-1]; + view[-1]; }, (e) { return e is RangeError; }); @@ -3522,7 +3522,7 @@ class OptimizedByteArrayTest { return e is RangeError; }); Expect.throws(() { - return view[-1]; + view[-1]; }, (e) { return e is RangeError; }); @@ -3956,7 +3956,7 @@ class OptimizedByteArrayTest { return e is RangeError; }); Expect.throws(() { - return view[-1]; + view[-1]; }, (e) { return e is RangeError; }); @@ -4121,7 +4121,7 @@ class OptimizedByteArrayTest { return e is RangeError; }); Expect.throws(() { - return view[-1]; + view[-1]; }, (e) { return e is RangeError; }); diff --git a/runtime/tests/vm/dart/byte_array_test.dart b/runtime/tests/vm/dart/byte_array_test.dart index 903bf2bda4f..d3dc4b2cb13 100644 --- a/runtime/tests/vm/dart/byte_array_test.dart +++ b/runtime/tests/vm/dart/byte_array_test.dart @@ -22,7 +22,7 @@ class ByteArrayTest { return e is RangeError; }); Expect.throws(() { - return array[-1]; + array[-1]; }, (e) { return e is RangeError; }); @@ -131,7 +131,7 @@ class ByteArrayTest { return e is RangeError; }); Expect.throws(() { - return array[-1]; + array[-1]; }, (e) { return e is RangeError; }); @@ -231,7 +231,7 @@ class ByteArrayTest { return e is RangeError; }); Expect.throws(() { - return array[-1]; + array[-1]; }, (e) { return e is RangeError; }); @@ -332,7 +332,7 @@ class ByteArrayTest { return e is RangeError; }); Expect.throws(() { - return array[-1]; + array[-1]; }, (e) { return e is RangeError; }); @@ -461,7 +461,7 @@ class ByteArrayTest { return e is RangeError; }); Expect.throws(() { - return array[-1]; + array[-1]; }, (e) { return e is RangeError; }); @@ -571,7 +571,7 @@ class ByteArrayTest { return e is RangeError; }); Expect.throws(() { - return array[-1]; + array[-1]; }, (e) { return e is RangeError; }); @@ -700,7 +700,7 @@ class ByteArrayTest { return e is RangeError; }); Expect.throws(() { - return array[-1]; + array[-1]; }, (e) { return e is RangeError; }); @@ -815,7 +815,7 @@ class ByteArrayTest { return e is RangeError; }); Expect.throws(() { - return array[-1]; + array[-1]; }, (e) { return e is RangeError; }); @@ -942,7 +942,7 @@ class ByteArrayTest { return e is RangeError; }); Expect.throws(() { - return array[-1]; + array[-1]; }, (e) { return e is RangeError; }); @@ -1051,7 +1051,7 @@ class ByteArrayTest { return e is RangeError; }); Expect.throws(() { - return array[-1]; + array[-1]; }, (e) { return e is RangeError; }); @@ -1156,7 +1156,7 @@ class ByteArrayTest { return e is RangeError; }); Expect.throws(() { - return array[-1]; + array[-1]; }, (e) { return e is RangeError; }); @@ -1566,7 +1566,7 @@ class ByteArrayTest { return e is RangeError; }); Expect.throws(() { - return view[-1]; + view[-1]; }, (e) { return e is RangeError; }); @@ -1740,7 +1740,7 @@ class ByteArrayTest { return e is RangeError; }); Expect.throws(() { - return view[-1]; + view[-1]; }, (e) { return e is RangeError; }); @@ -1874,7 +1874,7 @@ class ByteArrayTest { return e is RangeError; }); Expect.throws(() { - return view[-1]; + view[-1]; }, (e) { return e is RangeError; }); @@ -2202,7 +2202,7 @@ class ByteArrayTest { return e is RangeError; }); Expect.throws(() { - return view[-1]; + view[-1]; }, (e) { return e is RangeError; }); @@ -2448,7 +2448,7 @@ class ByteArrayTest { return e is RangeError; }); Expect.throws(() { - return view[-1]; + view[-1]; }, (e) { return e is RangeError; }); @@ -2915,7 +2915,7 @@ class ByteArrayTest { return e is RangeError; }); Expect.throws(() { - return view[-1]; + view[-1]; }, (e) { return e is RangeError; }); @@ -3256,7 +3256,7 @@ class ByteArrayTest { return e is RangeError; }); Expect.throws(() { - return view[-1]; + view[-1]; }, (e) { return e is RangeError; }); @@ -3916,7 +3916,7 @@ class ByteArrayTest { return e is RangeError; }); Expect.throws(() { - return view[-1]; + view[-1]; }, (e) { return e is RangeError; }); @@ -4350,7 +4350,7 @@ class ByteArrayTest { return e is RangeError; }); Expect.throws(() { - return view[-1]; + view[-1]; }, (e) { return e is RangeError; }); @@ -4515,7 +4515,7 @@ class ByteArrayTest { return e is RangeError; }); Expect.throws(() { - return view[-1]; + view[-1]; }, (e) { return e is RangeError; }); diff --git a/samples/sample_extension/test/sample_extension_test_helper.dart b/samples/sample_extension/test/sample_extension_test_helper.dart index 72819b9e3b2..157942c928c 100644 --- a/samples/sample_extension/test/sample_extension_test_helper.dart +++ b/samples/sample_extension/test/sample_extension_test_helper.dart @@ -85,6 +85,6 @@ Future testNativeExtensions(String snapshotKind) async { await run(Platform.executable, args); } } finally { - await tempDirectory.deleteSync(recursive: true); + tempDirectory.deleteSync(recursive: true); } } diff --git a/tests/language_2/async_star_test.dart b/tests/language_2/async_star_test.dart index abe7de81023..fa18ff4a69c 100644 --- a/tests/language_2/async_star_test.dart +++ b/tests/language_2/async_star_test.dart @@ -596,7 +596,8 @@ main() { f() async* { try { list.add(0); - yield list.add(1); + list.add(1); + yield null; list.add(2); } finally { exits.complete(3); diff --git a/tests/language_2/inferrer_this_access_test.dart b/tests/language_2/inferrer_this_access_test.dart index 2115bc3a22f..4d1b5fcc70f 100644 --- a/tests/language_2/inferrer_this_access_test.dart +++ b/tests/language_2/inferrer_this_access_test.dart @@ -25,7 +25,7 @@ abstract class B { class C extends B { set hest(value) { - return a + 42; + a + 42; } } diff --git a/tests/language_2/issue15606_test.dart b/tests/language_2/issue15606_test.dart index dc3ad7a87a6..a1ec9f91162 100644 --- a/tests/language_2/issue15606_test.dart +++ b/tests/language_2/issue15606_test.dart @@ -6,7 +6,7 @@ class Foo {} var a = [new Object(), 42]; -void bar(x, y) {} +bar(x, y) {} main() { while (false) { diff --git a/tests/language_2/language_2_analyzer.status b/tests/language_2/language_2_analyzer.status index 42452d8e8f2..c6dcd86233d 100644 --- a/tests/language_2/language_2_analyzer.status +++ b/tests/language_2/language_2_analyzer.status @@ -221,78 +221,51 @@ vm/regress_33469_test/02: Crash # http://dartbug.com/33481 vm/regress_33469_test/03: MissingCompileTimeError # http://dartbug.com/33481 void_type_override_test/02: MissingCompileTimeError void_type_override_test/03: MissingCompileTimeError -void_type_usage_test/call_conditional: MissingCompileTimeError void_type_usage_test/call_literal_list_init: MissingCompileTimeError void_type_usage_test/call_literal_map_key_init: MissingCompileTimeError void_type_usage_test/call_literal_map_value_init: MissingCompileTimeError void_type_usage_test/call_void_init: MissingCompileTimeError -void_type_usage_test/conditional2_conditional: MissingCompileTimeError -void_type_usage_test/conditional2_for: MissingCompileTimeError void_type_usage_test/conditional2_literal_list_init: MissingCompileTimeError void_type_usage_test/conditional2_literal_map_value_init: MissingCompileTimeError void_type_usage_test/conditional2_null_equals2: MissingCompileTimeError -void_type_usage_test/conditional2_parens: MissingCompileTimeError -void_type_usage_test/conditional2_return: MissingCompileTimeError -void_type_usage_test/conditional2_return_to_void: MissingCompileTimeError -void_type_usage_test/conditional2_stmt: MissingCompileTimeError void_type_usage_test/conditional2_void_init: MissingCompileTimeError -void_type_usage_test/conditional3_conditional: MissingCompileTimeError -void_type_usage_test/conditional3_for: MissingCompileTimeError void_type_usage_test/conditional3_literal_list_init: MissingCompileTimeError void_type_usage_test/conditional3_literal_map_value_init: MissingCompileTimeError void_type_usage_test/conditional3_null_equals2: MissingCompileTimeError -void_type_usage_test/conditional3_parens: MissingCompileTimeError -void_type_usage_test/conditional3_return: MissingCompileTimeError -void_type_usage_test/conditional3_return_to_void: MissingCompileTimeError -void_type_usage_test/conditional3_stmt: MissingCompileTimeError void_type_usage_test/conditional3_void_init: MissingCompileTimeError -void_type_usage_test/conditional_conditional: MissingCompileTimeError -void_type_usage_test/conditional_for: MissingCompileTimeError void_type_usage_test/conditional_literal_list_init: MissingCompileTimeError void_type_usage_test/conditional_literal_map_value_init: MissingCompileTimeError void_type_usage_test/conditional_null_equals2: MissingCompileTimeError -void_type_usage_test/conditional_parens: MissingCompileTimeError -void_type_usage_test/conditional_return: MissingCompileTimeError -void_type_usage_test/conditional_return_to_void: MissingCompileTimeError -void_type_usage_test/conditional_stmt: MissingCompileTimeError void_type_usage_test/conditional_void_init: MissingCompileTimeError -void_type_usage_test/final_local_conditional: MissingCompileTimeError void_type_usage_test/final_local_for_in2: MissingCompileTimeError void_type_usage_test/final_local_literal_list_init: MissingCompileTimeError void_type_usage_test/final_local_literal_map_key_init: MissingCompileTimeError void_type_usage_test/final_local_literal_map_value_init: MissingCompileTimeError void_type_usage_test/final_local_void_init: MissingCompileTimeError -void_type_usage_test/global_conditional: MissingCompileTimeError void_type_usage_test/global_literal_list_init: MissingCompileTimeError void_type_usage_test/global_literal_map_key_init: MissingCompileTimeError void_type_usage_test/global_literal_map_value_init: MissingCompileTimeError void_type_usage_test/global_void_init: MissingCompileTimeError -void_type_usage_test/instance2_conditional: MissingCompileTimeError void_type_usage_test/instance2_literal_list_init: MissingCompileTimeError void_type_usage_test/instance2_literal_map_key_init: MissingCompileTimeError void_type_usage_test/instance2_literal_map_value_init: MissingCompileTimeError void_type_usage_test/instance2_void_init: MissingCompileTimeError -void_type_usage_test/instance3_conditional: MissingCompileTimeError void_type_usage_test/instance3_literal_list_init: MissingCompileTimeError void_type_usage_test/instance3_literal_map_key_init: MissingCompileTimeError void_type_usage_test/instance3_literal_map_value_init: MissingCompileTimeError void_type_usage_test/instance3_void_init: MissingCompileTimeError -void_type_usage_test/instance_conditional: MissingCompileTimeError void_type_usage_test/instance_literal_list_init: MissingCompileTimeError void_type_usage_test/instance_literal_map_key_init: MissingCompileTimeError void_type_usage_test/instance_literal_map_value_init: MissingCompileTimeError void_type_usage_test/instance_void_init: MissingCompileTimeError -void_type_usage_test/local_conditional: MissingCompileTimeError void_type_usage_test/local_literal_list_init: MissingCompileTimeError void_type_usage_test/local_literal_map_key_init: MissingCompileTimeError void_type_usage_test/local_literal_map_value_init: MissingCompileTimeError void_type_usage_test/local_void_init: MissingCompileTimeError -void_type_usage_test/param_conditional: MissingCompileTimeError void_type_usage_test/param_literal_list_init: MissingCompileTimeError void_type_usage_test/param_literal_map_key_init: MissingCompileTimeError void_type_usage_test/param_literal_map_value_init: MissingCompileTimeError void_type_usage_test/param_void_init: MissingCompileTimeError -void_type_usage_test/paren_conditional: MissingCompileTimeError void_type_usage_test/paren_literal_list_init: MissingCompileTimeError void_type_usage_test/paren_literal_map_key_init: MissingCompileTimeError void_type_usage_test/paren_literal_map_value_init: MissingCompileTimeError @@ -369,7 +342,6 @@ generic_no_such_method_dispatcher_test: CompileTimeError generic_tearoff_test: CompileTimeError interceptor6_test: CompileTimeError issue13673_test: StaticWarning # Issue 31925 -issue15606_test/none: CompileTimeError # invalid use of void for dart 2 issue31596_implement_covariant_test: CompileTimeError issue31596_override_test/01: CompileTimeError issue31596_override_test/02: CompileTimeError diff --git a/tests/language_2/language_2_dart2js.status b/tests/language_2/language_2_dart2js.status index 329ec9c54dc..b46abebfc98 100644 --- a/tests/language_2/language_2_dart2js.status +++ b/tests/language_2/language_2_dart2js.status @@ -704,39 +704,28 @@ vm/unaligned_integer_access_literal_index_test: RuntimeError vm/unaligned_integer_access_register_index_test: RuntimeError void_block_return_test/00: MissingCompileTimeError void_type_usage_test/conditional2_argument: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. -void_type_usage_test/conditional2_conditional: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/conditional2_dynamic_init: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. -void_type_usage_test/conditional2_for: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/conditional2_literal_list_init: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/conditional2_literal_map_value_init: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/conditional2_literal_map_value_init2: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/conditional2_null_equals2: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. -void_type_usage_test/conditional2_parens: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/conditional2_return: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. -void_type_usage_test/conditional2_return_to_void: MissingCompileTimeError -void_type_usage_test/conditional2_stmt: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/conditional2_throw: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/conditional2_void_init: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/conditional2do_while: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/conditional2for_in: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/conditional2while: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/conditional3_argument: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. -void_type_usage_test/conditional3_conditional: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/conditional3_dynamic_init: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. -void_type_usage_test/conditional3_for: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/conditional3_literal_list_init: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/conditional3_literal_map_value_init: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/conditional3_literal_map_value_init2: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/conditional3_null_equals2: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. -void_type_usage_test/conditional3_parens: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/conditional3_return: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. -void_type_usage_test/conditional3_return_to_void: MissingCompileTimeError -void_type_usage_test/conditional3_stmt: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/conditional3_throw: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/conditional3_void_init: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/conditional_do_while: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/conditional_for_in: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. -void_type_usage_test/conditional_return_to_void: MissingCompileTimeError void_type_usage_test/conditional_while: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/global_null_equals2: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. void_type_usage_test/local_null_equals2: Crash # 'package:front_end/src/fasta/type_inference/type_schema_environment.dart': Failed assertion: line 214 pos 12: 'false': is not true. @@ -898,9 +887,6 @@ vm/uint32_shift_test: RuntimeError vm/unaligned_integer_access_literal_index_test: RuntimeError vm/unaligned_integer_access_register_index_test: RuntimeError void_block_return_test/00: MissingCompileTimeError -void_type_usage_test/conditional2_return_to_void: MissingCompileTimeError -void_type_usage_test/conditional3_return_to_void: MissingCompileTimeError -void_type_usage_test/conditional_return_to_void: MissingCompileTimeError wrong_number_type_arguments_test/01: MissingCompileTimeError wrong_number_type_arguments_test/none: Pass diff --git a/tests/language_2/language_2_dartdevc.status b/tests/language_2/language_2_dartdevc.status index 1285c547d81..76aec8ead2f 100644 --- a/tests/language_2/language_2_dartdevc.status +++ b/tests/language_2/language_2_dartdevc.status @@ -84,7 +84,6 @@ invalid_type_argument_count_test/01: MissingCompileTimeError invalid_type_argument_count_test/02: MissingCompileTimeError invalid_type_argument_count_test/03: MissingCompileTimeError invalid_type_argument_count_test/04: MissingCompileTimeError -issue15606_test/none: CompileTimeError issue31596_implement_covariant_test: CompileTimeError issue31596_override_test/01: CompileTimeError issue31596_override_test/02: CompileTimeError @@ -203,78 +202,51 @@ void_type_callbacks_test/01: MissingCompileTimeError void_type_function_types_test/none: CompileTimeError # Issue 30514 void_type_override_test/02: MissingCompileTimeError void_type_override_test/03: MissingCompileTimeError -void_type_usage_test/call_conditional: MissingCompileTimeError void_type_usage_test/call_literal_list_init: MissingCompileTimeError void_type_usage_test/call_literal_map_key_init: MissingCompileTimeError void_type_usage_test/call_literal_map_value_init: MissingCompileTimeError void_type_usage_test/call_void_init: MissingCompileTimeError -void_type_usage_test/conditional2_conditional: MissingCompileTimeError -void_type_usage_test/conditional2_for: MissingCompileTimeError void_type_usage_test/conditional2_literal_list_init: MissingCompileTimeError void_type_usage_test/conditional2_literal_map_value_init: MissingCompileTimeError void_type_usage_test/conditional2_null_equals2: MissingCompileTimeError -void_type_usage_test/conditional2_parens: MissingCompileTimeError -void_type_usage_test/conditional2_return: MissingCompileTimeError -void_type_usage_test/conditional2_return_to_void: MissingCompileTimeError -void_type_usage_test/conditional2_stmt: MissingCompileTimeError void_type_usage_test/conditional2_void_init: MissingCompileTimeError -void_type_usage_test/conditional3_conditional: MissingCompileTimeError -void_type_usage_test/conditional3_for: MissingCompileTimeError void_type_usage_test/conditional3_literal_list_init: MissingCompileTimeError void_type_usage_test/conditional3_literal_map_value_init: MissingCompileTimeError void_type_usage_test/conditional3_null_equals2: MissingCompileTimeError -void_type_usage_test/conditional3_parens: MissingCompileTimeError -void_type_usage_test/conditional3_return: MissingCompileTimeError -void_type_usage_test/conditional3_return_to_void: MissingCompileTimeError -void_type_usage_test/conditional3_stmt: MissingCompileTimeError void_type_usage_test/conditional3_void_init: MissingCompileTimeError -void_type_usage_test/conditional_conditional: MissingCompileTimeError -void_type_usage_test/conditional_for: MissingCompileTimeError void_type_usage_test/conditional_literal_list_init: MissingCompileTimeError void_type_usage_test/conditional_literal_map_value_init: MissingCompileTimeError void_type_usage_test/conditional_null_equals2: MissingCompileTimeError -void_type_usage_test/conditional_parens: MissingCompileTimeError -void_type_usage_test/conditional_return: MissingCompileTimeError -void_type_usage_test/conditional_return_to_void: MissingCompileTimeError -void_type_usage_test/conditional_stmt: MissingCompileTimeError void_type_usage_test/conditional_void_init: MissingCompileTimeError -void_type_usage_test/final_local_conditional: MissingCompileTimeError void_type_usage_test/final_local_for_in2: MissingCompileTimeError void_type_usage_test/final_local_literal_list_init: MissingCompileTimeError void_type_usage_test/final_local_literal_map_key_init: MissingCompileTimeError void_type_usage_test/final_local_literal_map_value_init: MissingCompileTimeError void_type_usage_test/final_local_void_init: MissingCompileTimeError -void_type_usage_test/global_conditional: MissingCompileTimeError void_type_usage_test/global_literal_list_init: MissingCompileTimeError void_type_usage_test/global_literal_map_key_init: MissingCompileTimeError void_type_usage_test/global_literal_map_value_init: MissingCompileTimeError void_type_usage_test/global_void_init: MissingCompileTimeError -void_type_usage_test/instance2_conditional: MissingCompileTimeError void_type_usage_test/instance2_literal_list_init: MissingCompileTimeError void_type_usage_test/instance2_literal_map_key_init: MissingCompileTimeError void_type_usage_test/instance2_literal_map_value_init: MissingCompileTimeError void_type_usage_test/instance2_void_init: MissingCompileTimeError -void_type_usage_test/instance3_conditional: MissingCompileTimeError void_type_usage_test/instance3_literal_list_init: MissingCompileTimeError void_type_usage_test/instance3_literal_map_key_init: MissingCompileTimeError void_type_usage_test/instance3_literal_map_value_init: MissingCompileTimeError void_type_usage_test/instance3_void_init: MissingCompileTimeError -void_type_usage_test/instance_conditional: MissingCompileTimeError void_type_usage_test/instance_literal_list_init: MissingCompileTimeError void_type_usage_test/instance_literal_map_key_init: MissingCompileTimeError void_type_usage_test/instance_literal_map_value_init: MissingCompileTimeError void_type_usage_test/instance_void_init: MissingCompileTimeError -void_type_usage_test/local_conditional: MissingCompileTimeError void_type_usage_test/local_literal_list_init: MissingCompileTimeError void_type_usage_test/local_literal_map_key_init: MissingCompileTimeError void_type_usage_test/local_literal_map_value_init: MissingCompileTimeError void_type_usage_test/local_void_init: MissingCompileTimeError -void_type_usage_test/param_conditional: MissingCompileTimeError void_type_usage_test/param_literal_list_init: MissingCompileTimeError void_type_usage_test/param_literal_map_key_init: MissingCompileTimeError void_type_usage_test/param_literal_map_value_init: MissingCompileTimeError void_type_usage_test/param_void_init: MissingCompileTimeError -void_type_usage_test/paren_conditional: MissingCompileTimeError void_type_usage_test/paren_literal_list_init: MissingCompileTimeError void_type_usage_test/paren_literal_map_key_init: MissingCompileTimeError void_type_usage_test/paren_literal_map_value_init: MissingCompileTimeError @@ -546,9 +518,6 @@ type_variable_bounds_test/06: MissingCompileTimeError type_variable_bounds_test/08: MissingCompileTimeError type_variable_bounds_test/11: MissingCompileTimeError void_block_return_test/00: MissingCompileTimeError -void_type_usage_test/conditional2_return_to_void: MissingCompileTimeError, Crash -void_type_usage_test/conditional3_return_to_void: MissingCompileTimeError, Crash -void_type_usage_test/conditional_return_to_void: MissingCompileTimeError, Crash wrong_number_type_arguments_test/01: MissingCompileTimeError [ $compiler == dartdevk && $checked ] diff --git a/tests/language_2/language_2_kernel.status b/tests/language_2/language_2_kernel.status index cdaf95b3107..9ba53845a27 100644 --- a/tests/language_2/language_2_kernel.status +++ b/tests/language_2/language_2_kernel.status @@ -354,7 +354,6 @@ void_type_function_types_test/08: MissingCompileTimeError # Issue 32804 void_type_override_test/03: MissingCompileTimeError # Issue 32804 void_type_usage_test/call_argument: MissingCompileTimeError # Issue 32804 void_type_usage_test/call_cascade: MissingCompileTimeError # Issue 32804 -void_type_usage_test/call_conditional: MissingCompileTimeError # Issue 32804 void_type_usage_test/call_do_while: MissingCompileTimeError # Issue 32804 void_type_usage_test/call_dynamic_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/call_for_in: MissingCompileTimeError # Issue 32804 @@ -372,53 +371,40 @@ void_type_usage_test/call_toString: MissingCompileTimeError # Issue 32804 void_type_usage_test/call_void_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/call_while: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional2_argument: MissingCompileTimeError # Issue 32804 -void_type_usage_test/conditional2_conditional: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional2_dynamic_init: MissingCompileTimeError # Issue 32804 -void_type_usage_test/conditional2_for: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional2_literal_list_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional2_literal_map_value_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional2_literal_map_value_init2: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional2_null_equals2: MissingCompileTimeError # Issue 32804 -void_type_usage_test/conditional2_parens: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional2_return: MissingCompileTimeError # Issue 32804 -void_type_usage_test/conditional2_stmt: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional2_throw: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional2_void_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional2do_while: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional2for_in: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional2while: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional3_argument: MissingCompileTimeError # Issue 32804 -void_type_usage_test/conditional3_conditional: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional3_dynamic_init: MissingCompileTimeError # Issue 32804 -void_type_usage_test/conditional3_for: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional3_literal_list_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional3_literal_map_value_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional3_literal_map_value_init2: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional3_null_equals2: MissingCompileTimeError # Issue 32804 -void_type_usage_test/conditional3_parens: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional3_return: MissingCompileTimeError # Issue 32804 -void_type_usage_test/conditional3_stmt: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional3_throw: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional3_void_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional_argument: MissingCompileTimeError # Issue 32804 -void_type_usage_test/conditional_conditional: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional_do_while: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional_dynamic_init: MissingCompileTimeError # Issue 32804 -void_type_usage_test/conditional_for: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional_for_in: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional_literal_list_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional_literal_map_value_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional_literal_map_value_init2: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional_null_equals2: MissingCompileTimeError # Issue 32804 -void_type_usage_test/conditional_parens: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional_return: MissingCompileTimeError # Issue 32804 -void_type_usage_test/conditional_stmt: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional_throw: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional_void_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/conditional_while: MissingCompileTimeError # Issue 32804 void_type_usage_test/final_local_argument: MissingCompileTimeError # Issue 32804 void_type_usage_test/final_local_cascade: MissingCompileTimeError # Issue 32804 -void_type_usage_test/final_local_conditional: MissingCompileTimeError # Issue 32804 void_type_usage_test/final_local_do_while: MissingCompileTimeError # Issue 32804 void_type_usage_test/final_local_dynamic_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/final_local_for_in: MissingCompileTimeError # Issue 32804 @@ -437,7 +423,6 @@ void_type_usage_test/final_local_void_init: MissingCompileTimeError # Issue 3280 void_type_usage_test/final_local_while: MissingCompileTimeError # Issue 32804 void_type_usage_test/global_argument: MissingCompileTimeError # Issue 32804 void_type_usage_test/global_cascade: MissingCompileTimeError # Issue 32804 -void_type_usage_test/global_conditional: MissingCompileTimeError # Issue 32804 void_type_usage_test/global_do_while: MissingCompileTimeError # Issue 32804 void_type_usage_test/global_dynamic_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/global_for_in: MissingCompileTimeError # Issue 32804 @@ -456,7 +441,6 @@ void_type_usage_test/global_void_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/global_while: MissingCompileTimeError # Issue 32804 void_type_usage_test/instance2_argument: MissingCompileTimeError # Issue 32804 void_type_usage_test/instance2_cascade: MissingCompileTimeError # Issue 32804 -void_type_usage_test/instance2_conditional: MissingCompileTimeError # Issue 32804 void_type_usage_test/instance2_do_while: MissingCompileTimeError # Issue 32804 void_type_usage_test/instance2_dynamic_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/instance2_for_in: MissingCompileTimeError # Issue 32804 @@ -475,7 +459,6 @@ void_type_usage_test/instance2_void_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/instance2_while: MissingCompileTimeError # Issue 32804 void_type_usage_test/instance3_argument: MissingCompileTimeError # Issue 32804 void_type_usage_test/instance3_cascade: MissingCompileTimeError # Issue 32804 -void_type_usage_test/instance3_conditional: MissingCompileTimeError # Issue 32804 void_type_usage_test/instance3_do_while: MissingCompileTimeError # Issue 32804 void_type_usage_test/instance3_dynamic_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/instance3_for_in: MissingCompileTimeError # Issue 32804 @@ -494,7 +477,6 @@ void_type_usage_test/instance3_void_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/instance3_while: MissingCompileTimeError # Issue 32804 void_type_usage_test/instance_argument: MissingCompileTimeError # Issue 32804 void_type_usage_test/instance_cascade: MissingCompileTimeError # Issue 32804 -void_type_usage_test/instance_conditional: MissingCompileTimeError # Issue 32804 void_type_usage_test/instance_do_while: MissingCompileTimeError # Issue 32804 void_type_usage_test/instance_dynamic_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/instance_for_in: MissingCompileTimeError # Issue 32804 @@ -513,7 +495,6 @@ void_type_usage_test/instance_void_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/instance_while: MissingCompileTimeError # Issue 32804 void_type_usage_test/local_argument: MissingCompileTimeError # Issue 32804 void_type_usage_test/local_cascade: MissingCompileTimeError # Issue 32804 -void_type_usage_test/local_conditional: MissingCompileTimeError # Issue 32804 void_type_usage_test/local_do_while: MissingCompileTimeError # Issue 32804 void_type_usage_test/local_dynamic_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/local_for_in: MissingCompileTimeError # Issue 32804 @@ -532,7 +513,6 @@ void_type_usage_test/local_void_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/local_while: MissingCompileTimeError # Issue 32804 void_type_usage_test/param_argument: MissingCompileTimeError # Issue 32804 void_type_usage_test/param_cascade: MissingCompileTimeError # Issue 32804 -void_type_usage_test/param_conditional: MissingCompileTimeError # Issue 32804 void_type_usage_test/param_do_while: MissingCompileTimeError # Issue 32804 void_type_usage_test/param_dynamic_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/param_for_in: MissingCompileTimeError # Issue 32804 @@ -551,7 +531,6 @@ void_type_usage_test/param_void_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/param_while: MissingCompileTimeError # Issue 32804 void_type_usage_test/paren_argument: MissingCompileTimeError # Issue 32804 void_type_usage_test/paren_cascade: MissingCompileTimeError # Issue 32804 -void_type_usage_test/paren_conditional: MissingCompileTimeError # Issue 32804 void_type_usage_test/paren_do_while: MissingCompileTimeError # Issue 32804 void_type_usage_test/paren_dynamic_init: MissingCompileTimeError # Issue 32804 void_type_usage_test/paren_for_in: MissingCompileTimeError # Issue 32804 @@ -817,9 +796,6 @@ vm/closure_memory_retention_test: Skip # KernelVM bug: Hits OOM vm/regress_29145_test: Skip # Issue 29145 vm/type_cast_vm_test: RuntimeError void_block_return_test/00: MissingCompileTimeError -void_type_usage_test/conditional2_return_to_void: MissingCompileTimeError -void_type_usage_test/conditional3_return_to_void: MissingCompileTimeError -void_type_usage_test/conditional_return_to_void: MissingCompileTimeError web_int_literals_test/*: SkipByDesign # Test applies only to JavaScript targets wrong_number_type_arguments_test/01: MissingCompileTimeError wrong_number_type_arguments_test/none: Pass @@ -1188,9 +1164,6 @@ vm/type_vm_test/30: MissingRuntimeError vm/type_vm_test/31: MissingRuntimeError vm/type_vm_test/32: MissingRuntimeError void_block_return_test/00: MissingCompileTimeError -void_type_usage_test/conditional2_return_to_void: MissingCompileTimeError -void_type_usage_test/conditional3_return_to_void: MissingCompileTimeError -void_type_usage_test/conditional_return_to_void: MissingCompileTimeError wrong_number_type_arguments_test/01: MissingCompileTimeError [ $compiler == dartkp && $minified ] @@ -1425,9 +1398,6 @@ redirecting_factory_infinite_steps_test/01: MissingCompileTimeError redirecting_factory_malbounded_test/01: MissingCompileTimeError type_promotion_logical_and_test/01: MissingCompileTimeError void_block_return_test/00: MissingCompileTimeError -void_type_usage_test/conditional2_return_to_void: MissingCompileTimeError -void_type_usage_test/conditional3_return_to_void: MissingCompileTimeError -void_type_usage_test/conditional_return_to_void: MissingCompileTimeError wrong_number_type_arguments_test/01: MissingCompileTimeError [ $fasta && !$strong ] diff --git a/tests/language_2/void_type_usage_test.dart b/tests/language_2/void_type_usage_test.dart index 5ba054738ea..8d253506b78 100644 --- a/tests/language_2/void_type_usage_test.dart +++ b/tests/language_2/void_type_usage_test.dart @@ -8,7 +8,7 @@ void use(dynamic x) { } Object testVoidParam(void x) { x; //# param_stmt: ok - true ? x : x; //# param_conditional: compile-time error + true ? x : x; //# param_conditional: ok for (x; false; x) {} //# param_for: ok use(x); //# param_argument: compile-time error use(x as Object); //# param_as: ok @@ -40,7 +40,7 @@ dynamic testVoidParamDynamic(void x) { Object testVoidCall(void f()) { f(); //# call_stmt: ok - true ? f() : f(); //# call_conditional: compile-time error + true ? f() : f(); //# call_conditional: ok for (f(); false; f()) {} //# call_for: ok use(f()); //# call_argument: compile-time error use(f() as Object); //# call_as: ok @@ -72,7 +72,7 @@ Object testVoidLocal() { void x; x = 42; //# local_assign: ok x; //# local_stmt: ok - true ? x : x; //# local_conditional: compile-time error + true ? x : x; //# local_conditional: ok for (x; false; x) {} //# local_for: ok use(x); //# local_argument: compile-time error use(x as Object); //# local_as: ok @@ -107,7 +107,7 @@ Object testVoidFinalLocal() { final void x = null; x = 42; //# final_local_assign: compile-time error x; //# final_local_stmt: ok - true ? x : x; //# final_local_conditional: compile-time error + true ? x : x; //# final_local_conditional: ok for (x; false; x) {} //# final_local_for: ok use(x); //# final_local_argument: compile-time error use(x as Object); //# final_local_as: ok @@ -141,7 +141,7 @@ dynamic testVoidFinalLocalDynamic() { void global; Object testVoidGlobal() { global; //# global_stmt: ok - true ? global : global; //# global_conditional: compile-time error + true ? global : global; //# global_conditional: ok for (global; false; global) {} //# global_for: ok use(global); //# global_argument: compile-time error use(global as Object); //# global_as: ok @@ -171,12 +171,12 @@ dynamic testVoidGlobalDynamic() { return global; //# global_return_dynamic: ok } -testVoidConditional() { +Object testVoidConditional() { void x; - (true ? x : x); //# conditional_parens: compile-time error - true ? x : x; //# conditional_stmt: compile-time error - true ? true ? x : x : true ? x : x; //# conditional_conditional: compile-time error - for (true ? x : x; false; true ? x : x) {} //# conditional_for: compile-time error + (true ? x : x); //# conditional_parens: ok + true ? x : x; //# conditional_stmt: ok + true ? true ? x : x : true ? x : x; //# conditional_conditional: ok + for (true ? x : x; false; true ? x : x) {} //# conditional_for: ok use(true ? x : x); //# conditional_argument: compile-time error void y = true ? x : x; //# conditional_void_init: compile-time error dynamic z = true ? x : x; //# conditional_dynamic_init: compile-time error @@ -184,16 +184,16 @@ testVoidConditional() { [true ? x : x]; //# conditional_literal_list_init: compile-time error var m1 = {4: true ? x : x}; //# conditional_literal_map_value_init: compile-time error Map m3 = {4: true ? x : x}; //# conditional_literal_map_value_init2: compile-time error - null ?? true ? x : x; //# conditional_null_equals2: compile-time error + null ?? (true ? x : x); //# conditional_null_equals2: compile-time error return true ? x : x; //# conditional_return: compile-time error while (true ? x : x) {}; //# conditional_while: compile-time error do {} while (true ? x : x); //# conditional_do_while: compile-time error for (var v in true ? x : x) {} //# conditional_for_in: compile-time error - (true ? 499 : x); //# conditional2_parens: compile-time error - true ? 499 : x; //# conditional2_stmt: compile-time error - true ? true ? 499 : x : true ? 499 : x; //# conditional2_conditional: compile-time error - for (true ? 499 : x; false; true ? 499 : x) {} //# conditional2_for: compile-time error + (true ? 499 : x); //# conditional2_parens: ok + true ? 499 : x; //# conditional2_stmt: ok + true ? true ? 499 : x : true ? 499 : x; //# conditional2_conditional: ok + for (true ? 499 : x; false; true ? 499 : x) {} //# conditional2_for: ok use(true ? 499 : x); //# conditional2_argument: compile-time error void y2 = true ? 499 : x; //# conditional2_void_init: compile-time error dynamic z2 = true ? 499 : x; //# conditional2_dynamic_init: compile-time error @@ -201,16 +201,16 @@ testVoidConditional() { [true ? 499 : x]; //# conditional2_literal_list_init: compile-time error var m12 = {4: true ? 499 : x}; //# conditional2_literal_map_value_init: compile-time error Map m32 = {4: true ? 499 : x}; //# conditional2_literal_map_value_init2: compile-time error - null ?? true ? 499 : x; //# conditional2_null_equals2: compile-time error + null ?? (true ? 499 : x); //# conditional2_null_equals2: compile-time error return true ? 499 : x; //# conditional2_return: compile-time error while (true ? 499 : x) {}; //# conditional2while: compile-time error do {} while (true ? 499 : x); //# conditional2do_while: compile-time error for (var v in true ? 499 : x) {} //# conditional2for_in: compile-time error - (true ? x : 499); //# conditional3_parens: compile-time error - true ? x : 499; //# conditional3_stmt: compile-time error - true ? true ? x : 499 : true ? x : 499; //# conditional3_conditional: compile-time error - for (true ? x : 499; false; true ? x : 499) {} //# conditional3_for: compile-time error + (true ? x : 499); //# conditional3_parens: ok + true ? x : 499; //# conditional3_stmt: ok + true ? true ? x : 499 : true ? x : 499; //# conditional3_conditional: ok + for (true ? x : 499; false; true ? x : 499) {} //# conditional3_for: ok use(true ? x : 499); //# conditional3_argument: compile-time error void y3 = true ? x : 499; //# conditional3_void_init: compile-time error dynamic z3 = true ? x : 499; //# conditional3_dynamic_init: compile-time error @@ -218,13 +218,20 @@ testVoidConditional() { [true ? x : 499]; //# conditional3_literal_list_init: compile-time error var m13 = {4: true ? x : 499 }; //# conditional3_literal_map_value_init: compile-time error Map m33 = {4: true ? x : 499 }; //# conditional3_literal_map_value_init2: compile-time error - null ?? true ? x : 499; //# conditional3_null_equals2: compile-time error + null ?? (true ? x : 499); //# conditional3_null_equals2: compile-time error return true ? x : 499; //# conditional3_return: compile-time error while (true ? x : 499) {}; //# conditional_while: compile-time error do {} while (true ? x : 499); //# conditional_do_while: compile-time error for (var v in true ? x : 499) {} //# conditional_for_in: compile-time error } +dynamic testVoidConditionalDynamic() { + void x; + return true ? x : x; //# conditional_return_dynamic: ok + return true ? 499 : x; //# conditional2_return_dynamic: ok + return true ? x : 499; //# conditional3_return_dynamic: ok +} + class A { T x; @@ -258,7 +265,7 @@ Object testInstanceField() { A a = new A(); a.x = 499; //# field_assign: ok a.x; //# instance_stmt: ok - true ? a.x : a.x; //# instance_conditional: compile-time error + true ? a.x : a.x; //# instance_conditional: ok for (a.x; false; a.x) {} //# instance_for: ok use(a.x); //# instance_argument: compile-time error use(a.x as Object); //# instance_as: ok @@ -285,7 +292,7 @@ Object testInstanceField() { B b = new B(); b.x = 42; //# field_assign2: ok b.x; //# instance2_stmt: ok - true ? b.x : b.x; //# instance2_conditional: compile-time error + true ? b.x : b.x; //# instance2_conditional: ok for (b.x; false; b.x) {} //# instance2_for: ok use(b.x); //# instance2_argument: compile-time error use(b.x as Object); //# instance2_as: ok @@ -313,7 +320,7 @@ Object testInstanceField() { C c = new C(); c.x = 32; //# setter_assign: ok c.x; //# instance3_stmt: ok - true ? c.x : c.x; //# instance3_conditional: compile-time error + true ? c.x : c.x; //# instance3_conditional: ok for (c.x; false; c.x) {} //# instance3_for: ok use(c.x); //# instance3_argument: compile-time error use(c.x as Object); //# instance3_as: ok @@ -353,7 +360,7 @@ dynamic testInstanceFieldDynamic() { Object testParenthesized() { void x; (x); //# paren_stmt: ok - true ? (x) : (x); //# paren_conditional: compile-time error + true ? (x) : (x); //# paren_conditional: ok for ((x); false; (x)) {} //# paren_for: ok use((x)); //# paren_argument: compile-time error use((x) as Object); //# paren_as: ok @@ -393,9 +400,9 @@ void testReturnToVoid(void x, void f()) { return y; //# local_return_to_void: ok return z; //# final_local_return_to_void: ok return global; //# global_return_to_void: ok - return true ? x : x; //# conditional_return_to_void: compile-time error - return true ? 499 : x; //# conditional2_return_to_void: compile-time error - return true ? x : 499; //# conditional3_return_to_void: compile-time error + return true ? x : x; //# conditional_return_to_void: ok + return true ? 499 : x; //# conditional2_return_to_void: ok + return true ? x : 499; //# conditional3_return_to_void: ok return a.x; //# instance_return_to_void: ok return b.x; //# instance2_return_to_void: ok return c.x; //# instance3_return_to_void: ok