languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 09:31:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Issue 53861. Use specific element kind name instead of generic 'class'.

Browse source 
Bug: https://github.com/dart-lang/sdk/issues/53861
Change-Id: Iea029c612da0c2556ecb29500f30573014f5b7ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332366
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This commit is contained in:
Konstantin Shcheglov 2023-10-26 20:31:53 +00:00 committed by Commit Queue
parent 716b127a1a
commit cbc21d2738
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
pkg/analyzer/lib/src/generated/resolver.dart
View file

@ -5414,11 +5414,12 @@ class _WhyNotPromotedVisitor
void addConflictMessage(
{required Element conflictingElement,
required String kind,
required Element class_,
required Element enclosingElement,
required NonPromotionDocumentationLink link}) {
var className = class_.name;
var enclosingKindName = enclosingElement.kind.displayName;
var enclosingName = enclosingElement.name;
var message = "'$propertyName' couldn't be promoted because there is a "
"conflicting $kind in class '$className'";
"conflicting $kind in $enclosingKindName '$enclosingName'";
var nonSyntheticElement = conflictingElement.nonSynthetic;
messages.add(DiagnosticMessageImpl(
filePath: nonSyntheticElement.source!.fullName,
@ -5433,7 +5434,7 @@ class _WhyNotPromotedVisitor
addConflictMessage(
conflictingElement: field,
kind: 'non-promotable field',
class_: field.enclosingElement,
enclosingElement: field.enclosingElement,
link:
NonPromotionDocumentationLink.conflictingNonPromotableField);
}
@ -5441,14 +5442,14 @@ class _WhyNotPromotedVisitor
addConflictMessage(
conflictingElement: getter,
kind: 'getter',
class_: getter.enclosingElement,
enclosingElement: getter.enclosingElement,
link: NonPromotionDocumentationLink.conflictingGetter);
}
for (var nsmClass in fieldNameInfo.conflictingNsmClasses) {
addConflictMessage(
conflictingElement: nsmClass,
kind: 'noSuchMethod forwarder',
class_: nsmClass,
enclosingElement: nsmClass,
link: NonPromotionDocumentationLink
.conflictingNoSuchMethodForwarder);
}