languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 00:13:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tidy some comments in analyzer

Browse source 
* DirectiveResolver was removed.
* There is no more nameScope parameter on ResolverVisitor.

Change-Id: I3617538366c21407fd841bea0cddb2ce7b3ea536
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240500
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
This commit is contained in:
Sam Rawlins 2022-04-07 22:25:00 +00:00 committed by Commit Bot
parent 0c307c695c
commit ca9ba196c8
3 changed files with 2 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart
View file

@ -739,8 +739,6 @@ class LibraryAnalyzer {
for (var directive in directivesToResolve) {
directive.element = _libraryElement;
}
// TODO(scheglov) remove DirectiveResolver class
}
void _resolveFile(FileState file, CompilationUnit unit) {

2
pkg/analyzer/lib/src/dart/micro/library_analyzer.dart
View file

@ -665,8 +665,6 @@ class LibraryAnalyzer {
for (var directive in directivesToResolve) {
directive.element = _libraryElement;
}
// TODO(scheglov) remove DirectiveResolver class
}
void _resolveFile({

7
pkg/analyzer/lib/src/generated/resolver.dart
View file

@ -258,10 +258,7 @@ class ResolverVisitor extends ThrowingAstVisitor<void>
/// unit containing the node being visited. The [typeProvider] is the object
/// used to access the types from the core library. The [errorListener] is the
/// error listener that will be informed of any errors that are found during
/// resolution. The [nameScope] is the scope used to resolve identifiers in
/// the node that will first be visited. If `null` or unspecified, a new
/// [LibraryScope] will be created based on [definingLibrary] and
/// [typeProvider].
/// resolution.
///
/// TODO(paulberry): make [featureSet] a required parameter (this will be a
/// breaking change).
@ -2910,7 +2907,7 @@ class ScopeResolverVisitor extends UnifyingAstVisitor<void> {
/// [definingLibrary] is the element for the library containing the node being
/// visited.
/// [source] is the source representing the compilation unit containing the
/// node being visited
/// node being visited.
/// [typeProvider] is the object used to access the types from the core
/// library.
/// [errorListener] is the error listener that will be informed of any errors