languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 09:58:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "[infra] Remove copy of jsshell to legacy location"

Browse source 
This reverts commit 27d3969eae.

Reason for revert: 
The benchmark-linux-try bot started failing after this CL landed, see:

https://ci.chromium.org/ui/p/dart/builders/try/benchmark-linux-try/57377/overview

https://ci.chromium.org/ui/p/dart/builders/try/benchmark-linux-try/57390/overview

Likely there is still a dependency on the legacy location that needs to be cleaned up.

Original change's description:
> [infra] Remove copy of jsshell to legacy location
>
> Fixes: b/186078239
> Change-Id: I963af391e67734b9dc130258a871f9b0a2966858
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214047
> Reviewed-by: Alexander Thomas <athom@google.com>

TBR=whesse@google.com,athom@google.com

Change-Id: I89702406796286c8fef5def0f88364c5b6709ca1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/227360
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
This commit is contained in:
Sigmund Cherem 2022-01-10 19:58:05 +00:00 committed by Commit Bot
parent 7c987d0afa
commit ca5bc75ce7
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
DEPS
View file

@ -226,6 +226,15 @@ deps = {
"condition": "checkout_javascript_engines",
"dep_type": "cipd",
},
# TODO(b/186078239): remove this copy to the old location
Var("dart_root") + "/third_party/firefox_jsshell/linux/jsshell": {
"packages": [{
"package": "dart/third_party/jsshell/linux-amd64",
"version": Var("jsshell_tag"),
}],
"condition": "checkout_javascript_engines",
"dep_type": "cipd",
},
Var("dart_root") + "/third_party/devtools": {
"packages": [{
"package": "dart/third_party/flutter/devtools",