languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-15 23:49:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

[vm] Attempt to avoid timeouts / flakiness of vm/dart_2/isolates/reload_many_isolates_live_and_die_test

Browse source 
Closes https://github.com/dart-lang/sdk/issues/48847

TEST=Addresses flakiness, timeouts of the mentioned test.

Change-Id: I91472c903e1f9f595c35217ac4c7e5613044fabb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242107
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
This commit is contained in:
Martin Kustermann 2022-04-22 15:23:29 +00:00 committed by Commit Bot
parent 2fd661d4fa
commit ca4ad74b53
3 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
runtime/tests/vm/dart_2/isolates/reload_many_isolates_live_and_die_test.dart
View file

@ -10,7 +10,7 @@ import 'package:expect/expect.dart';
import 'reload_utils.dart';
const N = 20;
final N = runningInSimulator ? 2 : 20;
main() async {
if (!currentVmSupportsReload) return;

5
runtime/tests/vm/dart_2/isolates/reload_utils.dart
View file

@ -20,6 +20,11 @@ bool get currentVmSupportsReload {
!executable.contains('dart_precompiled_runtime');
}
bool get runningInSimulator {
final executable = Platform.executable;
return executable.contains('SIM');
}
final includeIn = RegExp(r'//\s+@include-in-reload-([0-9]+)([+]?)\s*$');
Future<List<String>> generateDills(String tempDir, String testDartFile) async {

2
runtime/tests/vm/vm.status
View file

@ -37,6 +37,7 @@ dart_2/hash_map_probes_limit_test: Pass, Slow # Test includes large program comp
dart_2/isolates/*: Pass, Slow # Tests use many isolates and take a longer time.
dart_2/isolates/concurrency_stress_sanity_test: Pass, Slow # Spawns subprocesses
dart_2/isolates/fast_object_copy_test: Pass, Slow # Slow due to doing a lot of transitive object copies.
dart_2/isolates/reload_many_isolates_live_and_die_test: Pass, Slow # Launches subprocesses, makes 2 kernel compilations and use reload.
dart_2/minimal_kernel_test: Pass, Slow # Spawns several subprocesses
dart_2/null_safety_autodetection_in_kernel_compiler_test: Pass, Slow # Spawns several subprocesses
dart_2/print_object_layout_test: Pass, Slow # Spawns several subprocesses
@ -280,6 +281,7 @@ dart_2/snapshot_version_test: RuntimeError # Please triage.
dart/data_uri_spawn_test: Skip # Timeout
dart/kernel_determinism_test: SkipSlow
dart_2/data_uri_spawn_test: Skip # Timeout
dart_2/isolates/reload_many_isolates_live_and_die_test: SkipSlow # The test itself does reloading of subprocesses.
dart_2/kernel_determinism_test: SkipSlow
[ $compiler != dartk && $compiler != none ]