languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 01:45:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

[dart2js/kernel] Fix poor code with nested List.generate

Browse source 
Cloning of InstanceInvocation kernel ast nodes was dropping the
isInvariant and isBoundSafe flags, causing the nested List.generate
expansion to not be as well optimized. `-O3` and `-O4` were 'hiding'
the problem by removing the checks anyway.

Change-Id: Id20f2eb4ef5396691a2dd5cbdd847e2d361a21d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209442
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
This commit is contained in:
Stephen Adams 2021-08-09 20:38:50 +00:00 committed by commit-bot@chromium.org
parent 3e774fba0f
commit c9ebc7c13f
5 changed files with 13 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
pkg/compiler/lib/src/ssa/ssa_tracer.dart
View file

@ -370,8 +370,15 @@ class HInstructionStringifier implements HVisitor<String> {
String target = "$receiver.$name";
int offset = HInvoke.ARGUMENTS_OFFSET;
List arguments = invoke.inputs.sublist(offset);
final attributes = {
if (invoke.isInvariant) 'Invariant',
if (invoke.isBoundsSafe) 'BoundSafe',
};
String attributesText = attributes.isEmpty ? '' : ' $attributes';
return handleGenericInvoke(kind, target, arguments) +
"(${invoke.receiverType})";
"(${invoke.receiverType})" +
attributesText;
}
@override

2
pkg/compiler/test/kernel/data/list_generate_2.dart.expect
View file

@ -13,7 +13,7 @@ static method main() → void {
final _in::JSArray<core::int*> _list = _in::JSArray::allocateGrowable<core::int*>(_length);
for (core::int i = 0; i.{core::num::<}(_length){(core::num) → core::bool}; i = i.{core::num::+}(1){(core::int) →* core::int}) {
core::int* i = i;
_list.{_in::JSArray::[]=}(i, i.{core::num::+}(1){(core::num*) →* core::int*}){(core::int, core::int*) → void};
_list.{_in::JSArray::[]=}{Invariant,BoundsSafe}(i, i.{core::num::+}(1){(core::num*) →* core::int*}){(core::int, core::int*) → void};
}
} =>_list){(core::int, core::List<core::int*>*) → void};
}

2
pkg/front_end/testcases/incremental/no_outline_change_22.yaml.world.1.expect
View file

@ -304,7 +304,7 @@ library from "org-dartlang-test:///main.dart" as main {
operator /*isNonNullableByDefault, from org-dartlang-sdk:///sdk/lib/collection/list.dart */ +(generic-covariant-impl dart.core::List<dart.core::int*> other) → dart.core::List<dart.core::int*>
return block {
final dart.core::List<dart.core::int*> #t5 = dart.core::List::of<dart.core::int*>(this);
#t5.{dart.core::List::addAll}(other){(dart.core::Iterable<dart.core::int*>) → void};
#t5.{dart.core::List::addAll}{Invariant}(other){(dart.core::Iterable<dart.core::int*>) → void};
} =>#t5;
method /*isNonNullableByDefault, from org-dartlang-sdk:///sdk/lib/collection/list.dart */ sublist(dart.core::int start, [dart.core::int? end = #C2]) → dart.core::List<dart.core::int*> {
dart.core::int listLength = this.{dart.core::List::length}{dart.core::int};

2
pkg/front_end/testcases/incremental/no_outline_change_22.yaml.world.2.expect
View file

@ -304,7 +304,7 @@ library from "org-dartlang-test:///main.dart" as main {
operator /*isNonNullableByDefault, from org-dartlang-sdk:///sdk/lib/collection/list.dart */ +(generic-covariant-impl dart.core::List<dart.core::int*> other) → dart.core::List<dart.core::int*>
return block {
final dart.core::List<dart.core::int*> #t5 = dart.core::List::of<dart.core::int*>(this);
#t5.{dart.core::List::addAll}(other){(dart.core::Iterable<dart.core::int*>) → void};
#t5.{dart.core::List::addAll}{Invariant}(other){(dart.core::Iterable<dart.core::int*>) → void};
} =>#t5;
method /*isNonNullableByDefault, from org-dartlang-sdk:///sdk/lib/collection/list.dart */ sublist(dart.core::int start, [dart.core::int? end = #C2]) → dart.core::List<dart.core::int*> {
dart.core::int listLength = this.{dart.core::List::length}{dart.core::int};

3
pkg/kernel/lib/clone.dart
View file

@ -677,7 +677,8 @@ class CloneVisitorNotMembers implements TreeVisitor<TreeNode> {
return new InstanceInvocation.byReference(
node.kind, clone(node.receiver), node.name, clone(node.arguments),
functionType: visitType(node.functionType) as FunctionType,
interfaceTargetReference: node.interfaceTargetReference);
interfaceTargetReference: node.interfaceTargetReference)
..flags = node.flags;
}
@override