Add warning and error markers to some tests

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2721203006 .
This commit is contained in:
Brian Wilkerson 2017-03-02 11:01:44 -08:00
parent 2ff4e1f15a
commit c5ad5ac72d
3 changed files with 10 additions and 10 deletions

View file

@ -10,7 +10,7 @@ class Base {
String value_;
String get value { return value_; }
String set value(String newValue) {
String set value(String newValue) { /// static warning
value_ = 'Base:$newValue';
}
}
@ -19,7 +19,7 @@ class Base {
class Derived extends Base {
Derived() : super() {}
String set value(String newValue) {
String set value(String newValue) { /// static warning
super.value = 'Derived:$newValue';
}
String get value { return super.value; }

View file

@ -13,11 +13,11 @@ foo1() {
var b = false;
var entered = false;
while (true) {
if (entered) return b;
if (entered) return b; /// static warning
b = 8 == a; // This expression should not be GVN'ed.
try {
a = 8;
return;
return; /// static warning
} finally {
b = 8 == a;
entered = true;
@ -32,12 +32,12 @@ foo2() {
var b = false;
var entered = false;
while (true) {
if (entered) return b;
if (entered) return b; /// static warning
b = 8 == a; // This expression should not be GVN'ed.
try {
a = 8;
doThrow();
return;
return; /// static warning
} catch(e) {
b = 8 == a;
entered = true;
@ -50,14 +50,14 @@ foo3() {
var b = false;
var entered = false;
while (true) {
if (entered) return b;
if (entered) return b; /// static warning
b = 8 == a; // This expression should not be GVN'ed.
try {
doThrow();
} catch(e) {
a = 8;
entered = true;
return;
return; /// static warning
} finally {
b = 8 == a;
entered = true;

View file

@ -13,12 +13,12 @@ foo1() {
var b = false;
var entered = false;
while (true) {
if (entered) return b;
if (entered) return b; /// static warning
b = 8 == a; // This expression should not be GVN'ed.
try {
try {
a = 8;
return;
return; /// static warning
} finally {
b = 8 == a;
entered = true;