languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-07-03 00:08:46 +00:00
Code Issues Projects Releases Wiki Activity

[ddc] Show "any" for type args of package js types

Browse Source 
Ensures that `toString()` of types that contain embedded js types 
will appear the same in the old and new runtime type systems.

Issue: https://github.com/dart-lang/sdk/issues/48585
Change-Id: I71ec0e13943281e745bcf05e10aa36d093cbc0c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/334003
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
This commit is contained in:
Nicholas Shahan 2023-11-06 22:13:17 +00:00 committed by Commit Queue
parent 57ece5b452
commit c50fcf8828
4 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
CHANGELOG.md
View File

@ -46,6 +46,13 @@
[lints-3-0]: https://pub.dev/packages/lints/changelog#300
#### Development JavaScript compiler (DDC)
- Type arguments of `package:js` interop types are now printed as `any` instead
of being omitted. This is simply a change to the textual representation of
package js types that have type arguments. These type arguments are still
completely ignored by the type system at runtime.
## 3.2.0
### Language

7
pkg/dev_compiler/lib/src/kernel/compiler.dart
View File

@ -3519,6 +3519,13 @@ class ProgramCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
? getLocalClassName(c)
: _emitJsNameWithoutGlobal(c);
if (jsName != null) {
if (type.typeArguments.isNotEmpty) {
// This does not handle the type arguments as such, it simply includes
// them in the textual representation of this type so you can see them
// when printed. They are not used as part of the type system at all.
jsName =
'$jsName<${type.typeArguments.map((_) => 'any').join(', ')}>';
}
typeRep = runtimeCall('packageJSType(#)', [js.escapedString(jsName)]);
}
}

4
tests/dartdevc/debugger/debugger_test_golden.txt
View File

@ -7091,7 +7091,7 @@ Value:
{
"style": "background-color: #d9edf7;color: black"
},
"Instance of 'TestGenericClass<ExampleJSClass, int>'"
"Instance of 'TestGenericClass<ExampleJSClass<any>, int>'"
]
-----------------------------------
Test: TestGenericClassJSInterop instance body
@ -7188,7 +7188,7 @@ Value:
{
"style": "background-color: #d9edf7;color: black"
},
"TestGenericClass<ExampleJSClass, int>"
"TestGenericClass<ExampleJSClass<any>, int>"
]
-----------------------------------
Test: TestGenericClassJSInterop definition formatting body

4
tests/dartdevc_2/debugger/debugger_test_golden.txt
View File

@ -7091,7 +7091,7 @@ Value:
{
"style": "background-color: #d9edf7;color: black"
},
"Instance of 'TestGenericClass<ExampleJSClass, int>'"
"Instance of 'TestGenericClass<ExampleJSClass<any>, int>'"
]
-----------------------------------
Test: TestGenericClassJSInterop instance body
@ -7188,7 +7188,7 @@ Value:
{
"style": "background-color: #d9edf7;color: black"
},
"TestGenericClass<ExampleJSClass, int>"
"TestGenericClass<ExampleJSClass<any>, int>"
]
-----------------------------------
Test: TestGenericClassJSInterop definition formatting body