languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 00:13:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[vm] Disable inlining of _StringBase._createOneByteString

Browse source 
If _StringBase._createOneByteString is inlined it becomes much slower
due to https://github.com/dart-lang/sdk/issues/37800.

This workaround improves Base64Encoder benchmark on ia32 in bytecode mode:

Base64Encoder(RunTime): 63.31 -> 46.7 us.

Issue: https://github.com/dart-lang/sdk/issues/37800
Change-Id: Ibcf5dc7bfd25bac0bd61a9dcb196c553c82f3dc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112647
Reviewed-by: Aart Bik <ajcbik@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
This commit is contained in:
Alexander Markov 2019-08-12 17:56:05 +00:00 committed by commit-bot@chromium.org
parent 92562dc5a5
commit c0d1dedd78
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
runtime/lib/string_patch.dart
View file

@ -219,6 +219,8 @@ abstract class _StringBase implements String {
return createFromCharCodes(charCodeList, 0, length, bits);
}
// Inlining is disabled as a workaround to http://dartbug.com/37800.
@pragma("vm:never-inline")
static String _createOneByteString(List<int> charCodes, int start, int len) {
// It's always faster to do this in Dart than to call into the runtime.
var s = _OneByteString._allocate(len);