languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 00:13:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[fasta] Fix bugs in incremental tests

Browse source 
This CL fixes errors in a few incremental tests.
The remaining (with a previous references to issue #31909) are not
related to incremental compilation, but also fail to fail on regular fasta.

Closes #31909.

Change-Id: I3c50a4cbfb926f8f74570523a10885e1bd28a94b
Reviewed-on: https://dart-review.googlesource.com/34801
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
This commit is contained in:
Jens Johansen 2018-01-16 14:47:32 +00:00 committed by commit-bot@chromium.org
parent 1bca76d012
commit beff8fdf23
4 changed files with 8 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/front_end/testcases/dartino/compile_time_error_004.incremental.yaml
View file

@ -6,7 +6,7 @@ main.dart.patch: |
// Reproduce a crash when a class has a bad hierarchy
<<<< {"messages":[],"hasCompileTimeError":1}
typedef A(C c);
==== {"messages":[],"hasCompileTimeError":1}
==== []
typedef A(Class c);
>>>>

6
pkg/front_end/testcases/dartino/compile_time_error_field_becomes_removed_function.incremental.yaml
View file

@ -8,11 +8,9 @@ main.dart.patch: |
class C {
<<<< {"messages":[],"hasCompileTimeError":1}
int sync*;
==== {"messages":[],"hasCompileTimeError":1}
// TODO(ahe): Should just expect [], no compile-time error
==== []
sync();
==== {"messages":[],"hasCompileTimeError":1}
// TODO(ahe): Should just expect [], no compile-time error
==== []
>>>>
}
main() {

3
pkg/front_end/testcases/dartino/fix_compile_time_error_in_field.incremental.yaml
View file

@ -9,8 +9,7 @@ main.dart.patch: |
class C {
<<<< {"messages":[],"hasCompileTimeError":1}
int sync*;
==== {"messages":[],"hasCompileTimeError":1}
// TODO(ahe): There's no compile-time error here
==== []
int sync;
>>>>
}

11
pkg/front_end/testcases/incremental.status
View file

@ -5,10 +5,7 @@
# Status file for the test suite ../test/fasta/incremental_test.dart.
dartino/change_in_part.incremental: Fail # Issue 31908 (parts aren't handled correctly)
dartino/compile_time_error_004.incremental: Fail # Issue 31909
dartino/compile_time_error_field_becomes_removed_function.incremental: Fail # Issue 31909
dartino/fix_compile_time_error_in_field.incremental: Fail # Issue 31909
dartino/override_field_with_method_conflict.incremental: Fail # Issue 31909
dartino/override_getter_with_method_conflict.incremental: Fail # Issue 31909
dartino/override_method_with_field_conflict.incremental: Fail # Issue 31909
dartino/override_method_with_getter_conflict.incremental: Fail # Issue 31909
dartino/override_field_with_method_conflict.incremental: Fail # These tests are the incremental version of tests like language_2/field_override* and language_2/override_field_method*
dartino/override_getter_with_method_conflict.incremental: Fail # These tests are the incremental version of tests like language_2/field_override* and language_2/override_field_method*
dartino/override_method_with_field_conflict.incremental: Fail # These tests are the incremental version of tests like language_2/field_override* and language_2/override_field_method*
dartino/override_method_with_getter_conflict.incremental: Fail # These tests are the incremental version of tests like language_2/field_override* and language_2/override_field_method*