languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-20 19:31:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Significantly reduce the timeout app_jit is given on the buildbot

Browse source 
Currently tests in the app_jit-debug configuration are given 16 minutes
timeout. This caused us to run into a global timeout of test.dart (it's
"debug timer" which is set to 10 minutes of inactivity).

Even the slowest tests run in the app_jit-debug configuration within around 1:30 m on the buildbot.

This CL changes the timeout from 16 minutes to 4 minutes.

R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2685303002 .
This commit is contained in:
Martin Kustermann 2017-02-10 12:56:44 +01:00
parent 2b77a7e6b8
commit be2942a279
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tools/testing/dart/compiler_configuration.dart
View file

@ -789,8 +789,8 @@ class Dart2AppSnapshotCompilerConfiguration extends CompilerConfiguration {
: super._subclass(isDebug: isDebug, isChecked: isChecked);
int computeTimeoutMultiplier() {
int multiplier = 2;
if (isDebug) multiplier *= 4;
int multiplier = 1;
if (isDebug) multiplier *= 2;
if (isChecked) multiplier *= 2;
return multiplier;
}

2
tools/testing/dart/test_runner.dart
View file

@ -3257,7 +3257,7 @@ class ProcessQueue {
eventFinishedTestCase(finishedTestCase);
}
}, onDone: () {
// Wait until the commandQueue/execturo is done (it may need to stop
// Wait until the commandQueue/exectutor is done (it may need to stop
// batch runners, browser controllers, ....)
commandQueue.done.then((_) {
cancelDebugTimer();